From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3FFA32BB3 for ; Fri, 26 Feb 2016 05:31:54 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 25 Feb 2016 20:31:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="921478945" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 25 Feb 2016 20:31:47 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 20:31:46 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 20:31:46 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 26 Feb 2016 12:31:44 +0800 From: "Wang, Xiao W" To: "Richardson, Bruce" , "Chen, Jing D" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding Thread-Index: AQHRXv2babUM9wifAkaFm8+HJNJY45867/aAgAAPUoCAASRUAIAAOwcAgAAkc4CAAAfsAIABMycA Date: Fri, 26 Feb 2016 04:31:43 +0000 Message-ID: References: <1454410216-13333-2-git-send-email-xiao.w.wang@intel.com> <1454557129-12825-2-git-send-email-xiao.w.wang@intel.com> <20160224154255.GA21808@bricha3-MOBL3> <13026611.uCVrZtfrBT@xps13> <4341B239C0EFF9468EE453F9E9F4604D04450107@shsmsx102.ccr.corp.intel.com> <20160225133518.GB20868@bricha3-MOBL3> <4341B239C0EFF9468EE453F9E9F4604D044503C3@shsmsx102.ccr.corp.intel.com> <20160225161406.GA22772@bricha3-MOBL3> In-Reply-To: <20160225161406.GA22772@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 04:31:54 -0000 Hi, > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, February 26, 2016 12:14 AM > To: Chen, Jing D > Cc: Thomas Monjalon ; Wang, Xiao W > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwardin= g >=20 > On Thu, Feb 25, 2016 at 03:45:45PM +0000, Chen, Jing D wrote: > > Hi, Bruce, > > > > > -----Original Message----- > > > From: Richardson, Bruce > > > Sent: Thursday, February 25, 2016 9:35 PM > > > To: Chen, Jing D > > > Cc: Thomas Monjalon ; Wang, Xiao W > > > ; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based > > > forwarding > > > > > > On Thu, Feb 25, 2016 at 10:04:02AM +0000, Chen, Jing D wrote: > > > > Hi, Bruce, Thomas, > > > > > > > > Best Regards, > > > > Mark > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas > > > Monjalon > > > > > Sent: Thursday, February 25, 2016 12:38 AM > > > > > To: Richardson, Bruce; Wang, Xiao W > > > > > Cc: dev@dpdk.org > > > > > Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based > > > > > forwarding > > > > > > > > > > 2016-02-24 15:42, Bruce Richardson: > > > > > > On Thu, Feb 04, 2016 at 11:38:47AM +0800, Wang Xiao W wrote: > > > > > > > This patch enables reading sglort info into mbuf for RX and > > > > > > > inserting an FTAG at the beginning of the packet for TX. The > > > > > > > vlan_tci_outer field selected from rte_mbuf structure for > > > > > > > sglort is not > > > used in fm10k now. > > > > > > > In FTAG based forwarding mode, the switch will forward > > > > > > > packets > > > > > according > > > > > > > to glort info in FTAG rather than mac and vlan table. > > > > > > > > > > > > > > To activate this feature, user needs to turn > > > > > ``CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD`` > > > > > > > to y in common_linuxapp or common_bsdapp. Currently this > > > > > > > feature is > > > > > supported > > > > > > > only on PF, because FM10K_PFVTCTL register is read-only for V= F. > > > > > > > > > > > > > > Signed-off-by: Wang Xiao W > > > > > > > > > > > > Any comments on this patch? > > > > > > > > > > > > My thoughts: is there a way in which this could be done > > > > > > without adding in a > > > > > new > > > > > > build time config option? > > > > > > > > > > Bruce, it's simpler to explain that build time options are > > > > > forbidden to enable such options. > > > > > Or the terrific kid's approach: one day, the Big Build-Option > > > > > Eater will come and will eat every undecided features! ;) > > > > > > > > This feature is trying to use FTAG (a unique tech in fm10k) > > > > instead of mac/vlan to forward packets. App need a way to tell PMD > > > > driver that which forwarding style it would like to use. > > > > > > Why not just specify this in the port configuration at setup time? > > > > > > > Please educate me. I think the port configuration flags are also > > common to all PMD Drivers. Is it possible to add a flag like "RTE_USE_F= TAG" > and pass to PMD driver? > > > They are. > For something PMD specific, like FTAG, it's always a challenge, and I don= 't > know off the top of my head if there is a simple option. However, given t= he > choice between an mbuf flag and a port config flag, I'd always choose the > former. > Other alternatives would be to have a fm10k specific API in the fm10k dri= ver > alone. >=20 > I'll let Thomas as ethdev maintainer comment if he has other suggestions = as to > how to handle this case. I suspect this won't be the first device-specifi= c piece of > functionality we need to deal with. >=20 > /Bruce Whatever method we choose, we have to find a way for the user to express hi= s need for FTAG, it maybe a build time config option, or a port config flag (no su= ch flag now), or a fast path flag in mbuf (no such flag now) etc. For the customer Topsec= 's use case, they use FTAG for all the TX packets, so all the above methods (per build c= onfig, per port config, per mbuf config) can meet their need. Since the pmd frame work= is for common, it's hard to add new fields only for one specific NIC, so I add a b= uild time config and make an introduction in the doc. Thanks for the discussion, Thomas, do you have any suggestions? BTW, I have found the patch needs to be rebased on head of dpdk-next-net/re= l_16_04 since several fm10k patches were applied recently. Best Regards, Xiao