From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding
Date: Mon, 29 Feb 2016 01:47:55 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF403DBAD771@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20160226163309.GA28808@bricha3-MOBL3>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Saturday, February 27, 2016 12:33 AM
> To: David Marchand <david.marchand@6wind.com>
> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding
>
> On Fri, Feb 26, 2016 at 04:00:49PM +0100, David Marchand wrote:
> > On Fri, Feb 26, 2016 at 3:48 PM, Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > On Fri, Feb 26, 2016 at 09:24:06AM +0000, Wang, Xiao W wrote:
> > >> Hi,
> > >> > > Thanks for the discussion, Thomas, do you have any suggestions?
> > >> >
> > >> > I don't understand why you say this feature is specific to fm10k.
> > >> > Can we imagine another NIC having this capability?
> > >>
> > >> As you know, fm10k has a switch logic between the Mac and Phy,
> > >> every packets Sent out from the host will be switched inside the
> > >> NIC, other NICs don't have a switch inside, and the FTAG feature is related
> to the switch function.
> > >>
> > >> As introduced in the second patch:
> > >> The FM10K family of NICs support the addition of a Fabric Tag
> > >> (FTAG) to carry special information. The FTAG is placed at the
> > >> beginning of the frame, it contains information such as where the
> > >> packet comes from and goes, and the vlan tag. In FTAG based
> > >> forwarding mode, the switch logic forwards packets according to glort
> (global resource tag) information, rather than the mac and vlan table.
> > >> So this is a feature specific to fm10k.
> > >
> > > If it is fm10k specific, how about just adding a public function to
> > > the fm10k driver to turn it on. The user app will be non-portable
> > > across NICs, but that's the price of using nic-specific features.
> >
> > What about using a devargs ?
> > Something like :
> > -w xxxx:xx:xx.x,enable_ftag=1
> >
> > The application still needs to know about this to enable it, but that
> > sounds better to me.
> > The only issue is that it can't work with hotplug at the moment.
> >
> Seems a good enough solution to me. Xiao, any other thoughts?
>
> /Bruce
I also agree with the devargs solution, in this way, the build time config can
be removed and we don't need to add extra fields into ethdev.
I'll rework the patch, thanks for the suggestions.
Best Regards,
Xiao
next prev parent reply other threads:[~2016-02-29 1:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 8:07 [dpdk-dev] [PATCH 0/3] " Wang Xiao W
2016-01-25 8:07 ` [dpdk-dev] [PATCH 1/3] " Wang Xiao W
2016-02-02 3:07 ` Qiu, Michael
2016-02-02 10:03 ` Wang, Xiao W
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 0/3] " Wang Xiao W
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 1/3] " Wang Xiao W
2016-02-03 6:52 ` Chen, Jing D
2016-02-04 2:39 ` Wang, Xiao W
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 0/3] " Wang Xiao W
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 1/3] " Wang Xiao W
2016-02-24 15:42 ` Bruce Richardson
2016-02-24 16:37 ` Thomas Monjalon
2016-02-24 17:05 ` Bruce Richardson
2016-02-25 10:04 ` Chen, Jing D
2016-02-25 13:35 ` Bruce Richardson
2016-02-25 15:45 ` Chen, Jing D
2016-02-25 16:14 ` Bruce Richardson
2016-02-26 4:31 ` Wang, Xiao W
2016-02-26 9:06 ` Thomas Monjalon
2016-02-26 9:24 ` Wang, Xiao W
2016-02-26 14:48 ` Bruce Richardson
2016-02-26 15:00 ` David Marchand
2016-02-26 16:33 ` Bruce Richardson
2016-02-29 1:47 ` Wang, Xiao W [this message]
2016-02-26 20:48 ` Thomas Monjalon
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 0/3] " Wang Xiao W
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 1/3] " Wang Xiao W
2016-03-01 7:35 ` Thomas Monjalon
2016-03-01 11:06 ` Wang, Xiao W
2016-03-01 22:37 ` Stephen Hemminger
2016-03-02 6:05 ` Wang, Xiao W
2016-03-02 13:47 ` Thomas Monjalon
2016-03-02 11:19 ` [dpdk-dev] [PATCH v5 0/2] " Wang Xiao W
2016-03-02 11:19 ` [dpdk-dev] [PATCH v5 1/2] " Wang Xiao W
2016-03-10 16:32 ` Bruce Richardson
2016-03-02 11:19 ` [dpdk-dev] [PATCH v5 2/2] doc: add introduction for fm10k " Wang Xiao W
2016-03-08 7:57 ` [dpdk-dev] [PATCH v5 0/2] fm10k: enable " Liu, Yong
2016-03-10 3:34 ` Wang, Xiao W
2016-03-10 16:40 ` Bruce Richardson
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 2/3] doc: add introduction for fm10k " Wang Xiao W
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 2/3] doc: add introduction for fm10k FTAG based forwarding Wang Xiao W
2016-02-22 14:06 ` Mcnamara, John
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-02-22 13:51 ` Mcnamara, John
2016-02-04 9:47 ` [dpdk-dev] [PATCH v3 0/3] fm10k: enable FTAG based forwarding Chen, Jing D
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 2/3] doc: add introduction for fm10k " Wang Xiao W
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-01-25 8:07 ` [dpdk-dev] [PATCH 2/3] doc: add introduction for fm10k FTAG based forwarding Wang Xiao W
2016-01-25 8:07 ` [dpdk-dev] [PATCH 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-02-01 16:20 ` Mcnamara, John
2016-01-26 6:01 ` [dpdk-dev] [PATCH 0/3] fm10k: enable FTAG based forwarding Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF403DBAD771@SHSMSX101.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).