From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2B1DBADA8 for ; Wed, 2 Mar 2016 07:05:22 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 01 Mar 2016 22:05:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,527,1449561600"; d="scan'208";a="662286430" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 01 Mar 2016 22:05:22 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Mar 2016 22:05:20 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Mar 2016 22:05:20 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by shsmsx102.ccr.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0248.002; Wed, 2 Mar 2016 14:05:18 +0800 From: "Wang, Xiao W" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding Thread-Index: AQHRc3xjE7Epp/fi6E6gGBp6+eB+259EqOSAgAD4D6A= Date: Wed, 2 Mar 2016 06:05:18 +0000 Message-ID: References: <1454557129-12825-2-git-send-email-xiao.w.wang@intel.com> <1456810601-7419-1-git-send-email-xiao.w.wang@intel.com> <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com> <20160301143751.710ef28e@xeon-e3> In-Reply-To: <20160301143751.710ef28e@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 06:05:22 -0000 Hi, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, March 2, 2016 6:38 AM > To: Wang, Xiao W > Cc: Chen, Jing D ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwardin= g >=20 > On Tue, 1 Mar 2016 13:36:39 +0800 > Wang Xiao W wrote: >=20 > > > > +static int > > +fm10k_check_ftag(struct rte_devargs *devargs) { > > + if (devargs =3D=3D NULL) > > + return 0; > > + > > + if (strstr(devargs->args, "enable_ftag=3D1") =3D=3D NULL) > > + return 0; > > + > > + return 1; > > +} > > + >=20 > It is good to see the DPDK keeping up with the leading edge of hardware > support. >=20 > My issue is that devargs are the Linux module parameters method of > configuration in the DPDK world. They are an API only a developer would = love.. DPDK supports passing string parameter (devargs) for every pci device to EA= L, it's like: "./test -w 84:00.0,enable_ftag=3D1 -w 86:00.0,enable_ftag=3D1 -c f -n 4". We have discussed (in v3) on how to configure the specific feature for fm10= k (by means of adding a build time config option, or changing the common ethdev structu= re, or changing the mbuf structure), neither adding extra build config option n= or changing the common structure looks satisfactory, and we think using devarg= s is a good enough solution. >=20 > 1. It has to be done at boot > 2. Applications have to rewrite (or expect customer) to pass args 3. Ca= n't be > changed at runtime 4. Can't be selected on per device basis. Customers configure the FTAG feature according to their need. We just parse the devargs at dev_start and set FTAG flag for RX/TX queues, = we (or the customers) needn't to change the devargs at runtime. In DPDK devargs is designed for each pci device, each device has its own po= inter for devargs structure. Thank you for the comment. Best Regards, Xiao