From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiao.w.wang@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id A594311D9
 for <dev@dpdk.org>; Thu,  3 Mar 2016 04:51:29 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 02 Mar 2016 19:51:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,531,1449561600"; d="scan'208";a="925677854"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by orsmga002.jf.intel.com with ESMTP; 02 Mar 2016 19:51:28 -0800
Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 2 Mar 2016 19:51:28 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by
 fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 2 Mar 2016 19:51:27 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002;
 Thu, 3 Mar 2016 11:51:26 +0800
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] ixgbe: support multicast promiscuous
 mode on VF
Thread-Index: AdFnzDxJLX+QRNj6QAaCzgnTbjdYlwNMwAcg
Date: Thu, 3 Mar 2016 03:51:25 +0000
Message-ID: <B7F2E978279D1D49A3034B7786DACF403DBAE795@SHSMSX101.ccr.corp.intel.com>
References: <6A0DE07E22DDAD4C9103DF62FEBC09090342A9EA@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342A9EA@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: support multicast promiscuous mode
 on VF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 03:51:30 -0000

Hi,

> > > +
> > > +	err =3D mbx->ops.write_posted(hw, msgbuf, 2, 0);
> > > +	if (err)
> > > +		return err;
> > > +
> > > +	err =3D mbx->ops.read_posted(hw, msgbuf, 2, 0);
> >
> > Is it more reasonable to read a message of size 1 than 2? Pf side only
> > write 1 word into mbx.
> Thanks for the comment. But actually PF writes 16 words into the mbx, and=
 2
> words have meaning.
> Word0 is used to check ack/nack. PF uses word1 to write the xcast_mode ba=
ck.
> I don't check the word1 because I don't see the necessary:)
>=20
> >

OK, I learned that kernel PF put 2 words into mbx for this message.

Acked-by: Xiao Wang <xiao.w.wang@intel.com>