From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 72D23293B for ; Tue, 8 Mar 2016 15:33:13 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 08 Mar 2016 06:33:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,556,1449561600"; d="scan'208";a="932205787" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 08 Mar 2016 06:33:00 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Mar 2016 06:33:00 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Mar 2016 06:33:00 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002; Tue, 8 Mar 2016 22:32:58 +0800 From: "Wang, Xiao W" To: "Chen, Jing D" , "Richardson, Bruce" Thread-Topic: [PATCH v3 00/18] fm10k: update shared code Thread-Index: AQHRawXC9kS4WUaleEiDMjIUC/OfNJ9PH2kAgACTPwD//33ogIAAhpsA Date: Tue, 8 Mar 2016 14:32:56 +0000 Message-ID: References: <1453866647-16215-2-git-send-email-xiao.w.wang@intel.com> <1455880025-6912-1-git-send-email-xiao.w.wang@intel.com> <20160308132403.GC8716@bricha3-MOBL3> <4341B239C0EFF9468EE453F9E9F4604D04457344@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D04457344@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 14:33:14 -0000 Hi Mark, > -----Original Message----- > From: Chen, Jing D > Sent: Tuesday, March 8, 2016 10:25 PM > To: Wang, Xiao W ; Richardson, Bruce > > Cc: dev@dpdk.org; He, Shaopeng > Subject: RE: [PATCH v3 00/18] fm10k: update shared code >=20 > Hi, Xiao >=20 > > -----Original Message----- > > From: Wang, Xiao W > > Sent: Tuesday, March 8, 2016 8:15 AM > > To: Richardson, Bruce ; Chen, Jing D > > > > Cc: Chen, Jing D ; dev@dpdk.org; He, Shaopeng > > > > Subject: RE: [PATCH v3 00/18] fm10k: update shared code > > > > > > > > > -----Original Message----- > > > From: Richardson, Bruce > > > Sent: Tuesday, March 8, 2016 9:24 PM > > > To: Wang, Xiao W ; Chen, Jing D > > > > > > Cc: Chen, Jing D ; dev@dpdk.org; He, Shaopeng > > > > > > Subject: Re: [PATCH v3 00/18] fm10k: update shared code > > > > > > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote: > > > > v3: > > > > * Fixed checkpatch.pl warning about long commit message. > > > > * Fixed the issue of compile failure about part of patches applied. > > > > * Split the misc-small-fixes patch into several patches. > > > > > > > > v2: > > > > * Put the two extra fix patches ahead of the base code patches. > > > > > > > > This patch set has passed regression test. > > > > > > > > Wang Xiao W (18): > > > > fm10k: use default mailbox message handler for PF > > > > fm10k/base: correct typecast in fm10k_update_xc_addr_pf > > > > fm10k/base: cleanup namespace pollution > > > > fm10k/base: use bitshift for itr_scale > > > > fm10k/base: reset max_queues on init_hw_vf failure > > > > fm10k/base: document ITR scale workaround in VF TDLEN register > > > > fm10k/base: cleanup lines over 80 characters > > > > fm10k/base: cleanup useless else > > > > fm10k/base: use BIT macro instead of open-coded bit-shifting of 1 > > > > fm10k/base: do not use CamelCase > > > > fm10k/base: use memcpy for mac addr copy > > > > fm10k/base: allow removal of is_slot_appropriate function > > > > fm10k/base: consistently use VLAN ID when referencing vid variabl= es > > > > fm10k/base: imporve comment per upstream review changes > > > > fm10k/base: fix TLV structures alignment > > > > fm10k/base: move constants to the right of binary operators > > > > fm10k/base: minor cleanups > > > > fm10k/base: remove unused struct element > > > > > > > > drivers/net/fm10k/base/fm10k_api.c | 2 + > > > > drivers/net/fm10k/base/fm10k_api.h | 2 + > > > > drivers/net/fm10k/base/fm10k_mbx.c | 63 +++++++----- > > > > drivers/net/fm10k/base/fm10k_mbx.h | 11 +-- > > > > drivers/net/fm10k/base/fm10k_osdep.h | 32 ++++++ > > > > drivers/net/fm10k/base/fm10k_pf.c | 88 +++++++++-------- > > > > drivers/net/fm10k/base/fm10k_pf.h | 18 ++-- > > > > drivers/net/fm10k/base/fm10k_tlv.c | 40 ++++---- > > > > drivers/net/fm10k/base/fm10k_tlv.h | 9 +- > > > > drivers/net/fm10k/base/fm10k_type.h | 182 > > > > +++++++--------------------- > > ------- > > > > drivers/net/fm10k/base/fm10k_vf.c | 32 ++++-- > > > > drivers/net/fm10k/fm10k_ethdev.c | 41 +++----- > > > > 12 files changed, 222 insertions(+), 298 deletions(-) > > > > > > > > -- > > > > 1.9.3 > > > > > > > Hi Mark, > > > > > > Can we get fm10k maintainer review and/or ack on this patchset please= . > > > > > > Thanks, > > > /Bruce > > > > Hi Bruce, > > > > Mark has reviewed and acked the patch set in v2, and I put the "Acked-b= y " > > in the v3 01/18 patch. > > It's the same for my FTAG patch. > > >=20 > It's better to add acked-by in both patch set and cover letter, this may = be more > helpful for maintainers. >=20 > > Best Regards, > > Xiao OK, I've realized this. Thanks, Xiao