From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D88F22716 for ; Wed, 31 Aug 2016 11:02:22 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 31 Aug 2016 02:02:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,261,1470726000"; d="scan'208";a="1033527963" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 31 Aug 2016 02:02:22 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 02:02:21 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 02:02:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.91]) by shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0248.002; Wed, 31 Aug 2016 17:02:19 +0800 From: "Wang, Xiao W" To: Olivier Matz , "Chen, Jing D" CC: "dev@dpdk.org" Thread-Topic: [PATCH 1/5] net/fm10k: add back Rx checksum offload Thread-Index: AQHR/vjx85QQrUmdrEKn91B6gM06faBaUnGAgAh7ymA= Date: Wed, 31 Aug 2016 09:02:18 +0000 Message-ID: References: <1472147299-2376-1-git-send-email-xiao.w.wang@intel.com> <1472147299-2376-2-git-send-email-xiao.w.wang@intel.com> <1d4aec4b-8f58-8739-c21f-04b09ecca05a@6wind.com> In-Reply-To: <1d4aec4b-8f58-8739-c21f-04b09ecca05a@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODI0MDc4MWEtYTMzNy00YTg1LWI5YTItM2U0ZDM4NDg3MWFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRkZDA1YjRSSWVqRjJnM09TYVNXeXk1MG5RRE90Z1wvRCt2ZWJPTElzVUdrPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/5] net/fm10k: add back Rx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 09:02:23 -0000 Hi Olivier, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Friday, August 26, 2016 3:27 PM > To: Wang, Xiao W ; Chen, Jing D > > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/5] net/fm10k: add back Rx checksum offload >=20 > Hi Xiao, >=20 > On 08/25/2016 07:48 PM, Xiao Wang wrote: > > A previous patch (http://dpdk.org/dev/patchwork/patch/12937/) removed > > some necessary lines about Rx checksum by mistake, this patch adds > > them back. > > > > Fixes: 6046898f5097 ("net/mbuf: remove unused Rx error flags") > > > > Signed-off-by: Xiao Wang >=20 > Just a small comment about the title, what do you thinkg about: > "net/fm10k: fix Rx checksum flags" ? > I think having the word "fix" in the title would help for finding these > commits for the stable version. >=20 > Apart from that, thanks for fixing my mistake :) >=20 >=20 > Regards, > Olivier I agree with you, will change the commit log in V2. Best Regards, Xiao