From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F1A051DB1 for ; Wed, 31 Aug 2016 11:08:45 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 31 Aug 2016 02:08:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,261,1470726000"; d="scan'208";a="1043822380" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 31 Aug 2016 02:08:42 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 02:08:29 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 02:08:28 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.91]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.102]) with mapi id 14.03.0248.002; Wed, 31 Aug 2016 17:07:43 +0800 From: "Wang, Xiao W" To: Olivier Matz , "Chen, Jing D" CC: "dev@dpdk.org" Thread-Topic: [PATCH 4/5] net/ixgbe: implement new Rx checksum flag Thread-Index: AQHR/vjtWz1E0AxjZ0K21vOBEU9rnqBaU0qAgAh7jtA= Date: Wed, 31 Aug 2016 09:07:43 +0000 Message-ID: References: <1472147299-2376-1-git-send-email-xiao.w.wang@intel.com> <1472147299-2376-5-git-send-email-xiao.w.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjQ3YzNlMWQtZTFjMi00MThmLWIzMDUtYzIxNzg3MjM1N2FmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjcxR01XcWVaaEwySEdOMWg3d3FcL24wN0s3a1FVZEZWcVJrMTZXdVRVcFE0PSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/5] net/ixgbe: implement new Rx checksum flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 09:08:46 -0000 Hi Olivier, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Friday, August 26, 2016 3:30 PM > To: Wang, Xiao W ; Chen, Jing D > > Cc: dev@dpdk.org > Subject: Re: [PATCH 4/5] net/ixgbe: implement new Rx checksum flag >=20 > Hi Xiao, >=20 > On 08/25/2016 07:48 PM, Xiao Wang wrote: > > Add CKSUM_GOOD flag to distinguish a good checksum from an unknown > one. > > > > Signed-off-by: Xiao Wang > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_r= xtx.c > > index 8a306b0..d2dc82a 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -1345,7 +1345,9 @@ rx_desc_error_to_pkt_flags(uint32_t rx_status) > > * Bit 30: L4I, L4I integrity error > > */ > > static uint64_t error_to_pkt_flags_map[4] =3D { > > - 0, PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, > > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD, > > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD, > > + PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD, > > PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD > > }; > > pkt_flags =3D error_to_pkt_flags_map[(rx_status >> > > >=20 > I think this would somehow conflict with the patch adding the support of > Rx checksum offload in vector receive function: >=20 > http://dpdk.org/dev/patchwork/patch/14630/ >=20 > Depending on which one is pushed first, the second one would need to be > reworked. >=20 > Olivier Yes, since your patch supports cksum in vector Rx, I'll add the new cksum f= lags for it based on your patch. Best Regards, Xiao