From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 64DED58C3 for ; Fri, 23 Sep 2016 05:50:54 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 22 Sep 2016 20:50:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,380,1470726000"; d="scan'208";a="12451392" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 22 Sep 2016 20:50:52 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Sep 2016 20:50:52 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Sep 2016 20:50:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.118]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.95]) with mapi id 14.03.0248.002; Fri, 23 Sep 2016 11:50:51 +0800 From: "Wang, Xiao W" To: "Yigit, Ferruh" , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 16/39] net/ixgbe/base: bump mailbox version Thread-Index: AQHSAHqNyTDbV8T7wEqcvnUdLrgt3qCAqGcAgAXxGMA= Date: Fri, 23 Sep 2016 03:50:50 +0000 Message-ID: References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> <1472312902-16963-17-git-send-email-xiao.w.wang@intel.com> <2a055f6d-c97b-79c1-7e86-83d9a869244d@intel.com> In-Reply-To: <2a055f6d-c97b-79c1-7e86-83d9a869244d@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDQxZWQxY2UtODVjZi00ZTFkLWE4ODEtM2Q2ZTI4YTA5M2QyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRQNVhORERyZ3BpSTJpTmRDdE1iTzZsYmM4QVNrNUpVejNDRXMyYUt6SWs9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 16/39] net/ixgbe/base: bump mailbox version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 03:50:55 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, September 20, 2016 1:03 AM > To: Wang, Xiao W ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 16/39] net/ixgbe/base: bump mailbox versio= n >=20 > On 8/27/2016 4:47 PM, Xiao Wang wrote: > > This patch will pave the way for the new VF unicast promiscuous > > mode support. > > > > Signed-off-by: Xiao Wang > > --- > > drivers/net/ixgbe/base/ixgbe_mbx.h | 5 +++-- > > drivers/net/ixgbe/base/ixgbe_vf.c | 2 ++ > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h > b/drivers/net/ixgbe/base/ixgbe_mbx.h > > index c3e301f..7556a81 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_mbx.h > > +++ b/drivers/net/ixgbe/base/ixgbe_mbx.h > > @@ -90,6 +90,7 @@ enum ixgbe_pfvf_api_rev { > > ixgbe_mbox_api_20, /* API version 2.0, solaris Phase1 VF driver */ > > ixgbe_mbox_api_11, /* API version 1.1, linux/freebsd VF driver */ > > ixgbe_mbox_api_12, /* API version 1.2, linux/freebsd VF driver */ > > + ixgbe_mbox_api_13, /* API version 1.3, linux/freebsd VF driver */ > > /* This value should always be last */ > > ixgbe_mbox_api_unknown, /* indicates that API version is not > known */ > > }; > > @@ -109,8 +110,8 @@ enum ixgbe_pfvf_api_rev { > > #define IXGBE_VF_GET_QUEUES 0x09 /* get queue configuration */ > > > > /* mailbox API, version 1.2 VF requests */ > > -#define IXGBE_VF_GET_RETA 0x0a /* VF request for RETA */ > > -#define IXGBE_VF_GET_RSS_KEY 0x0b /* get RSS key */ > > +#define IXGBE_VF_GET_RETA 0x0a /* VF request for RETA */ > > +#define IXGBE_VF_GET_RSS_KEY 0x0b /* get RSS key */ >=20 > is this intentional, since breaks tab alignment, and the values are not > changes actually. >=20 Such minor change is to keep in consistency with kernel base code. I need to put all such modifications into one cleanup patch. > > #define IXGBE_VF_UPDATE_XCAST_MODE 0x0c