From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 87D195323; Thu, 22 Jun 2017 04:31:43 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2017 19:31:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,371,1493708400"; d="scan'208";a="117823603" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2017 19:31:42 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 21 Jun 2017 19:31:42 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 21 Jun 2017 19:31:41 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.197]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Thu, 22 Jun 2017 10:31:39 +0800 From: "Wang, Xiao W" To: "Chen, Jing D" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/fm10k: initialize link status in device start Thread-Index: AQHS2bSkDrKDbbVyjE201obkjpgoQqIuNJoAgAIW4HA= Date: Thu, 22 Jun 2017 02:31:38 +0000 Message-ID: References: <1496228822-6753-1-git-send-email-xiao.w.wang@intel.com> <4341B239C0EFF9468EE453F9E9F4604D3C66E99C@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D3C66E99C@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDM4Mjc3YTUtNThiYy00N2VlLWExYjUtYWNlZTg0N2JmNGQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjIxTXM0SzRtamJJV0VqUWlvazRWUzYrdnZ1ellORjdZS2tpZ3pnU1dZbkE9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: initialize link status in device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 02:31:44 -0000 Hi, > -----Original Message----- > From: Chen, Jing D > Sent: Wednesday, June 21, 2017 10:36 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/fm10k: initialize link status in device start >=20 > Hi, >=20 > > -----Original Message----- > > From: Wang, Xiao W > > Sent: Wednesday, May 31, 2017 7:07 PM > > To: Chen, Jing D > > Cc: dev@dpdk.org; Wang, Xiao W ; > > stable@dpdk.org > > Subject: [PATCH] net/fm10k: initialize link status in device start > > > > If port LSC interrupt is configured, application will read link status = directly, > so > > driver need to prepare that value in advance. >=20 > Fm10k host driver can't manage PHY directly and provide a fake link statu= s, > so it always provide a constant value, whatever lsc is set or not. > I think you need to reorganize the message. :) OK, thanks. >=20 > > > > Fixes: 9ae6068c86da ("fm10k: add dev start/stop") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiao Wang > > --- > > drivers/net/fm10k/fm10k_ethdev.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > > b/drivers/net/fm10k/fm10k_ethdev.c > > index a742eec..54bf10c 100644 > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > @@ -84,6 +84,8 @@ static void fm10k_MAC_filter_set(struct rte_eth_dev > > *dev, static void fm10k_set_rx_function(struct rte_eth_dev *dev); sta= tic > > void fm10k_set_tx_function(struct rte_eth_dev *dev); static int > > fm10k_check_ftag(struct rte_devargs *devargs); > > +static int fm10k_link_update(struct rte_eth_dev *dev, > > + __rte_unused int wait_to_complete); > > > > struct fm10k_xstats_name_off { > > char name[RTE_ETH_XSTATS_NAME_SIZE]; > > @@ -1166,6 +1168,9 @@ static inline int fm10k_glort_valid(struct > fm10k_hw > > *hw) > > if (!(dev->data->dev_conf.rxmode.mq_mode & > > ETH_MQ_RX_VMDQ_FLAG)) > > fm10k_vlan_filter_set(dev, hw->mac.default_vid, true); > > > > + if (dev->data->dev_conf.intr_conf.lsc !=3D 0) > > + fm10k_link_update(dev, 0); > > + >=20 > I'll recommend updating link status anyway when port starts, not consider= ing > lsc set status. Agree, will send v2. BRs, Xiao