From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B0E271B749 for ; Thu, 5 Apr 2018 13:01:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 04:01:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,410,1517904000"; d="scan'208";a="43650892" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2018 04:01:42 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 5 Apr 2018 04:01:42 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 5 Apr 2018 04:01:42 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.88]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.43]) with mapi id 14.03.0319.002; Thu, 5 Apr 2018 19:01:40 +0800 From: "Wang, Xiao W" To: Thomas Monjalon CC: Hemant Agrawal , "dev@dpdk.org" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions Thread-Index: AQHTy+m1du0aCy0OeUazv5p2S4/2fqPx19iw//+aRwCAAIlq8A== Date: Thu, 5 Apr 2018 10:35:44 +0000 Message-ID: References: <1522753815-28718-1-git-send-email-hemant.agrawal@nxp.com> <1522828120-16100-2-git-send-email-hemant.agrawal@nxp.com> <60929980.gmd1JhcyUE@xps> In-Reply-To: <60929980.gmd1JhcyUE@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWI3MjY0NTEtNzY1ZS00MGJhLWIxNGQtNWRiMDUxZTdjMWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIzVnFRWjNMMER3aCtNOUR4dVZrOXhuWjd2bTdqbUZUSExhRkRoV0hMTHEwazVjdTJzOW1UREdHNndWMUMrbmlrIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 11:01:44 -0000 Yes, it's private. We could do that if really needed. BRs, Xiao > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, April 5, 2018 6:23 PM > To: Wang, Xiao W > Cc: Hemant Agrawal ; dev@dpdk.org; Burakov, > Anatoly > Subject: Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio fun= ctions >=20 > 05/04/2018 11:03, Wang, Xiao W: >=20 > > > +int rte_vfio_get_group_num(const char *sysfs_base, const char > *dev_addr, > > > + int *iommu_group_num); > > > +int rte_vfio_get_container_fd(void); > > > +int rte_vfio_get_group_fd(int iommu_group_num); > > > > Considering the "group_no" field defined in eal_vfio.h, will > "iommu_group_num" cause inconsistency > > In naming? >=20 > I asked to change the function name to "num" because it is more meaningfu= l. > "group_no" field is private? Can it be renamed? >=20