From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 15BF2374 for ; Wed, 25 Apr 2018 06:13:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 21:13:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="219166393" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 24 Apr 2018 21:13:27 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Apr 2018 21:13:27 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.210]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 12:13:25 +0800 From: "Wang, Xiao W" To: Jens Freimann , "dev@dpdk.org" CC: "Bie, Tiwei" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mst@redhat.com" , "jens@freimann.org" Thread-Topic: [dpdk-dev] [PATCH v4 05/20] net/virtio: dump packed virtqueue data Thread-Index: AQHT161m0vjytoPJrECkRD44pUWM5qQQ41Yg Date: Wed, 25 Apr 2018 04:13:25 +0000 Message-ID: References: <20180419070751.8933-1-jfreimann@redhat.com> <20180419070751.8933-6-jfreimann@redhat.com> In-Reply-To: <20180419070751.8933-6-jfreimann@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTAxYTQ3NzItZGUzOS00NzFmLWI5YjktOGUxOWQ3NWYzMzZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ6dUJqdlhURjNcLzFhK01mRnFKR2tRankrTmFqRzdWQWU1dGxpMWwwUWZMWXM0SWF3cUxwbWZpN3M0amJJdU94dyJ9 dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 05/20] net/virtio: dump packed virtqueue data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 04:13:29 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jens Freimann > Sent: Thursday, April 19, 2018 3:08 PM > To: dev@dpdk.org > Cc: Bie, Tiwei ; yliu@fridaylinux.org; > maxime.coquelin@redhat.com; mst@redhat.com; jens@freimann.org > Subject: [dpdk-dev] [PATCH v4 05/20] net/virtio: dump packed virtqueue da= ta >=20 > Add support to dump packed virtqueue data to the > VIRTQUEUE_DUMP() macro. >=20 > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtqueue.h | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueu= e.h > index 081b27a52..ea804c9c7 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -379,6 +379,12 @@ virtqueue_notify(struct virtqueue *vq) >=20 > #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DUMP > #define VIRTQUEUE_DUMP(vq) do { \ > + if (vtpci_packed_queue((vq)->hw)) { \ > + PMD_INIT_LOG(DEBUG, \ > + "VQ: - size=3D%d; free=3D%d; last_used_idx=3D%d;" \ Miss a "," after the output format. "last_used_idx" is a stranger here. > + (vq)->vq_nentries, (vq)->vq_free_cnt, nused); \ The "nused" is not declared yet here. BRs, Xiao > + break; \ > + } \ > uint16_t used_idx, nused; \ > used_idx =3D (vq)->vq_ring.used->idx; \ > nused =3D (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ > -- > 2.14.3