From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EF85F1EC12 for ; Wed, 13 Jun 2018 04:46:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2018 19:46:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,217,1526367600"; d="scan'208";a="232124904" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 12 Jun 2018 19:46:07 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Jun 2018 19:46:07 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.82]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Wed, 13 Jun 2018 10:46:06 +0800 From: "Wang, Xiao W" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [PATCH v2 08/15] net/ifc: rename to ifcvf Thread-Index: AQHT/26igwwevxbed0+wQV4u/XKwhaRdgctg Date: Wed, 13 Jun 2018 02:46:05 +0000 Message-ID: References: <20180517201526.28658-1-bruce.richardson@intel.com> <20180608212048.67261-1-bruce.richardson@intel.com> <20180608212048.67261-9-bruce.richardson@intel.com> In-Reply-To: <20180608212048.67261-9-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDZmNDZjYjEtNWNjOS00NTFlLWI4MDgtY2M0ZWU3ZmZjOGU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFY4RDExbm9cL09ScEtNRlhDTlliQ0N5TXhKdjNhYXZneld3b2gzb3g5clBKNUlOQTFWXC9pUXJJMlZacDVOMEc2In0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 02:46:09 -0000 Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Saturday, June 9, 2018 5:21 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wang, Xiao W > > Subject: [PATCH v2 08/15] net/ifc: rename to ifcvf >=20 > All files in the directory and the resulting driver have prefix of ifcvf, > not just ifc, so rename directory for accuracy. Also rename the map file > to standard name for meson build in the process. Compared with renaming the dir to IFCVF and renaming it back to IFC sometim= e in future, I think keeping the dir name as IFC is better for us, this avoids the extra= effort. We can just rename below files: doc/guides/nics/ifcvf.rst =3D> doc/guides/nics/ifc.rst drivers/net/ifc/rte_ifcvf_version.map =3D> drivers/net/ifc/rte_pmd_ifc_vers= ion. And yes, we need to update documents which refer to ifc. Thanks! Xiao >=20 > CC: Xiao Wang > Signed-off-by: Bruce Richardson > --- > MAINTAINERS | 4 ++-- > drivers/net/Makefile | 2 +- > drivers/net/{ifc =3D> ifcvf}/Makefile | 2 +- > drivers/net/{ifc =3D> ifcvf}/base/ifcvf.c | 0 > drivers/net/{ifc =3D> ifcvf}/base/ifcvf.h | 0 > drivers/net/{ifc =3D> ifcvf}/base/ifcvf_osdep.h | 0 > drivers/net/{ifc =3D> ifcvf}/ifcvf_vdpa.c | 0 > .../rte_ifcvf_version.map =3D> ifcvf/rte_pmd_ifcvf_version.map} | 0 > 8 files changed, 4 insertions(+), 4 deletions(-) > rename drivers/net/{ifc =3D> ifcvf}/Makefile (94%) > rename drivers/net/{ifc =3D> ifcvf}/base/ifcvf.c (100%) > rename drivers/net/{ifc =3D> ifcvf}/base/ifcvf.h (100%) > rename drivers/net/{ifc =3D> ifcvf}/base/ifcvf_osdep.h (100%) > rename drivers/net/{ifc =3D> ifcvf}/ifcvf_vdpa.c (100%) > rename drivers/net/{ifc/rte_ifcvf_version.map =3D> > ifcvf/rte_pmd_ifcvf_version.map} (100%) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 4667fa7fb..4f6055590 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -559,10 +559,10 @@ T: git://dpdk.org/next/dpdk-next-net-intel > F: drivers/net/avf/ > F: doc/guides/nics/features/avf*.ini >=20 > -Intel ifc > +Intel ifcvf > M: Xiao Wang > T: git://dpdk.org/next/dpdk-next-net-intel > -F: drivers/net/ifc/ > +F: drivers/net/ifcvf/ > F: doc/guides/nics/ifcvf.rst > F: doc/guides/nics/features/ifcvf.ini >=20 > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > index 9f9da6651..9308f9a7b 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -59,7 +59,7 @@ endif # $(CONFIG_RTE_LIBRTE_SCHED) > ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) +=3D vhost > ifeq ($(CONFIG_RTE_EAL_VFIO),y) > -DIRS-$(CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD) +=3D ifc > +DIRS-$(CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD) +=3D ifcvf > endif > endif # $(CONFIG_RTE_LIBRTE_VHOST) >=20 > diff --git a/drivers/net/ifc/Makefile b/drivers/net/ifcvf/Makefile > similarity index 94% > rename from drivers/net/ifc/Makefile > rename to drivers/net/ifcvf/Makefile > index 1011995bc..a022faaad 100644 > --- a/drivers/net/ifc/Makefile > +++ b/drivers/net/ifcvf/Makefile > @@ -22,7 +22,7 @@ BASE_DRIVER_OBJS=3D$(sort $(patsubst %.c,%.o,$(notdir > $(wildcard $(SRCDIR)/base/*. >=20 > VPATH +=3D $(SRCDIR)/base >=20 > -EXPORT_MAP :=3D rte_ifcvf_version.map > +EXPORT_MAP :=3D rte_pmd_ifcvf_version.map >=20 > LIBABIVER :=3D 1 >=20 > diff --git a/drivers/net/ifc/base/ifcvf.c b/drivers/net/ifcvf/base/ifcvf.= c > similarity index 100% > rename from drivers/net/ifc/base/ifcvf.c > rename to drivers/net/ifcvf/base/ifcvf.c > diff --git a/drivers/net/ifc/base/ifcvf.h b/drivers/net/ifcvf/base/ifcvf.= h > similarity index 100% > rename from drivers/net/ifc/base/ifcvf.h > rename to drivers/net/ifcvf/base/ifcvf.h > diff --git a/drivers/net/ifc/base/ifcvf_osdep.h > b/drivers/net/ifcvf/base/ifcvf_osdep.h > similarity index 100% > rename from drivers/net/ifc/base/ifcvf_osdep.h > rename to drivers/net/ifcvf/base/ifcvf_osdep.h > diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifcvf/ifcvf_vdpa.= c > similarity index 100% > rename from drivers/net/ifc/ifcvf_vdpa.c > rename to drivers/net/ifcvf/ifcvf_vdpa.c > diff --git a/drivers/net/ifc/rte_ifcvf_version.map > b/drivers/net/ifcvf/rte_pmd_ifcvf_version.map > similarity index 100% > rename from drivers/net/ifc/rte_ifcvf_version.map > rename to drivers/net/ifcvf/rte_pmd_ifcvf_version.map > -- > 2.17.1