From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4F49556A3 for ; Thu, 20 Sep 2018 06:33:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 21:33:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,397,1531810800"; d="scan'208";a="74463762" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 19 Sep 2018 21:33:52 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Sep 2018 21:33:51 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Sep 2018 21:33:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.39]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.227]) with mapi id 14.03.0319.002; Thu, 20 Sep 2018 12:33:49 +0800 From: "Wang, Xiao W" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , Rami Rosen , "Wang, Haiyue" Thread-Topic: [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA Thread-Index: AQHUS1PSVzTlONdeakuhtTFPhFmTWqT3rz9ggAACpoCAAO06kA== Date: Thu, 20 Sep 2018 04:33:49 +0000 Message-ID: References: <20180913180658.20562-1-xiaolong.ye@intel.com> <20180913180658.20562-2-xiaolong.ye@intel.com> <20180919222303.GC42303@intel.com> In-Reply-To: <20180919222303.GC42303@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDRmNWMwNjItN2ViNC00MmRkLWI1YzEtYmVhMjA0Mzk1NGUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoickVcLzd0UnJ4STRcL0pMMHNua204d0MzTngyQXVxU012WFNXaEVNNFdSSjFaWHB0Z3ZWNHlxMXBwSGxPVE9TU2x3In0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 04:33:54 -0000 Hi Xiaolong, > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, September 20, 2018 6:23 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong ; > Rami Rosen ; Wang, Haiyue > > Subject: Re: [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDP= A >=20 > On 09/19, Wang, Xiao W wrote: > >Hi Xiaolong, > > > [snip] > >> +.. note:: > >> + We need to bind VFIO-pci to VFs before running vdpa sample. > > > >Replace "VFIO-pci" with "vfio-pci". >=20 > Got it. >=20 > > > >> + > >> + * modprobe vfio-pci > >> + * ./usertools/dpdk-devbind.py -b vfio-pci 06:00.2 06:00.3 > >> + > >> +Then we can create 2 vdpa ports in interactive cmdline. > >> + > >> +.. code-block:: console > >> + > >> + vdpa> list > >> + device id device address > >> + 0 0000:06:00.2 > >> + 1 0000:06:00.3 > > > >Could we show out also the device's features and supported queue number? >=20 > Sure, it's a good suggestion. >=20 > [snip] > > > >> + ret =3D rte_vhost_driver_unregister(socket_path); > >> + if (ret !=3D 0) > >> + RTE_LOG(ERR, USER1, > >> + "Fail to unregister vhost driver for %s.\n", > >> + socket_path); > >> +} > >> + > >> +static void > >> +vdpa_sample_quit(void) > >> +{ > >> + int i; > >> + for (i =3D 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) { > > > >Double " ". >=20 > Sorry, not quite understand what's your meaning here. I mean there are 2 blank spaces after the "<" operator. BRs, Xiao