Re: [dpdk-dev] [PATCH] net/ifc: add live migration support

["Wang, Xiao W" <xiao.w.wang@intel.com>]

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, October 2, 2018 10:46 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>
> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Wang, Zhihong
> <zhihong.wang@intel.com>; Chao Zhu <chaozhu@linux.vnet.ibm.com>;
> Thomas Monjalon <thomas@monjalon.net>; Xu, Qian Q <qian.q.xu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/ifc: add live migration support
> 
> On 9/21/2018 12:55 AM, Ferruh Yigit wrote:
> > On 9/10/2018 12:01 PM, Xiao Wang wrote:
> >> IFCVF can help to log dirty page in live migration stage,
> >> each queue's index can be read and configured to support
> >> VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE.
> >>
> >> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> >
> > <...>
> >
> >> +static void
> >> +ifcvf_used_ring_log(struct ifcvf_hw *hw, uint32_t queue, uint8_t *log_buf)
> >> +{
> >> +	uint32_t i, size;
> >> +	uint64_t pfn;
> >> +
> >> +	pfn = hw->vring[queue].used / PAGE_SIZE;
> >> +	size = hw->vring[queue].size * sizeof(struct vring_used_elem) +
> >> +			sizeof(__virtio16) * 3;
> >
> > Getting a build error for PowerPC [1], can someone from PPC side confirm it
> please?
> >
> > [1]
> > .../drivers/net/ifc/ifcvf_vdpa.c: In function ‘ifcvf_used_ring_log’:
> > .../drivers/net/ifc/ifcvf_vdpa.c:288:11: error: ‘__virtio16’ undeclared (first
> > use in this function)
> >     sizeof(__virtio16) * 3;
> >            ^~~~~~~~~~
> 
> Also "__virtio16" seems added into Linux kernel on v3.19. Systems with kernel
> version less than this causing build error.
> 
> Can we replace "__virtio16" usage with basic types to prevent build error?
> If so can you please send this as a fix patch?

Yes, will do that.

BRs,
Xiao

> 
> Thanks,
> ferruh