Re: [dpdk-dev] [PATCH v4 06/10] net/ifc: detect if VDPA mode is specified

["Wang, Xiao W" <xiao.w.wang@intel.com>]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Sunday, December 16, 2018 1:17 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>
> Cc: alejandro.lucero@netronome.com; dev@dpdk.org; Wang, Zhihong
> <zhihong.wang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Subject: Re: [PATCH v4 06/10] net/ifc: detect if VDPA mode is specified
> 
> 
> 
> On 12/14/18 10:16 PM, Xiao Wang wrote:
> > If user wants the VF to be used in VDPA (vhost data path acceleration)
> > mode, then the user can add a "vdpa=1" parameter for the device.
> >
> > So if driver doesn't not find this option, it should quit and let the
> 
> s/doesn't not/does not/

Yes, I will fix the typo.

> 
> > bus continue the probe.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> >   drivers/net/ifc/Makefile     |  1 +
> >   drivers/net/ifc/ifcvf_vdpa.c | 47
> ++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 48 insertions(+)
> >
> 
> Should this option be documented somewhere?

Will add a section for this in the last doc patch.

Thanks,
Xiao

> 
> Apart from that:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime