[dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

[dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

[Rami Rosen]

This patch fixes an error in ifc NIC document; a previous patch 
changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD, 
but the ifc NIC doc file remained with the old name.

Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 doc/guides/nics/ifc.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
index bdf7b4e..317d9ff 100644
--- a/doc/guides/nics/ifc.rst
+++ b/doc/guides/nics/ifc.rst
@@ -19,7 +19,7 @@ Config File Options
 
 The following option can be modified in the ``config`` file.
 
-- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
+- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
 
   Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
 
-- 
1.8.3.1

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix an error in ifc NIC document

[Ferruh Yigit]

On 1/17/2019 2:50 PM, Rami Rosen wrote:
> This patch fixes an error in ifc NIC document; a previous patch 
> changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
> instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD, 
> but the ifc NIC doc file remained with the old name.
> 
> Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

[Wang, Xiao W]

Hi,

> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Thursday, January 17, 2019 10:51 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>; Rami Rosen
> <ramirose@gmail.com>
> Subject: [PATCH] doc: fix an error in ifc NIC document
> 
> This patch fixes an error in ifc NIC document; a previous patch
> changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
> instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
> but the ifc NIC doc file remained with the old name.
> 
> Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  doc/guides/nics/ifc.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
> index bdf7b4e..317d9ff 100644
> --- a/doc/guides/nics/ifc.rst
> +++ b/doc/guides/nics/ifc.rst
> @@ -19,7 +19,7 @@ Config File Options
> 
>  The following option can be modified in the ``config`` file.
> 
> -- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
> +- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
> 
>    Toggle compilation of the ``librte_ifcvf_vdpa`` driver.

Could we also squash below fix into this patch? Or we make a separate one since this patch is applied already.

-  Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
+  Toggle compilation of the ``librte_pmd_ifc`` driver.

BRs,
Xiao

Re: [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

[Ferruh Yigit]

On 1/18/2019 1:59 AM, Wang, Xiao W wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Rami Rosen [mailto:ramirose@gmail.com]
>> Sent: Thursday, January 17, 2019 10:51 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>; Rami Rosen
>> <ramirose@gmail.com>
>> Subject: [PATCH] doc: fix an error in ifc NIC document
>>
>> This patch fixes an error in ifc NIC document; a previous patch
>> changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
>> instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
>> but the ifc NIC doc file remained with the old name.
>>
>> Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
>> Cc: stable@dpdk.org
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>> ---
>>  doc/guides/nics/ifc.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
>> index bdf7b4e..317d9ff 100644
>> --- a/doc/guides/nics/ifc.rst
>> +++ b/doc/guides/nics/ifc.rst
>> @@ -19,7 +19,7 @@ Config File Options
>>
>>  The following option can be modified in the ``config`` file.
>>
>> -- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
>> +- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
>>
>>    Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
> 
> Could we also squash below fix into this patch? Or we make a separate one since this patch is applied already.
> 
> -  Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
> +  Toggle compilation of the ``librte_pmd_ifc`` driver.

Thanks for update.

Squashed in next-net, please check.