DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mo, YufengX" <yufengx.mo@intel.com>
To: Sunil Kumar Kori <skori@marvell.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of	rte_eth_dev_info
Date: Fri, 14 Jun 2019 05:31:49 +0000	[thread overview]
Message-ID: <B8B15C44A3F2C044966E545C7B7371153E7FD1AF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1558946129-5816-2-git-send-email-skori@marvell.com>

Hi, Sunil Kumar Kori

This series' patches have been merged on dpdk/master. They cause testpmd core dumped on intel nics.

./usertools/dpdk-devbind.py -b igb_uio 0000:xx:00.0 0000:xx:00.1
./x86_64-native-linuxapp-gcc/app/testpmd -v -c 0x3f -n 4  -- -i

Running environment as the following:

* OS:
fedora 20/22/27/30
3.16.4/4.4.14/5.1.0

* Compiler:
gcc version 5.3.1
gcc version 7.3.1
gcc version 4.8.3

* Hardware platform:
Broadwell-EP Xeon E5-2600
Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz

* NIC hardware:
fortville_spirit
Ethernet Controller XL710 for 40GbE QSFP+ 1583
version: 1.5.16
firmware-version: 6.01 0x800034a4 1.1747.0

fortville(25G 2 ports nic)
Ethernet Controller XXV710 for 25GbE SFP28 158b
driver: i40e
version: 2.1.14-k
firmware-version: 6.01 0x80003554 1.1747.0

fortville(10G 2 ports nic)
Ethernet Controller X710 for 10GbE SFP+ 1572
driver: i40e
version: 2.1.14-k
firmware-version: 6.01 0x800035b0 1.1747.0

niantic
Device_str: 82599ES 10-Gigabit SFI/SFP+ Network Connection
firmware: 0x61bf0001
ixgbe: 4.3.13
ixgbevf: 2.12.1-k


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sunil Kumar Kori
> Sent: Monday, May 27, 2019 4:35 PM
> To: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>; arybchenko@solarflare.com; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of rte_eth_dev_info
> 
> rte_eth_dev_info structure exposes, nb_seg_max & nb_mtu_seg_max
> to provide maximum number of supported segments for a given platform.
> 
> Defining UINT16_MAX as default value of above mentioned variables to
> expose support of infinite/maximum segments.
> 
> Based on above values, application can decide best size for buffers
> while creating mbuf pool.
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 2 ++
>  lib/librte_ethdev/rte_ethdev.h | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index d7cfa3d..6933757 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -2543,6 +2543,8 @@ struct rte_eth_dev *
>  		.nb_max = UINT16_MAX,
>  		.nb_min = 0,
>  		.nb_align = 1,
> +		.nb_seg_max = UINT16_MAX,
> +		.nb_mtu_seg_max = UINT16_MAX,
>  	};
> 
>  	RTE_ETH_VALID_PORTID_OR_RET(port_id);
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 1f35e1d..6bd30b1 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -2333,6 +2333,8 @@ int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id,
>   *      .nb_max = UINT16_MAX,
>   *      .nb_min = 0,
>   *      .nb_align = 1,
> + *	.nb_seg_max = UINT16_MAX,
> + *	.nb_mtu_seg_max = UINT16_MAX,
>   *  };
>   *
>   * device = dev->device
> --
> 1.8.3.1


  parent reply	other threads:[~2019-06-14  5:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  8:35 [dpdk-dev] [PATCH 0/2] Enabling default mbuf segments support Sunil Kumar Kori
2019-05-27  8:35 ` [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of rte_eth_dev_info Sunil Kumar Kori
2019-06-09 14:33   ` Andrew Rybchenko
2019-06-10 17:35     ` Ferruh Yigit
2019-06-14  5:31   ` Mo, YufengX [this message]
2019-06-14 16:51     ` Ferruh Yigit
2019-06-14 17:21       ` Ferruh Yigit
2019-06-17  1:38         ` Mo, YufengX
2019-05-27  8:35 ` [dpdk-dev] [PATCH 2/2] app/testpmd: creating mbuf pool based on maximum supported segments Sunil Kumar Kori
2019-06-10 17:45   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B8B15C44A3F2C044966E545C7B7371153E7FD1AF@shsmsx102.ccr.corp.intel.com \
    --to=yufengx.mo@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=skori@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).