From: Levend Sayar <levendsayar@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Elena Agostini <eagostini@nvidia.com>,
dev@dpdk.org, Aaron Conole <aconole@redhat.com>,
John Romein <romein@astron.nl>
Subject: Re: [PATCH] gpu/cuda: fix getenv related build error
Date: Fri, 6 Oct 2023 22:45:19 +0300 [thread overview]
Message-ID: <B8EFD909-EE26-478F-9C0C-CAAEBD5B0515@gmail.com> (raw)
In-Reply-To: <CAJFAV8x50MUOX5c0ZoT=EjMQc_-CgMxpYS7mHOtA08C5Z6yi2w@mail.gmail.com>
My pleasure.
Thanks for ACKing Elena.
Thanks for applying David.
Best,
Levend
> On 6 Oct 2023, at 13:07, David Marchand <david.marchand@redhat.com> wrote:
>
> On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:
>>
>> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
>> This causes gdrcopy.c build to give an error;
>> because compiler can not find signature of getenv.
>> stdlib.h is included for the definition of getenv function.
>>
>> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")
>>
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>
> Applied, thanks Levend.
>
>
> --
> David Marchand
>
prev parent reply other threads:[~2023-10-06 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 16:25 Levend Sayar
2023-09-29 15:00 ` David Marchand
2023-10-05 12:42 ` Elena Agostini
2023-10-06 10:07 ` David Marchand
2023-10-06 19:45 ` Levend Sayar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B8EFD909-EE26-478F-9C0C-CAAEBD5B0515@gmail.com \
--to=levendsayar@gmail.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=romein@astron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).