From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F63C426D5; Fri, 6 Oct 2023 21:45:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9331402E6; Fri, 6 Oct 2023 21:45:33 +0200 (CEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id E1F54402E1 for ; Fri, 6 Oct 2023 21:45:31 +0200 (CEST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-405497850dbso22831385e9.0 for ; Fri, 06 Oct 2023 12:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696621531; x=1697226331; darn=dpdk.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ST3RyiHcdW8I57TdlWBb6AOnVmCPJt/jciujRFFXMJM=; b=cD22W8ozJTH1/VlLPEWsghWCULzWliJwWKmL0cW3rSyngDgjCA06nptNs2rdMFHfu5 oZascuejAZxlCD43lNMj0wfDeQZKUtgG1B3uAEFqmC62rZOy02uFYadaSo5UND7XlsuA VYDsoXPJJDH/j64j9FfifVpk/0XNNtgyJU9cSPv2EnwoS3KHxCuuS4GVLlvEQeGb5rMf i+rYpeoFnndCGIfr/pSvLN53HLHlieBFQ3HN5EHdYxkv+nMcTqnVOrSpc4j9cxtgQY8w qwj6BkInx1Z4IHuGPuCdTmvkLPRidxIs5SDC9k9jU2+UK+bi+uEeOW7TUd6w3RMvOgjh 64Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696621531; x=1697226331; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ST3RyiHcdW8I57TdlWBb6AOnVmCPJt/jciujRFFXMJM=; b=LuXDVQNCVpf6A7r3sLoVC+zgZvD1HPUFvn0WcE5y6VqR+cY6/uIJU8bv8yA9Gl9EE4 5qydFNpXpK07h8juDTVGtxKnxfTpSluVYh9A47UGkK7ttqT3ShAbtL/yP9pkgJVRRY+u bmyd8lxKZwUgziCzp5gtAi1/3mvfJX5T0NQgneBu+RIhTcG00iHfg2y5dGYxxStYj2ce SNwHIhGM+EWbqIFppC3f6m4OR0fOFMf9vuMiUNzkOB3X47HDl5qV426/F3d5vyZdnFvw rc2M+djccUehRlEgEdHwB7HG3gZAeU5tna0i9ftvUiD0KNDWxJ0ktHvYmgFWYKx05yeD Cu3A== X-Gm-Message-State: AOJu0YxFqalgaK3ZzZTClG8rq/QgBBwgd92oUO9z4DaLb7Jsw0ieKanJ KSFL1Wzo3gLKPZgdXnfhrsM= X-Google-Smtp-Source: AGHT+IHkGVehjnc8bv6i9cbSWwoBm9eVhe0MaC0TPNFn1iaSJrYOOamf85rp2WpcCd5ojZ8uTFYyug== X-Received: by 2002:a05:600c:246:b0:405:3455:567e with SMTP id 6-20020a05600c024600b004053455567emr8040114wmj.5.1696621531306; Fri, 06 Oct 2023 12:45:31 -0700 (PDT) Received: from smtpclient.apple ([176.41.31.9]) by smtp.gmail.com with ESMTPSA id t4-20020a5d6904000000b0032710f5584fsm2294145wru.25.2023.10.06.12.45.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2023 12:45:31 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.73.1.1\)) Subject: Re: [PATCH] gpu/cuda: fix getenv related build error From: Levend Sayar In-Reply-To: Date: Fri, 6 Oct 2023 22:45:19 +0300 Cc: Elena Agostini , dev@dpdk.org, Aaron Conole , John Romein Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230803162512.41396-1-levendsayar@gmail.com> To: David Marchand X-Mailer: Apple Mail (2.3774.200.73.1.1) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org My pleasure. Thanks for ACKing Elena. Thanks for applying David. Best, Levend > On 6 Oct 2023, at 13:07, David Marchand = wrote: >=20 > On Thu, Aug 3, 2023 at 6:25=E2=80=AFPM Levend Sayar = wrote: >>=20 >> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. >> This causes gdrcopy.c build to give an error; >> because compiler can not find signature of getenv. >> stdlib.h is included for the definition of getenv function. >>=20 >> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions = parameters") >>=20 >> Signed-off-by: Levend Sayar >=20 > Applied, thanks Levend. >=20 >=20 > --=20 > David Marchand >=20