[PATCH] gpu/cuda: fix getenv related build error

[PATCH] gpu/cuda: fix getenv related build error

[Levend Sayar]

If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
This causes gdrcopy.c build to give an error;
because compiler can not find signature of getenv.
stdlib.h is included for the definition of getenv function.

Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
 drivers/gpu/cuda/gdrcopy.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c
index 322a5dbeb2..bd56b73ce4 100644
--- a/drivers/gpu/cuda/gdrcopy.c
+++ b/drivers/gpu/cuda/gdrcopy.c
@@ -6,6 +6,8 @@
 
 #ifdef DRIVERS_GPU_CUDA_GDRCOPY_H
 
+#include <stdlib.h>
+
 static void *gdrclib;
 static gdr_t (*sym_gdr_open)(void);
 static int (*sym_gdr_pin_buffer)(gdr_t g, unsigned long addr, size_t size,
-- 
2.39.2 (Apple Git-143)

Re: [PATCH] gpu/cuda: fix getenv related build error

[David Marchand]

On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:
>
> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
> This causes gdrcopy.c build to give an error;
> because compiler can not find signature of getenv.
> stdlib.h is included for the definition of getenv function.
>

There was a bug report for this issue:
Bugzilla ID: 1133

> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")

It is probably worth backporting:
Cc: stable@dpdk.org

>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>

Elena, this is a quick one, review please.


-- 
David Marchand

Re: [PATCH] gpu/cuda: fix getenv related build error

[Elena Agostini]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Sounds good to me

Thanks
EA

From: David Marchand <david.marchand@redhat.com>
Date: Friday, 29 September 2023 at 17:00
To: Elena Agostini <eagostini@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>, Levend Sayar <levendsayar@gmail.com>, Aaron Conole <aconole@redhat.com>, romein@astron.nl <romein@astron.nl>
Subject: Re: [PATCH] gpu/cuda: fix getenv related build error
External email: Use caution opening links or attachments


On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:
>
> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
> This causes gdrcopy.c build to give an error;
> because compiler can not find signature of getenv.
> stdlib.h is included for the definition of getenv function.
>

There was a bug report for this issue:
Bugzilla ID: 1133

> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")

It is probably worth backporting:
Cc: stable@dpdk.org

>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>

Elena, this is a quick one, review please.


--
David Marchand

[-- Attachment #2: Type: text/html, Size: 3697 bytes --]

Re: [PATCH] gpu/cuda: fix getenv related build error

[David Marchand]

On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:
>
> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
> This causes gdrcopy.c build to give an error;
> because compiler can not find signature of getenv.
> stdlib.h is included for the definition of getenv function.
>
> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>

Applied, thanks Levend.


-- 
David Marchand

Re: [PATCH] gpu/cuda: fix getenv related build error

[Levend Sayar]

My pleasure.
Thanks for ACKing Elena.
Thanks for applying David.

Best,
Levend

> On 6 Oct 2023, at 13:07, David Marchand <david.marchand@redhat.com> wrote:
> 
> On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:
>> 
>> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
>> This causes gdrcopy.c build to give an error;
>> because compiler can not find signature of getenv.
>> stdlib.h is included for the definition of getenv function.
>> 
>> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")
>> 
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> 
> Applied, thanks Levend.
> 
> 
> -- 
> David Marchand
>