From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ABB1A0613 for ; Tue, 24 Sep 2019 10:24:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 659C234F3; Tue, 24 Sep 2019 10:24:53 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 91F552BF2 for ; Tue, 24 Sep 2019 10:24:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 01:24:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,543,1559545200"; d="scan'208";a="203330820" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 24 Sep 2019 01:24:50 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 01:24:50 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 01:24:50 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.140]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 16:24:47 +0800 From: "Li, Xiaoyun" To: "Wu, Jingjing" , "Wiles, Keith" , "Maslekar, Omkar" , "Liang, Cunming" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 4/4] examples/ntb: support more functions for NTB Thread-Index: AQHVZr6ebMdBf1zSj0uimoA/bQugj6c4aq6AgAIqnBA= Date: Tue, 24 Sep 2019 08:24:46 +0000 Message-ID: References: <20190906075402.114177-1-xiaoyun.li@intel.com> <20190909032730.29718-1-xiaoyun.li@intel.com> <20190909032730.29718-5-xiaoyun.li@intel.com> <9BB6961774997848B5B42BEC655768F81151CD07@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F81151CD07@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/4] examples/ntb: support more functions for NTB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Wu, Jingjing > Sent: Monday, September 23, 2019 15:19 > To: Li, Xiaoyun ; Wiles, Keith ; > Maslekar, Omkar ; Liang, Cunming > > Cc: dev@dpdk.org > Subject: RE: [PATCH v4 4/4] examples/ntb: support more functions for NTB >=20 > <...> >=20 > > +* ``--qp=3DN`` > > + > > + Set the number of queues as N, where qp > 0. > The default value is 1? Yes. Will add missing info in doc. >=20 > <...> >=20 > > + > > + /* Set default fwd mode if user doesn't set it. */ > > + if (fwd_mode =3D=3D MAX_FWD_MODE && eth_port_id < > RTE_MAX_ETHPORTS) { > > + printf("Set default fwd mode as iofwd.\n"); > > + fwd_mode =3D IOFWD; > > + } > > + if (fwd_mode =3D=3D MAX_FWD_MODE) { >=20 > use "else if"? because (fwd_mode =3D=3D MAX_FWD_MODE) including (fwd_mode > =3D=3D MAX_FWD_MODE && eth_port_id < RTE_MAX_ETHPORTS) No. If it is that case, the fwd_mode will be set as IOFWD in the first if a= nd won't hit this one. >=20 > Thanks > Jingjing