From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3C2111B61C for ; Fri, 13 Oct 2017 09:30:22 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 13 Oct 2017 00:30:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,369,1503385200"; d="scan'208";a="160053468" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 13 Oct 2017 00:30:21 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 13 Oct 2017 00:30:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 13 Oct 2017 00:30:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 13 Oct 2017 15:30:18 +0800 From: "Li, Xiaoyun" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Richardson, Bruce" , "Lu, Wenzhuo" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v7 1/3] eal/x86: run-time dispatch over memcpy Thread-Index: AQHTPdZeGmi+IF3YRUSW4MVNnLsWHaLbS3MAgAW17WD//+S4AIAAiFSA Date: Fri, 13 Oct 2017 07:30:18 +0000 Message-ID: References: <1507157911-8702-1-git-send-email-xiaoyun.li@intel.com> <35071535.8NSjKInSoG@xps> <1709550.5v5ZG7JxHL@xps> In-Reply-To: <1709550.5v5ZG7JxHL@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 1/3] eal/x86: run-time dispatch over memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 07:30:23 -0000 OK. Would send new patchset later. Thanks! Best Regards Xiaoyun Li > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, October 13, 2017 15:22 > To: Li, Xiaoyun > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; Lu, Wenzhuo > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v7 1/3] eal/x86: run-time dispatch over > memcpy >=20 > 13/10/2017 03:06, Li, Xiaoyun: > > Hi > > Sorry for the late reply. I took AL last 3 days. > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 05/10/2017 14:33, Xiaoyun Li: > > > > +/** > > > > + * Macro for copying unaligned block from one location to another > > > > +with constant load offset, > > > > + * 47 bytes leftover maximum, > > > > + * locations should not overlap. > > > > + * Requirements: > > > > + * - Store is aligned > > > > + * - Load offset is , which must be immediate value > > > > +within [1, 15] > > > > + * - For , make sure bit backwards & <16 - offset> > > > > +bit forwards are available for loading > > > > + * - , , must be variables > > > > + * - __m128i ~ must be pre-defined */ #define > > > > +MOVEUNALIGNED_LEFT47_IMM(dst, src, len, > > > > > > Naive question: > > > Is there a real benefit of using a macro compared to a static inline > > > function optimized by a modern compiler? > > > > > The macro is in the existing DPDK codes. I didn't touch it. I just chan= ge the > file name and the function name to rte_memcpy_internal. > > So I am not clear about if there is real benefit. > > In my opinion, I think it is the same as static inline function. > > > > Do I need to change them to inline function? >=20 > In this patch, it appears as a new macro. > If you can, inline function is cleaner for the new one. >=20 > > > Anyway, if you are doing a new version, please reduce lines length > > > and fix the indent from spaces to tabs. > > > > > They are original DPDK codes so I didn't touch them. > > But in next version, I will fix them. >=20 > Just to be sure: we are talking about fixing checkpatch warnings only for= the > code added, changed or moved. >=20 > Thanks