From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B72AD25A1 for ; Tue, 3 Apr 2018 15:23:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 06:23:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,401,1517904000"; d="scan'208";a="30337574" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 03 Apr 2018 06:23:56 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 06:23:56 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.206]) by FMSMSX155.amr.corp.intel.com ([169.254.5.49]) with mapi id 14.03.0319.002; Tue, 3 Apr 2018 06:23:55 -0700 From: "Wiles, Keith" To: "Richardson, Bruce" CC: Thomas Monjalon , "Yigit, Ferruh" , "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: rename folder to library name Thread-Index: AQHTyy5DGnnEkuyNWESmg6SpMB9QAqPvStCAgAAJaYCAABcSAIAAA7wAgAAN+wA= Date: Tue, 3 Apr 2018 13:23:55 +0000 Message-ID: References: <20180403092859.71589-1-ferruh.yigit@intel.com> <8464158.iTavIsMWKz@xps> <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> <2713963.Nlhf7d0HAF@xps> <20180403123352.GA4152@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180403123352.GA4152@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.48.63] Content-Type: text/plain; charset="us-ascii" Content-ID: <70B48960AD91294CBE6F19F2CE9732FA@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 13:23:58 -0000 > On Apr 3, 2018, at 7:33 AM, Bruce Richardson = wrote: >=20 > On Tue, Apr 03, 2018 at 02:20:30PM +0200, Thomas Monjalon wrote: >> 03/04/2018 12:57, Bruce Richardson: >>> On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: >>>> 03/04/2018 11:28, Ferruh Yigit: >>>>> Library folder name and output library name are same except a few fla= ws >>>>> including librte_ether. >>>>>=20 >>>>> This library is network device abstraction layer, the name "ethdev" f= its >>>>> better than "ether", and library & header files already named as ethd= ev. >>>>>=20 >>>>> Also there is a rte_ether.h in the net library which can cause confus= ion. >>>>>=20 >>>>> Signed-off-by: Ferruh Yigit >>>>> --- >>>>> Not sure if the we are ready for this change J >>>>>=20 >>>>> This is one the issues that the hassle of the change doesn't worth th= e >>>>> benefit and you may prefer to live with the flaw. >>>>>=20 >>>>> Also a concern is this breaks the git history. >>>>=20 >>>> Yes it breaks the git history. >>>> I am a big user of gitk. Do you know how to follow the history after r= ename >>>> with gitk? >>>>=20 >>>> I think it is a good change but I would like to be sure it will not >>>> bother us every day. >>>>=20 >>> For those of use with even slight OCD, having it the way it is bothers = us >>> every day! :-) >>> I view this as something that we really should do some day - it's just >>> broken the way the way it is right now - and so the sooner we take the = hit >>> and fix it, the better. >>=20 >> Yes >>=20 >>> If you do need to find the history of the file, would git blame work we= ll >>> enough for you? >>=20 >> No, blame is not enough, but it does not matter. >>=20 >> When should we do this rename? 18.05-rc1? >>=20 > If we are going to do this rename, I don't see why we should wait. +1 make the change ASAP IMO. >=20 > /Bruce Regards, Keith