From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A66A51B6F2 for ; Wed, 9 May 2018 17:33:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 08:33:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,382,1520924400"; d="scan'208";a="198006050" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 09 May 2018 08:33:49 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 9 May 2018 08:33:49 -0700 Received: from cdsmsx151.ccr.corp.intel.com (172.17.4.38) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 9 May 2018 08:33:48 -0700 Received: from cdsmsx104.ccr.corp.intel.com ([169.254.4.183]) by CDSMSX151.ccr.corp.intel.com ([169.254.3.38]) with mapi id 14.03.0319.002; Wed, 9 May 2018 23:33:46 +0800 From: "Zhang, Tianfei" To: Thomas Monjalon , "Xu, Rosen" CC: "dev@dpdk.org" , "Zhang, Roy Fan" , "Doherty, Declan" , "Richardson, Bruce" , "shreyansh.jain@nxp.com" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "Liu, Song" , "Wu, Hao" , "gaetan.rivet@6wind.com" , "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver Thread-Index: AQHT52lEdncoERH5GkiZeAMr76RBfqQm9EqAgACSl9A= Date: Wed, 9 May 2018 15:33:45 +0000 Message-ID: References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1525851801-16101-1-git-send-email-rosen.xu@intel.com> <1525851801-16101-4-git-send-email-rosen.xu@intel.com> <2225742.ccNGmmKHOr@xps> In-Reply-To: <2225742.ccNGmmKHOr@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzcxNWE1NzItZTkyMi00NGM3LTljZGEtMWM4NzUyNzU5YzgyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKQ0pPbjFiRU03eSs0TCtLSmVsQlpYMFFqdk5XMUNVSWg0MWpJNFMxVFdqQUQzSzJESW9kbTc0Z09GNnBFVENiIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:33:52 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, May 9, 2018 10:47 PM > To: Xu, Rosen > Cc: dev@dpdk.org; Zhang, Roy Fan ; Doherty, > Declan ; Richardson, Bruce > ; shreyansh.jain@nxp.com; Yigit, Ferruh > ; Ananyev, Konstantin > ; Zhang, Tianfei ; > Liu, Song ; Wu, Hao ; > gaetan.rivet@6wind.com; Wu, Yanglong > Subject: Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev > Driver >=20 > 09/05/2018 09:43, Xu, Rosen: > > From: Rosen Xu > > > > Add Intel FPGA BUS Rawdev Driver which is based on librte_rawdev > > library. > > > > Signed-off-by: Rosen Xu > > Signed-off-by: Yanglong Wu > > Signed-off-by: Tianfei Zhang > > Acked-by: Shreyansh Jain >=20 > I have a compilation error: > drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c:10:15: error: > instruction requires: AVX-512 ISA >=20 > because of vmovdqu64: >=20 > #if defined(RTE_ARCH_X86_64) > static inline void copy512(const void *src, void *dst) { > asm volatile("vmovdqu64 (%0), %%zmm0;" > "vmovntdq %%zmm0, (%1);" > : > : "r"(src), "r"(dst)); > } > #else > static inline void copy512(const void *src, void *dst) { > UNUSED(src); > UNUSED(dst); > WARN_ON(1); > } > #endif >=20 > I suggest to fix it quickly without waiting a v11 with this: >=20 > static inline void copy512(const void *src, void *dst) { #ifdef > CC_SUPPORT_AVX512F > asm volatile("vmovdqu64 (%0), %%zmm0;" > "vmovntdq %%zmm0, (%1);" > : > : "r"(src), "r"(dst)); > #else > UNUSED(src); > UNUSED(dst); > WARN_ON(1); > #endif > } >=20 > It does not make any runtime detection, but it's better than previously. >=20 Which linux distribution are you use? We can compile it on Ubuntu 16.04 and= RHEL 7.4. We will fix it on V11.