From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 719374C74 for ; Wed, 10 Oct 2018 08:30:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 23:30:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,363,1534834800"; d="scan'208";a="264406668" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 09 Oct 2018 23:23:22 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Oct 2018 23:23:17 -0700 Received: from cdsmsx151.ccr.corp.intel.com (172.17.4.38) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Oct 2018 23:23:17 -0700 Received: from cdsmsx104.ccr.corp.intel.com ([169.254.4.156]) by CDSMSX151.ccr.corp.intel.com ([169.254.3.97]) with mapi id 14.03.0319.002; Wed, 10 Oct 2018 14:23:14 +0800 From: "Zhang, Tianfei" To: "Yigit, Ferruh" , "Pattan, Reshma" , Hemant Agrawal , Shreyansh Jain , Ashish Gupta , "Trahe, Fiona" , "De Lara Guarch, Pablo" , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , Jerin Jacob , Chas Williams , "Rahul Lakkireddy" , John Daley , Hyong Youb Kim , Gaetan Rivet , "Zhang, Qi Z" , "Wang, Xiao W" , "Xing, Beilei" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , Rasesh Mody , Harish Patil , "Shahed Shaikh" , Andrew Rybchenko , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Wiles, Keith" , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , Nipun Gupta , "Xu, Rosen" , "Burakov, Anatoly" , Thomas Monjalon , "Rao, Nikhil" , Olivier Matz CC: "dev@dpdk.org" Thread-Topic: [PATCH] fix static variables Thread-Index: AQHUW4vRMXXBlc/j7E2qm/F6RLLm5aUYCYIQ Date: Wed, 10 Oct 2018 06:23:14 +0000 Message-ID: References: <20181004034047.26824-1-ferruh.yigit@intel.com> In-Reply-To: <20181004034047.26824-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjUyOWQ2YzAtYTYzZi00N2U4LTlkZDEtYWY3NzIxNzk0NDFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJmQU1kYThFaWxZeFdkRTdnM2tHak16dVdkNGhFaXBwTUpcL2VnUTRUNXBpOVczWE1OamN2U2d6TUdBZDJrenA5MyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fix static variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 06:30:44 -0000 > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > index f0939dc32..848e5183a 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > @@ -104,14 +104,14 @@ static struct feature_info port_features[] =3D { > .resource_size =3D sizeof(struct feature_port_header), > .feature_index =3D PORT_FEATURE_ID_HEADER, > .revision_id =3D PORT_HEADER_REVISION, > - .ops =3D &port_hdr_ops, > + .ops =3D &ifpga_rawdev_port_hdr_ops, > }, > { > .name =3D PORT_FEATURE_ERR, > .resource_size =3D sizeof(struct feature_port_error), > .feature_index =3D PORT_FEATURE_ID_ERROR, > .revision_id =3D PORT_ERR_REVISION, > - .ops =3D &port_error_ops, > + .ops =3D &ifpga_rawdev_port_error_ops, > }, > { > .name =3D PORT_FEATURE_UMSG, > @@ -124,14 +124,14 @@ static struct feature_info port_features[] =3D { > .resource_size =3D sizeof(struct feature_port_uint), > .feature_index =3D PORT_FEATURE_ID_UINT, > .revision_id =3D PORT_UINT_REVISION, > - .ops =3D &port_uint_ops, > + .ops =3D &ifpga_rawdev_port_uint_ops, > }, > { > .name =3D PORT_FEATURE_STP, > .resource_size =3D PORT_FEATURE_STP_REGION_SIZE, > .feature_index =3D PORT_FEATURE_ID_STP, > .revision_id =3D PORT_STP_REVISION, > - .ops =3D &port_stp_ops, > + .ops =3D &ifpga_rawdev_port_stp_ops, > }, > { > .name =3D PORT_FEATURE_UAFU, > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h > b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h > index 7a39a580c..4391f2fdf 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h > @@ -156,10 +156,10 @@ struct fpga_uafu_irq_set { >=20 > int port_set_irq(struct ifpga_port_hw *port, u32 feature_id, void *irq_s= et); >=20 > -extern struct feature_ops port_hdr_ops; > -extern struct feature_ops port_error_ops; > -extern struct feature_ops port_stp_ops; > -extern struct feature_ops port_uint_ops; > +extern struct feature_ops ifpga_rawdev_port_hdr_ops; > +extern struct feature_ops ifpga_rawdev_port_error_ops; > +extern struct feature_ops ifpga_rawdev_port_stp_ops; > +extern struct feature_ops ifpga_rawdev_port_uint_ops; >=20 > /* help functions for feature ops */ > int fpga_msix_set_block(struct feature *feature, unsigned int start, > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_port.c > b/drivers/raw/ifpga_rawdev/base/ifpga_port.c > index a962f5b45..8b5668d49 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_port.c > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_port.c > @@ -326,7 +326,7 @@ static int port_hdr_set_prop(struct feature *feature, > struct feature_prop *prop) > return -ENOENT; > } >=20 > -struct feature_ops port_hdr_ops =3D { > +struct feature_ops ifpga_rawdev_port_hdr_ops =3D { > .init =3D port_hdr_init, > .uinit =3D port_hdr_uinit, > .get_prop =3D port_hdr_get_prop, > @@ -354,7 +354,7 @@ static void port_stp_uinit(struct feature *feature) > dev_info(NULL, "port stp uinit.\n"); > } >=20 > -struct feature_ops port_stp_ops =3D { > +struct feature_ops ifpga_rawdev_port_stp_ops =3D { > .init =3D port_stp_init, > .uinit =3D port_stp_uinit, > }; > @@ -382,7 +382,7 @@ static void port_uint_uinit(struct feature *feature) > dev_info(NULL, "PORT UINT UInit.\n"); > } >=20 > -struct feature_ops port_uint_ops =3D { > +struct feature_ops ifpga_rawdev_port_uint_ops =3D { > .init =3D port_uint_init, > .uinit =3D port_uint_uinit, > }; > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c > b/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c > index 23db562b8..9dd1cf590 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c > @@ -136,7 +136,7 @@ static int port_error_set_prop(struct feature > *feature, > return -ENOENT; > } >=20 > -struct feature_ops port_error_ops =3D { > +struct feature_ops ifpga_rawdev_port_error_ops =3D { > .init =3D port_error_init, > .uinit =3D port_error_uinit, > .get_prop =3D port_error_get_prop, This patch is the same as " [PATCH v2 2/4] drivers: prefix global variables= with module name ", I have acked at that patch.