From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AA6941B148 for ; Wed, 2 Jan 2019 03:47:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2019 18:47:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,429,1539673200"; d="scan'208";a="114771340" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 01 Jan 2019 18:47:47 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 18:47:46 -0800 Received: from cdsmsx152.ccr.corp.intel.com (172.17.4.41) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 18:47:46 -0800 Received: from cdsmsx104.ccr.corp.intel.com ([169.254.4.87]) by CDSMSX152.ccr.corp.intel.com ([169.254.6.74]) with mapi id 14.03.0415.000; Wed, 2 Jan 2019 10:47:44 +0800 From: "Zhang, Tianfei" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" Thread-Topic: [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga Thread-Index: AQHUnBjo5hZPtdO9DEKwVlsrpj7GtaWbUjfw Date: Wed, 2 Jan 2019 02:47:43 +0000 Message-ID: References: <1545161721-382282-1-git-send-email-andy.pei@intel.com> <1545746524-116580-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1545746524-116580-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDU2ZTdhZjItZWYxOC00Y2U1LWIwNWUtOGMyOGQyMTkzMjY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJlQVo4ZlVBNzlKTWRRSmxHYlRKMzk3K1wvYzZ4Z25QNUFZcjVlNURPRE1CYXNcL2UzN2pUeWpjelwvazhPSW00WXVQIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 02:47:49 -0000 > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, December 25, 2018 10:02 PM > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei > ; Pei, Andy > Subject: [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifp= ga >=20 > When ifpga_rawdev_create() allocate memory for a new rawdev, the > original code allocate redundant memory for adapter, which is a member of > the rawdev. > What is actually necessary is the adapter to be initialized, not memory > allocated. >=20 > What is different in v3 from v2 is that the adapter is no longer need to = be > freed. >=20 > fixes:ef1e8ede3da5 > cc: rosen.xu@intel.com > cc: tianfei.zhang@intel.com It looks good for me, Acked-by: Tianfei zhang