From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id 52DB011F5 for ; Sun, 28 Sep 2014 03:03:46 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s8S1AAWv026780 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sat, 27 Sep 2014 18:10:13 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0174.001; Sat, 27 Sep 2014 18:10:10 -0700 From: "Wiles, Roger Keith" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. Thread-Index: AQHP2oG/7+zUgDJSJ0eBA/ewM6tenJwWKQ2AgAAJLQA= Date: Sun, 28 Sep 2014 01:10:10 +0000 Message-ID: References: <20140928003719.GA27849@localhost.localdomain> In-Reply-To: <20140928003719.GA27849@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.166] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "" Subject: Re: [dpdk-dev] [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2014 01:03:46 -0000 OK, let me look at RTE_VERIFY then and will send a new patch. On Sep 27, 2014, at 7:37 PM, Neil Horman wrote: > On Sat, Sep 27, 2014 at 06:35:01PM +0000, Wiles, Roger Keith wrote: >>=20 >> Check the FILE *f and rte_mempool *mp pointers for NULL and >> return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. >>=20 >> Signed-off-by: Keith Wiles >> --- >> lib/librte_mempool/rte_mempool.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >>=20 >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_m= empool.c >> index 332f469..efa6a6c 100644 >> --- a/lib/librte_mempool/rte_mempool.c >> +++ b/lib/librte_mempool/rte_mempool.c >> @@ -765,6 +765,12 @@ rte_mempool_dump(FILE *f, const struct rte_mempool = *mp) >> unsigned common_count; >> unsigned cache_count; >>=20 >> + if ( (f =3D=3D NULL) || (mp =3D=3D NULL) ) { >> +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG >> + fprintf(stderr, "*** Called rte_mempool_dump(%p, %p) with NULL a= rgument\n", f, mp); >> +#endif /* RTE_LIBRTE_MEMPOOL_DEBUG */ >> + return; >> + } >> fprintf(f, "mempool <%s>@%p\n", mp->name, mp); >> fprintf(f, " flags=3D%x\n", mp->flags); >> fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); >> --=20 >> 2.1.0 >>=20 >>=20 > Maybe use RTE_VERIFY instead? > Neil >=20 Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533