From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 417A82BA6 for ; Fri, 4 Mar 2016 10:28:21 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 04 Mar 2016 01:28:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,535,1449561600"; d="scan'208";a="901145741" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga001.jf.intel.com with ESMTP; 04 Mar 2016 01:28:19 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.87]) by IRSMSX151.ger.corp.intel.com ([169.254.4.72]) with mapi id 14.03.0248.002; Fri, 4 Mar 2016 09:28:18 +0000 From: "Traynor, Kevin" To: Thomas Monjalon , "Wiles, Keith" Thread-Topic: [dpdk-dev] [PATCH] config: remove duplicate configuration information Thread-Index: AQHRbXiXULMLs1ol7EqOwTINACWOMp9IHIyAgABBYQA= Date: Fri, 4 Mar 2016 09:28:17 +0000 Message-ID: References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com> <121442835.2vdhmXQbJs@xps13> In-Reply-To: <121442835.2vdhmXQbJs@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNiZmI2ZmMtNzQ2OC00NTZhLWFjN2EtM2JjYzZmMDQ2Y2FmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im53XC9HVU1kcEE2TkRjREhjWTlXRUxcL3ZFM2VQYklTcCs0TXNoZU56dWlQYz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 09:28:21 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, March 3, 2016 6:38 PM > To: Wiles, Keith > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration > information >=20 > 2016-02-22 07:53, Keith Wiles: > > --- /dev/null > > +++ b/config/common_base > > +CONFIG_RTE_EAL_IGB_UIO=3Dy > > +CONFIG_RTE_EAL_VFIO=3Dy >=20 > These options should be disabled in the base file > and enabled in Linux. >=20 > > +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=3Dy >=20 > Idem, it should be disabled. >=20 > > +CONFIG_RTE_LIBRTE_POWER=3Dy >=20 > Idem? >=20 > > +CONFIG_RTE_LIBRTE_KNI=3Dy >=20 > Should be disabled. >=20 > > +CONFIG_RTE_LIBRTE_VHOST=3Dy >=20 > Should be disabled. Any reason this should be disabled? It was changed to =3DY in DPDK 2.1. It means updating scripts/build instructions to set =3DY for OVS, no big deal but it might catch people out.=20 Kevin. >=20 > > --- a/config/common_bsdapp > > +++ b/config/common_bsdapp > > +# Compile Environment Abstraction Layer for linux, FreeBSD, OS X, ... > > +CONFIG_RTE_LIBRTE_EAL_BSDAPP=3Dy >=20 > Please keep the original comment: > Compile Environment Abstraction Layer for BSD >=20 > > +# Compile Environment Abstraction Layer >=20 > Why this comment before disabling UIO and VFIO? >=20 > > --- a/config/common_linuxapp > > +++ b/config/common_linuxapp > > -## > > -## machine can define specific variables or action for a specific boar= d > > -## RTE_MACHINE values are the directories in mk/machine/ > > -## > > -#CONFIG_RTE_MACHINE=3D"native" > > -# > > -## > > -## define the architecture we compile for. > > -## RTE_ARCH values are the directories in mk/arch/ > > -## > > -#CONFIG_RTE_ARCH=3D"x86_64" > > -#CONFIG_RTE_ARCH_X86_64=3Dy > > -#CONFIG_RTE_ARCH_X86=3Dy > > -# > > -## > > -## The compiler we use. > > -## RTE_TOOLCHAIN values are the directories in mk/toolchain/ > > -## > > -#CONFIG_RTE_TOOLCHAIN=3D"gcc" > > -#CONFIG_RTE_TOOLCHAIN_GCC=3Dy >=20 > Maybe we should keep these comments in common_base? > I would remove the values and uncomment CONFIG_RTE_MACHINE, CONFIG_RTE_AR= CH > and CONFIG_RTE_TOOLCHAIN. >=20 > > --- a/config/defconfig_x86_64-native-bsdapp-clang > > +++ b/config/defconfig_x86_64-native-bsdapp-clang > > @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE=3D"native" > > CONFIG_RTE_ARCH=3D"x86_64" > > CONFIG_RTE_ARCH_X86_64=3Dy > > CONFIG_RTE_ARCH_X86=3Dy > > +CONFIG_RTE_ARCH_64=3Dy > > > > CONFIG_RTE_TOOLCHAIN=3D"clang" > > CONFIG_RTE_TOOLCHAIN_CLANG=3Dy > > diff --git a/config/defconfig_x86_64-native-bsdapp-gcc > b/config/defconfig_x86_64-native-bsdapp-gcc > > index 5a6a4e8..4ea4433 100644 > > --- a/config/defconfig_x86_64-native-bsdapp-gcc > > +++ b/config/defconfig_x86_64-native-bsdapp-gcc > > @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE=3D"native" > > CONFIG_RTE_ARCH=3D"x86_64" > > CONFIG_RTE_ARCH_X86_64=3Dy > > CONFIG_RTE_ARCH_X86=3Dy > > +CONFIG_RTE_ARCH_64=3Dy >=20 > It should be a totally separate patch. > And there are other places where it is missing.