From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DD73E5A57 for ; Sat, 26 Mar 2016 10:17:38 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 26 Mar 2016 02:17:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,395,1455004800"; d="scan'208";a="675901002" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 26 Mar 2016 02:17:37 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Sat, 26 Mar 2016 09:17:36 +0000 From: "Fischetti, Antonio" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v3] ixgbe: add check for tx queue number Thread-Index: AQHRheB/IzsXhPvL4kuJN1m9YFuX0J9rdHkA Date: Sat, 26 Mar 2016 09:17:35 +0000 Message-ID: References: <1458746929-87915-1-git-send-email-pablo.de.lara.guarch@intel.com> <1458832675-666-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1458832675-666-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTc2ZDkzNjMtNWEwOC00Nzk2LWIwMGQtZjZlNGVjMDEzZjFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitXWmZuXC9CSitDeXZMWFFqTmpqZHBZR1Mrc284SlwvT2dcL29WMURYNlhzSUE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] ixgbe: add check for tx queue number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2016 09:17:39 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, March 24, 2016 3:18 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v3] ixgbe: add check for tx queue number >=20 > From: Wenzhuo Lu >=20 > IXGBE supports 128 TX queues. However, the full 128 queues > are only available in VT and DCB mode. > In normal default "none" mode (VT/DCB off) the maximum number > of available queues is only 64 > (except for 82598EB, which is 32 for all modes). >=20 > IXGBE doesn't check the mode when reporting the available > number of queues. If a queue larger than 64 is used in default mode, > the TX packets will be dropped silently. >=20 > This change adds a check to forbid using a queue number larger than 64 > during device configuration (in default mode), so that the problem is > reported as early as possible. > It also changes the order of where the dev_conf parameters are copied > into the dev structure so that the correct maximum number of queues > is reported for the correct mode. >=20 > Signed-off-by: Wenzhuo Lu > Signed-off-by: Pablo de Lara Tested-by: Antonio Fischetti