From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information
Date: Wed, 24 Feb 2016 15:25:43 +0000 [thread overview]
Message-ID: <BD3AF078-7D4F-4E0F-ABE5-849FD619D26A@intel.com> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43588F7EB55@IRSMSX101.ger.corp.intel.com>
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Keith
>> Sent: Wednesday, February 24, 2016 1:58 PM
>> To: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
>> information
>>
>> >In order to cleanup the configuration files some and reduce the number
>> >of duplicate configuration information. Add a new file called
>> >common_base which contains just about all of the configuration lines in
>> >one place. Then have the common_bsdapp, common_linuxapp files include
>> >this one file. Then in those OS specific files add the delta
>> >configuration lines.
>> >
>> >Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>>
>> Ping, Does this patch have any more comments, do we want to use this patch?
>
>I'd prefer to leave as is, but don't feel strongly about it, I can work with either way.
>Fiona
What are your reasons for leaving it the same other then just keeping something you know now?
I do not see any downside and the upside is reducing having to change multiple files for a configuration add/remove or modify. Also as Panu stated it makes the changes for each OS and configuration much more obvious.
As Panu gave a +1 is that a Ack or how is this handled?
>
>
Regards,
Keith
next prev parent reply other threads:[~2016-02-24 15:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:53 Keith Wiles
2016-02-22 15:09 ` Trahe, Fiona
2016-02-22 16:02 ` Wiles, Keith
2016-02-22 16:44 ` Panu Matilainen
2016-02-24 13:58 ` Wiles, Keith
2016-02-24 14:19 ` Trahe, Fiona
2016-02-24 15:25 ` Wiles, Keith [this message]
2016-03-03 14:43 ` Wiles, Keith
2016-03-03 17:05 ` Thomas Monjalon
2016-03-03 18:37 ` Thomas Monjalon
2016-03-03 18:47 ` Wiles, Keith
2016-03-04 14:44 ` Wiles, Keith
2016-03-04 15:26 ` Thomas Monjalon
2016-03-04 9:28 ` Traynor, Kevin
2016-03-04 9:39 ` Panu Matilainen
2016-03-04 9:58 ` Traynor, Kevin
2016-03-04 10:28 ` Thomas Monjalon
2016-03-04 14:11 ` Wiles, Keith
2016-03-04 9:35 ` Panu Matilainen
2016-03-04 10:12 ` Panu Matilainen
2016-03-04 14:12 ` Wiles, Keith
2016-03-04 17:01 ` [dpdk-dev] [PATCH v2] " Keith Wiles
2016-03-04 17:26 ` Thomas Monjalon
2016-03-04 18:07 ` Wiles, Keith
2016-03-04 18:11 ` [dpdk-dev] [PATCH v3] " Keith Wiles
2016-03-04 22:43 ` Thomas Monjalon
2016-03-06 1:11 ` Ferruh Yigit
2016-03-06 1:21 ` [dpdk-dev] [PATCH] config: move Linux only config options from base to Linux config Ferruh Yigit
2016-03-06 9:35 ` [dpdk-dev] [PATCH v3] config: remove duplicate configuration information Thomas Monjalon
2016-03-07 12:41 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BD3AF078-7D4F-4E0F-ABE5-849FD619D26A@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).