From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yskoh@mellanox.com> Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30082.outbound.protection.outlook.com [40.107.3.82]) by dpdk.org (Postfix) with ESMTP id A8FF11B47E for <dev@dpdk.org>; Wed, 3 Apr 2019 20:07:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xuqCOIWUQPZCK0vrsLi+fmngcAsYrgdjAO0wp4LE7JE=; b=v4djfuKjF3rI+pOsOcRzsMwHt2q7S3HwO9iDlWUDzz8HYVfIVpgb+4UqVVEpY+Ec9EjY5uU+/dtCteEOFg9/oBkr38V8TZW0bAASwMsINmhR7or9vFLuEHJ7b+a7sdGVoMMqnwlsV9wIK5aBFsbpqJxSPeXXCtQl4QLE5djo0Zw= Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com (52.133.40.151) by AM0PR0502MB3747.eurprd05.prod.outlook.com (52.133.47.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Wed, 3 Apr 2019 18:07:46 +0000 Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::c99c:c488:62f8:103b]) by AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::c99c:c488:62f8:103b%4]) with mapi id 15.20.1750.017; Wed, 3 Apr 2019 18:07:46 +0000 From: Yongseok Koh <yskoh@mellanox.com> To: Ferruh Yigit <ferruh.yigit@intel.com> CC: Shahaf Shuler <shahafs@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators Thread-Index: AQHU6DJ28MCa4KkGhUqXimKEuqA6taYqgCSAgAA/vYA= Date: Wed, 3 Apr 2019 18:07:45 +0000 Message-ID: <BE3D930D-A196-4C8E-B947-027638E066B1@mellanox.com> References: <20181130002716.27325-1-thomas@monjalon.net> <20190401022700.1570-1-thomas@monjalon.net> <20190401022700.1570-4-thomas@monjalon.net> <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com> In-Reply-To: <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b207970c-75c8-4d7c-13e9-08d6b85f4650 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR0502MB3747; x-ms-traffictypediagnostic: AM0PR0502MB3747: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <AM0PR0502MB3747AE599A66A3219E057290C3570@AM0PR0502MB3747.eurprd05.prod.outlook.com> x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(396003)(376002)(346002)(199004)(189003)(66066001)(53936002)(4326008)(4744005)(186003)(478600001)(82746002)(33656002)(81156014)(6916009)(229853002)(76176011)(3846002)(93886005)(2616005)(476003)(11346002)(486006)(14454004)(446003)(6486002)(68736007)(6436002)(53546011)(102836004)(5660300002)(6116002)(6246003)(2906002)(83716004)(26005)(105586002)(99286004)(25786009)(8936002)(6506007)(36756003)(106356001)(6512007)(71200400001)(256004)(8676002)(305945005)(81166006)(71190400001)(86362001)(54906003)(316002)(97736004)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3747; H:AM0PR0502MB3971.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NZfngoS0g/feHuNW+axDh61OIKbaUZXv/t+2xAqi3vQILBVjy6yEFQYD52KNodw+B8iMADdVgSGDEwV0rol2LlhL2U+V/nlVUoiqNESOnqMWvcLtSu356qKTXirhZZmrz3sZgch9mCmSTPPDHW/qXF1dXk37D5OipMQVS40w5cRluVZhO8oASNRrSjdd7efTjkfiCuegBZRHZgayIkDXqM+3h1LD35fdf6wxRm1DdgSxgyDtSz9LCkrW9nuUOYr/4i674X2kGFOCco4WxeQbyc7zQobjTep55jXXyy1dT1X0W6xljK8XH9yfpEbRfhTt+6ILuWs0N++DK6fiCpRPuTFw35T8I5LL1vyNLkwmCcj711Z6eputpVjO4JkvsddcpCBny6mWEGXLbsspB2Mgd6cDkpxFFWTQI2DMDTCmrfw= Content-Type: text/plain; charset="us-ascii" Content-ID: <9FBC9CC7FC39724BBCD35898F3B2C05A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b207970c-75c8-4d7c-13e9-08d6b85f4650 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 18:07:45.8729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3747 Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 03 Apr 2019 18:07:47 -0000 > On Apr 3, 2019, at 7:19 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote: >=20 > On 4/1/2019 3:26 AM, Thomas Monjalon wrote: >> Iterating over siblings was done with RTE_ETH_FOREACH_DEV() >> which skips the owned ports. >> The new iterators RTE_ETH_FOREACH_DEV_SIBLING() >> and RTE_ETH_FOREACH_DEV_OF() are more appropriate and more correct. >>=20 >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> >=20 > Hi Shahaf, Yongseok, >=20 > Any comment on this patch? Sorry for late reply. I know it has been merged but it looks okay to me. Thanks, Yongseok From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 64C06A0679 for <public@inbox.dpdk.org>; Wed, 3 Apr 2019 20:07:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D3891B4E7; Wed, 3 Apr 2019 20:07:48 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30082.outbound.protection.outlook.com [40.107.3.82]) by dpdk.org (Postfix) with ESMTP id A8FF11B47E for <dev@dpdk.org>; Wed, 3 Apr 2019 20:07:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xuqCOIWUQPZCK0vrsLi+fmngcAsYrgdjAO0wp4LE7JE=; b=v4djfuKjF3rI+pOsOcRzsMwHt2q7S3HwO9iDlWUDzz8HYVfIVpgb+4UqVVEpY+Ec9EjY5uU+/dtCteEOFg9/oBkr38V8TZW0bAASwMsINmhR7or9vFLuEHJ7b+a7sdGVoMMqnwlsV9wIK5aBFsbpqJxSPeXXCtQl4QLE5djo0Zw= Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com (52.133.40.151) by AM0PR0502MB3747.eurprd05.prod.outlook.com (52.133.47.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Wed, 3 Apr 2019 18:07:46 +0000 Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::c99c:c488:62f8:103b]) by AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::c99c:c488:62f8:103b%4]) with mapi id 15.20.1750.017; Wed, 3 Apr 2019 18:07:46 +0000 From: Yongseok Koh <yskoh@mellanox.com> To: Ferruh Yigit <ferruh.yigit@intel.com> CC: Shahaf Shuler <shahafs@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators Thread-Index: AQHU6DJ28MCa4KkGhUqXimKEuqA6taYqgCSAgAA/vYA= Date: Wed, 3 Apr 2019 18:07:45 +0000 Message-ID: <BE3D930D-A196-4C8E-B947-027638E066B1@mellanox.com> References: <20181130002716.27325-1-thomas@monjalon.net> <20190401022700.1570-1-thomas@monjalon.net> <20190401022700.1570-4-thomas@monjalon.net> <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com> In-Reply-To: <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b207970c-75c8-4d7c-13e9-08d6b85f4650 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR0502MB3747; x-ms-traffictypediagnostic: AM0PR0502MB3747: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <AM0PR0502MB3747AE599A66A3219E057290C3570@AM0PR0502MB3747.eurprd05.prod.outlook.com> x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(396003)(376002)(346002)(199004)(189003)(66066001)(53936002)(4326008)(4744005)(186003)(478600001)(82746002)(33656002)(81156014)(6916009)(229853002)(76176011)(3846002)(93886005)(2616005)(476003)(11346002)(486006)(14454004)(446003)(6486002)(68736007)(6436002)(53546011)(102836004)(5660300002)(6116002)(6246003)(2906002)(83716004)(26005)(105586002)(99286004)(25786009)(8936002)(6506007)(36756003)(106356001)(6512007)(71200400001)(256004)(8676002)(305945005)(81166006)(71190400001)(86362001)(54906003)(316002)(97736004)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3747; H:AM0PR0502MB3971.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NZfngoS0g/feHuNW+axDh61OIKbaUZXv/t+2xAqi3vQILBVjy6yEFQYD52KNodw+B8iMADdVgSGDEwV0rol2LlhL2U+V/nlVUoiqNESOnqMWvcLtSu356qKTXirhZZmrz3sZgch9mCmSTPPDHW/qXF1dXk37D5OipMQVS40w5cRluVZhO8oASNRrSjdd7efTjkfiCuegBZRHZgayIkDXqM+3h1LD35fdf6wxRm1DdgSxgyDtSz9LCkrW9nuUOYr/4i674X2kGFOCco4WxeQbyc7zQobjTep55jXXyy1dT1X0W6xljK8XH9yfpEbRfhTt+6ILuWs0N++DK6fiCpRPuTFw35T8I5LL1vyNLkwmCcj711Z6eputpVjO4JkvsddcpCBny6mWEGXLbsspB2Mgd6cDkpxFFWTQI2DMDTCmrfw= Content-Type: text/plain; charset="UTF-8" Content-ID: <9FBC9CC7FC39724BBCD35898F3B2C05A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b207970c-75c8-4d7c-13e9-08d6b85f4650 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 18:07:45.8729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3747 Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190403180745.Uf6JOdQFttaI-JFlpQervcU753j-emed16ZxlN4VZB4@z> > On Apr 3, 2019, at 7:19 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote: >=20 > On 4/1/2019 3:26 AM, Thomas Monjalon wrote: >> Iterating over siblings was done with RTE_ETH_FOREACH_DEV() >> which skips the owned ports. >> The new iterators RTE_ETH_FOREACH_DEV_SIBLING() >> and RTE_ETH_FOREACH_DEV_OF() are more appropriate and more correct. >>=20 >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> >=20 > Hi Shahaf, Yongseok, >=20 > Any comment on this patch? Sorry for late reply. I know it has been merged but it looks okay to me. Thanks, Yongseok