From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 457895F29 for ; Wed, 7 Mar 2018 20:41:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 11:41:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,437,1515484800"; d="scan'208";a="209678035" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 07 Mar 2018 11:41:44 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Mar 2018 11:41:44 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.147]) by FMSMSX153.amr.corp.intel.com ([169.254.9.82]) with mapi id 14.03.0319.002; Wed, 7 Mar 2018 11:41:44 -0800 From: "Carrillo, Erik G" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 06/10] event/octeontx: add single producer timer arm variant Thread-Index: AQHTp25mSTOLvqPNT0637raEDxhZbaPFR7Kw Date: Wed, 7 Mar 2018 19:41:44 +0000 Message-ID: References: <20180216213700.3415-1-pbhagavatula@caviumnetworks.com> <20180216213700.3415-7-pbhagavatula@caviumnetworks.com> In-Reply-To: <20180216213700.3415-7-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWY1ZmE5OTQtZGI1Yy00ZDYwLWFjMmUtYjczZmE3NTYwNTY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJyNUxYNmNuWEJJQUFmVG9sYVNVWCttXC9Wclpnemx2cGgzcm5GUGdiTFhwRDhGNmQwSzBBeFJ0cEIxY3BFSUpHbCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 06/10] event/octeontx: add single producer timer arm variant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 19:41:47 -0000 Hi Pavan, <... snipped ...> > @@ -261,8 +267,12 @@ timvf_ring_create(struct rte_event_timer_adapter > *adptr) > timvf_write64(0x7, (uint8_t *)timr->vbar0 + > TIM_VF_NRSPERR_ENA_W1C); > timvf_write64(0x7, (uint8_t *)timr->vbar0 + > TIM_VF_NRSPERR_ENA_W1S); >=20 > - adptr->arm_burst =3D timvf_timer_reg_burst_mp; > - adptr->arm_tmo_tick_burst =3D NULL; > + if (mp_flags) > + adptr->arm_burst =3D timvf_timer_reg_burst_sp; > + else > + adptr->arm_burst =3D timvf_timer_reg_burst_mp; > + > + adptr->arm_tmo_tick_burst =3D timvf_timer_reg_brst; > adptr->cancel_burst =3D timvf_timer_unreg_burst; >=20 > return 0; The values assigned here to adptr->(arm_burst|arm_tmo_tick_burst|cancel_bur= st) would get overwritten by the caller with the values that are set immedi= ately below. I.e., the below should be sufficient by itself. > @@ -297,11 +307,13 @@ timvf_timer_adapter_caps_get(const struct > rte_eventdev *dev, uint64_t flags, > uint32_t *caps, const struct rte_event_timer_adapter_ops > **ops) { > RTE_SET_USED(dev); > - RTE_SET_USED(flags); >=20 > - timvf_ops.arm_burst =3D timvf_timer_reg_burst_mp; > - timvf_ops.arm_tmo_tick_burst =3D NULL; > + if (flags & RTE_EVENT_TIMER_ADAPTER_F_SP_PUT) > + timvf_ops.arm_burst =3D timvf_timer_reg_burst_sp; > + else > + timvf_ops.arm_burst =3D timvf_timer_reg_burst_mp; >=20 > + timvf_ops.arm_tmo_tick_burst =3D timvf_timer_reg_brst; > timvf_ops.cancel_burst =3D timvf_timer_unreg_burst; > *caps =3D RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT; > *ops =3D &timvf_ops; > diff --git a/drivers/event/octeontx/timvf_evdev.h > b/drivers/event/octeontx/timvf_evdev.h > index c80e147e8..b5db233bb 100644 > --- a/drivers/event/octeontx/timvf_evdev.h > +++ b/drivers/event/octeontx/timvf_evdev.h > @@ -186,8 +186,13 @@ bkt_mod(uint32_t rel_bkt, uint32_t nb_bkts) <... snipped ...> Regards, Gabriel