From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E9A881B74D for ; Tue, 3 Apr 2018 16:09:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 07:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,401,1517904000"; d="scan'208";a="43031060" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 03 Apr 2018 07:09:23 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 07:09:23 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.26]) by fmsmsx122.amr.corp.intel.com ([169.254.5.137]) with mapi id 14.03.0319.002; Tue, 3 Apr 2018 07:09:23 -0700 From: "Carrillo, Erik G" To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [PATCH v9 0/9] eventtimer: introduce event timer adapter Thread-Index: AQHTytkktHAqfbgO7Ui3SvbgxqQZRKPvE/qg Date: Tue, 3 Apr 2018 14:09:22 +0000 Message-ID: References: <1522358852-3630-1-git-send-email-erik.g.carrillo@intel.com> <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com> <20180402231906.GA31895@jerin> In-Reply-To: <20180402231906.GA31895@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2IyMzRkNDMtMjBkOS00ZTdlLWEzNjYtZTk4ZjQ2Nzg2ZGRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJhRzl6cW1MQmNuSVlJOG5zOUJxeHpERkQxcXpxWDh4VDNQRGdzY1dtZ3NpVjBjeHlJMHlBV0h6c1gxNWJlS0xLIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 14:09:26 -0000 Hi Jerin, Question in-line: > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, April 2, 2018 6:19 PM > To: Carrillo, Erik G > Cc: pbhagavatula@caviumnetworks.com; dev@dpdk.org; > hemant.agrawal@nxp.com > Subject: Re: [PATCH v9 0/9] eventtimer: introduce event timer adapter >=20 > -----Original Message----- > > Date: Mon, 2 Apr 2018 14:39:45 -0500 > > From: Erik Gabriel Carrillo > > To: pbhagavatula@caviumnetworks.com > > CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, > > hemant.agrawal@nxp.com > > Subject: [PATCH v9 0/9] eventtimer: introduce event timer adapter > > X-Mailer: git-send-email 1.7.10 > > > > This patch series contains the next iteration of the Event Timer > > Adapter library, which abstracts timer mechanisms that are tightly > > coupled with event devices, and extends the event based programming > > model so that timer expirations are represented as an event. > > > > v9 > > - Addressed comments on previous series from Pavan: > > - Don't assume services exist in HW cases > > - Adjust retry logic in a couple of tests > > - Addressed comments on previous series from Jerin: > > - Fix build warning > > - Addressed comments on previous series from Hemant: > > - Adjust copyright text >=20 > 1) Please fix following check-patch warnings: >=20 > ### eventtimer: introduce event timer adapter >=20 > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" > #273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238: > +struct rte_event_timer_adapter * __rte_experimental >=20 > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" > #303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268: > +struct rte_event_timer_adapter * __rte_experimenta >=20 =20 I was aware that checkpatch was complaining here, but the style I used is=20 consistent with almost all the existing DPDK code that uses the __rte_exper= imental tag. Should I fix the warning if the style will differ from existing code? Thanks, Gabriel