DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: 'Pavan Nikhilesh' <pbhagavatula@caviumnetworks.com>,
	"'jerin.jacob@caviumnetworks.com'"
	<jerin.jacob@caviumnetworks.com>,
	"'santosh.shukla@caviumnetworks.com'"
	<santosh.shukla@caviumnetworks.com>
Cc: "'dev@dpdk.org'" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] app/eventdev: add event timer adapter as a producer
Date: Wed, 4 Apr 2018 21:20:23 +0000	[thread overview]
Message-ID: <BE54F058557D9A4FAC1D84E2FC6D87570EE0CFAA@fmsmsx115.amr.corp.intel.com> (raw)
In-Reply-To: <BE54F058557D9A4FAC1D84E2FC6D87570EE0C22B@fmsmsx115.amr.corp.intel.com>

> -----Original Message-----
> From: Carrillo, Erik G
> Sent: Tuesday, April 3, 2018 3:21 PM
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>;
> jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 1/4] app/eventdev: add event timer
> adapter as a producer
> 
> Hi Pavan,
> 
> One comment in-line:
> 
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Tuesday, April 3, 2018 11:02 AM
> > To: jerin.jacob@caviumnetworks.com;
> > santosh.shukla@caviumnetworks.com; Carrillo, Erik G
> > <erik.g.carrillo@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh
> <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v2 1/4] app/eventdev: add event timer
> > adapter as a producer
> >
> > Add event timer adapter as producer option that can be selected by
> > passing - -prod_type_timerdev.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> 
> <...snipped...>
> 
> > diff --git a/app/test-eventdev/evt_options.h b/app/test-
> > eventdev/evt_options.h index 46d122229..37debae84 100644
> > --- a/app/test-eventdev/evt_options.h
> > +++ b/app/test-eventdev/evt_options.h
> > @@ -31,12 +31,14 @@
> >  #define EVT_FWD_LATENCY          ("fwd_latency")
> >  #define EVT_QUEUE_PRIORITY       ("queue_priority")
> >  #define EVT_PROD_ETHDEV          ("prod_type_ethdev")
> > +#define EVT_PROD_TIMERDEV        ("prod_type_timerdev")
> >  #define EVT_HELP                 ("help")
> >
> >  enum evt_prod_type {
> >  	EVT_PROD_TYPE_NONE,
> >  	EVT_PROD_TYPE_SYNT,          /* Producer type Synthetic i.e. CPU. */
> >  	EVT_PROD_TYPE_ETH_RX_ADPTR,  /* Producer type Eth Rx Adapter.
> > */
> > +	EVT_PROD_TYPE_EVENT_TIMER_ADPTR,  /* Producer type Eth Rx
> > Adapter. */
> 
> Comment didn't get updated here.
> 

With that edit:

Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

  reply	other threads:[~2018-04-04 21:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-18 13:12 [dpdk-dev] [PATCH " Pavan Nikhilesh
2018-03-18 13:12 ` [dpdk-dev] [PATCH 2/4] app/eventdev: add burst mode for event timer adapter Pavan Nikhilesh
2018-03-30 19:54   ` Carrillo, Erik G
2018-03-18 13:12 ` [dpdk-dev] [PATCH 3/4] app/eventdev: add options to configure " Pavan Nikhilesh
2018-03-18 13:12 ` [dpdk-dev] [PATCH 4/4] doc: update test eventdev documentation Pavan Nikhilesh
2018-03-30 19:50 ` [dpdk-dev] [PATCH 1/4] app/eventdev: add event timer adapter as a producer Carrillo, Erik G
2018-04-03 16:01 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-04-03 16:01   ` [dpdk-dev] [PATCH v2 2/4] app/eventdev: add burst mode for event timer adapter Pavan Nikhilesh
2018-04-04 21:07     ` Carrillo, Erik G
2018-04-03 16:01   ` [dpdk-dev] [PATCH v2 3/4] app/eventdev: add options to configure " Pavan Nikhilesh
2018-04-04 21:10     ` Carrillo, Erik G
2018-04-03 16:01   ` [dpdk-dev] [PATCH v2 4/4] doc: update test eventdev documentation Pavan Nikhilesh
2018-04-04 21:16     ` Carrillo, Erik G
2018-04-03 20:21   ` [dpdk-dev] [PATCH v2 1/4] app/eventdev: add event timer adapter as a producer Carrillo, Erik G
2018-04-04 21:20     ` Carrillo, Erik G [this message]
2018-04-05 11:53 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-04-05 11:53   ` [dpdk-dev] [PATCH v3 2/4] app/eventdev: add burst mode for event timer adapter Pavan Nikhilesh
2018-04-06 11:11     ` Jerin Jacob
2018-04-05 11:53   ` [dpdk-dev] [PATCH v3 3/4] app/eventdev: add options to configure " Pavan Nikhilesh
2018-04-06 11:15     ` Jerin Jacob
2018-04-05 11:53   ` [dpdk-dev] [PATCH v3 4/4] doc: update test eventdev documentation Pavan Nikhilesh
2018-04-06 11:37     ` Jerin Jacob
2018-04-06 11:07   ` [dpdk-dev] [PATCH v3 1/4] app/eventdev: add event timer adapter as a producer Jerin Jacob
2018-04-06 11:18   ` Jerin Jacob
2018-04-06 14:55 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-04-06 14:55   ` [dpdk-dev] [PATCH v4 2/4] app/eventdev: add burst mode for event timer adapter Pavan Nikhilesh
2018-04-06 14:55   ` [dpdk-dev] [PATCH v4 3/4] app/eventdev: add options to configure " Pavan Nikhilesh
2018-04-06 14:55   ` [dpdk-dev] [PATCH v4 4/4] doc: update test eventdev documentation Pavan Nikhilesh
2018-04-06 15:13 ` [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer Pavan Nikhilesh
2018-04-06 15:13   ` [dpdk-dev] [PATCH v5 2/4] app/eventdev: add burst mode for event timer adapter Pavan Nikhilesh
2018-04-06 15:13   ` [dpdk-dev] [PATCH v5 3/4] app/eventdev: add options to configure " Pavan Nikhilesh
2018-04-06 15:13   ` [dpdk-dev] [PATCH v5 4/4] doc: update test eventdev documentation Pavan Nikhilesh
2018-04-07  9:34   ` [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer Jerin Jacob
2018-04-17  8:18   ` Maxime Coquelin
2018-04-17  8:22     ` Pavan Nikhilesh
2018-04-17  8:24       ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE54F058557D9A4FAC1D84E2FC6D87570EE0CFAA@fmsmsx115.amr.corp.intel.com \
    --to=erik.g.carrillo@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).