From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E1A25160 for ; Wed, 9 May 2018 17:22:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 08:22:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,382,1520924400"; d="scan'208";a="38621508" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 09 May 2018 08:22:16 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 9 May 2018 08:22:16 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.80]) by FMSMSX125.amr.corp.intel.com ([169.254.2.186]) with mapi id 14.03.0319.002; Wed, 9 May 2018 08:22:15 -0700 From: "Carrillo, Erik G" To: "Van Haaren, Harry" CC: "jerin.jacob@caviumnetworks.com" , "Vangati, Narender" , "Eads, Gage" , "dev@dpdk.org" Thread-Topic: [PATCH v1 1/1] service: Add service lcore attr APIs Thread-Index: AQHT56kTR676tp0GtUmdCPbbIhLpZ6QngzOw Date: Wed, 9 May 2018 15:22:15 +0000 Message-ID: References: <1525464964-5342-1-git-send-email-erik.g.carrillo@intel.com> <1525464964-5342-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGU4Y2RlNTUtZmFiZi00OTc1LWJhOGMtYjczZDg4Zjk1Y2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJpTWRYV1RacGtCNmpOUG1ZRmVXWWxuTGp4aENyTW5nY0pEbE40K2dYT0djbzVRZjhwS3dUUGZpdnVJbXNlbVZzIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:22:18 -0000 > -----Original Message----- > From: Van Haaren, Harry > Sent: Wednesday, May 9, 2018 10:19 AM > To: Carrillo, Erik G > Cc: jerin.jacob@caviumnetworks.com; Vangati, Narender > ; Eads, Gage ; > dev@dpdk.org > Subject: RE: [PATCH v1 1/1] service: Add service lcore attr APIs >=20 > > -----Original Message----- > > From: Carrillo, Erik G > > Sent: Friday, May 4, 2018 9:16 PM > > To: Van Haaren, Harry > > Cc: jerin.jacob@caviumnetworks.com; Vangati, Narender > > ; Eads, Gage ; > > dev@dpdk.org > > Subject: [PATCH v1 1/1] service: Add service lcore attr APIs > > > > Add a counter that gets bumped each time the service runner loop goes > > around, and APIs to query and reset the attribute values. > > > > Signed-off-by: Erik Gabriel Carrillo >=20 > From cover letter for this patch: >=20 > This patch proposes the addition of an API which allows an application to > query the attributes of a service lcore. It adds one such new attribute, > named "loops", which is a counter that tracks the number of times the > service core has looped in the service runner function (the driver functi= on > that invokes services mapped to a service core). This is useful to appli= cations > that desire a "liveness" check to make sure a service core is not stuck. >=20 >=20 > When sending a single patch it is not required to send with --cover-lette= r. >=20 > I like the description provided in the cover letter, perhaps merge the cu= rrent > commit message with the cover-letter paragraph? >=20 > For the v2, please include >=20 > Acked-by: Harry van Haaren >=20 Thanks for the review, Harry. I'll make the changes and resubmit.