From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A42C91041 for ; Fri, 26 Apr 2019 20:58:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 11:58:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="152663782" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2019 11:58:31 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 26 Apr 2019 11:58:31 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.68]) by fmsmsx162.amr.corp.intel.com ([169.254.5.66]) with mapi id 14.03.0415.000; Fri, 26 Apr 2019 11:58:30 -0700 From: "Carrillo, Erik G" To: Honnappa Nagarahalli , "jerin.jacob@caviumnetworks.com" CC: "mattias.ronnblom@ericsson.com" , "pbhagavatula@caviumnetworks.com" , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter Thread-Index: AQHU/EL0gl0BtF9dIUm6GvchIfjk0qZPPtOA//+LSUA= Date: Fri, 26 Apr 2019 18:58:30 +0000 Message-ID: References: <1555945059-14808-1-git-send-email-erik.g.carrillo@intel.com> <1556291660-12373-1-git-send-email-erik.g.carrillo@intel.com> <1556291660-12373-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDA3MzkzYTktZGUwMi00MGEwLTllZTQtYzVkMTgwMjI5OTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicHpuZFYyVFdDSnJXRWZsUlcyWWlcL2ZWTnZKdE4xY2IweEF4Y1JWOE9ndzFFekx4UDArQXlUcWJDMGtjOGY5U3gifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 18:58:33 -0000 > -----Original Message----- > From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] > Sent: Friday, April 26, 2019 1:51 PM > To: Carrillo, Erik G ; > jerin.jacob@caviumnetworks.com > Cc: mattias.ronnblom@ericsson.com; pbhagavatula@caviumnetworks.com; > dev@dpdk.org; Honnappa Nagarahalli ; > nd ; nd > Subject: RE: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event > timer adapter >=20 > Hi Erik, > A quick question. >=20 > > -----Original Message----- > > From: dev On Behalf Of Erik Gabriel Carrillo > > Sent: Friday, April 26, 2019 10:14 AM > > To: jerin.jacob@caviumnetworks.com > > Cc: mattias.ronnblom@ericsson.com; > pbhagavatula@caviumnetworks.com; > > dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event > > timer adapter > > > > This patch introduces a new version of the event timer adapter software > PMD. > > In the original design, timer event producer lcores in the primary and > > secondary processes enqueued event timers into a ring, and a service > > core in the primary process dequeued them and processed them further. > > To improve performance, this version does away with the ring and lets > > lcores in both primary and secondary processes insert timers directly > > into timer skiplist data structures; the service core directly > > accesses the lists as well, when looking for timers that have expired. > How do you ensure concurrent access to the timer skiplist? Are you using = any > locks or is it a lock-free data structure? >=20 > There are multiple timer skiplists, one for each lcore, and each has its l= ock that is acquired as necessary when adding or removing timers from the s= kiplists. This locking occurs in the underlying timer library, in the time= r reset and stop functions. Regards, Erik From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 81B73A05D3 for ; Fri, 26 Apr 2019 20:58:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 082542B9C; Fri, 26 Apr 2019 20:58:34 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A42C91041 for ; Fri, 26 Apr 2019 20:58:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 11:58:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="152663782" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2019 11:58:31 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 26 Apr 2019 11:58:31 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.68]) by fmsmsx162.amr.corp.intel.com ([169.254.5.66]) with mapi id 14.03.0415.000; Fri, 26 Apr 2019 11:58:30 -0700 From: "Carrillo, Erik G" To: Honnappa Nagarahalli , "jerin.jacob@caviumnetworks.com" CC: "mattias.ronnblom@ericsson.com" , "pbhagavatula@caviumnetworks.com" , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter Thread-Index: AQHU/EL0gl0BtF9dIUm6GvchIfjk0qZPPtOA//+LSUA= Date: Fri, 26 Apr 2019 18:58:30 +0000 Message-ID: References: <1555945059-14808-1-git-send-email-erik.g.carrillo@intel.com> <1556291660-12373-1-git-send-email-erik.g.carrillo@intel.com> <1556291660-12373-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDA3MzkzYTktZGUwMi00MGEwLTllZTQtYzVkMTgwMjI5OTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicHpuZFYyVFdDSnJXRWZsUlcyWWlcL2ZWTnZKdE4xY2IweEF4Y1JWOE9ndzFFekx4UDArQXlUcWJDMGtjOGY5U3gifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190426185830.SxriU1oOmb5DEkQrnyRx-czJONDJIrMRBzVYhP2boI0@z> > -----Original Message----- > From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] > Sent: Friday, April 26, 2019 1:51 PM > To: Carrillo, Erik G ; > jerin.jacob@caviumnetworks.com > Cc: mattias.ronnblom@ericsson.com; pbhagavatula@caviumnetworks.com; > dev@dpdk.org; Honnappa Nagarahalli ; > nd ; nd > Subject: RE: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event > timer adapter >=20 > Hi Erik, > A quick question. >=20 > > -----Original Message----- > > From: dev On Behalf Of Erik Gabriel Carrillo > > Sent: Friday, April 26, 2019 10:14 AM > > To: jerin.jacob@caviumnetworks.com > > Cc: mattias.ronnblom@ericsson.com; > pbhagavatula@caviumnetworks.com; > > dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v6 1/1] eventdev: add new software event > > timer adapter > > > > This patch introduces a new version of the event timer adapter software > PMD. > > In the original design, timer event producer lcores in the primary and > > secondary processes enqueued event timers into a ring, and a service > > core in the primary process dequeued them and processed them further. > > To improve performance, this version does away with the ring and lets > > lcores in both primary and secondary processes insert timers directly > > into timer skiplist data structures; the service core directly > > accesses the lists as well, when looking for timers that have expired. > How do you ensure concurrent access to the timer skiplist? Are you using = any > locks or is it a lock-free data structure? >=20 > There are multiple timer skiplists, one for each lcore, and each has its l= ock that is acquired as necessary when adding or removing timers from the s= kiplists. This locking occurs in the underlying timer library, in the time= r reset and stop functions. Regards, Erik