DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"rsanford@akamai.com" <rsanford@akamai.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary
Date: Thu, 9 May 2019 20:08:47 +0000	[thread overview]
Message-ID: <BE54F058557D9A4FAC1D84E2FC6D875723407ADF@fmsmsx115.amr.corp.intel.com> (raw)
In-Reply-To: <7268235.EfLeTirqVG@xps>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, May 9, 2019 2:52 PM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; rsanford@akamai.com;
> dev@dpdk.org
> Subject: Re: [PATCH v2] timer: allow first subsystem init from secondary
> 
> 09/05/2019 21:39, Erik Gabriel Carrillo:
> > Since memzones can be reserved from secondary processes as well as
> > primary processes, if the first call to the timer subsystem init
> > function occurs in a secondary process, we should allow it to succeed.
> >
> > Fixes: c0749f7096c7 ("timer: allow management in shared memory")
> >
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> 
> I think this patch is too big for -rc4.
> And it doesn't look so critical.
> Do you agree to wait 19.08?
> 

The very last hunk of the patch should at least be applied, as it fixes an issue in the finalize() function.  The rest of it is just to make sure the behavior is the same as the prior release with respect to the secondary.

I'd prefer if the whole patch was applied, but I can break out the last hunk for a very small patch if that's what you think we should do.

Regards,
Erik


  parent reply	other threads:[~2019-05-09 20:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 22:17 [dpdk-dev] [PATCH] " Erik Gabriel Carrillo
2019-05-08 22:17 ` Erik Gabriel Carrillo
2019-05-09 11:44 ` Burakov, Anatoly
2019-05-09 11:44   ` Burakov, Anatoly
2019-05-09 19:47   ` Carrillo, Erik G
2019-05-09 19:47     ` Carrillo, Erik G
2019-05-09 19:39 ` [dpdk-dev] [PATCH v2] " Erik Gabriel Carrillo
2019-05-09 19:39   ` Erik Gabriel Carrillo
2019-05-09 19:51   ` Thomas Monjalon
2019-05-09 19:51     ` Thomas Monjalon
2019-05-09 20:08     ` Carrillo, Erik G [this message]
2019-05-09 20:12       ` Thomas Monjalon
2019-05-09 20:12         ` Thomas Monjalon
2019-05-09 21:19         ` Carrillo, Erik G
2019-05-09 21:19           ` Carrillo, Erik G
2019-05-09 22:07           ` Thomas Monjalon
2019-05-09 22:07             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE54F058557D9A4FAC1D84E2FC6D875723407ADF@fmsmsx115.amr.corp.intel.com \
    --to=erik.g.carrillo@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=rsanford@akamai.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).