From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EAB5A046B for ; Thu, 27 Jun 2019 20:48:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D71DB31FC; Thu, 27 Jun 2019 20:48:09 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A44442BF4 for ; Thu, 27 Jun 2019 20:48:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 11:48:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,424,1557212400"; d="scan'208";a="245912217" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 27 Jun 2019 11:48:07 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 11:48:07 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.71]) by FMSMSX126.amr.corp.intel.com ([169.254.1.119]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 11:48:06 -0700 From: "Carrillo, Erik G" To: "Burakov, Anatoly" , "dev@dpdk.org" CC: Robert Sanford Thread-Topic: [PATCH 2/2] timer: fix resource leak in finalize Thread-Index: AQHVK3Czp17BpxRqyUOlp+I2V5eb6Kav2SVw Date: Thu, 27 Jun 2019 18:48:05 +0000 Message-ID: References: <1557354906-2500-1-git-send-email-erik.g.carrillo@intel.com> <5c7403e06efccd2c8210ce811fa16c8e56e084b0.1561478924.git.anatoly.burakov@intel.com> In-Reply-To: <5c7403e06efccd2c8210ce811fa16c8e56e084b0.1561478924.git.anatoly.burakov@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] timer: fix resource leak in finalize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 11:12 AM > To: dev@dpdk.org > Cc: Robert Sanford ; Carrillo, Erik G > > Subject: [PATCH 2/2] timer: fix resource leak in finalize >=20 > Currently, whenever timer library is initialized, the memory is leaked be= cause > there is no telling when primary or secondary processes get to use the st= ate, > and there is no way to initialize/deinitialize timer library state withou= t race > conditions because the data itself must live in shared memory. >=20 > However, there is now a timer library lock in the shared memory config, > which can be used to synchronize access to the timer library shared memor= y. > Use it to initialize/deinitialize timer library shared data in a safe way= . There is > still a way to leak the memory (by killing one of the processes), but we = can't > do anything about that. >=20 > Also, update the API doc. Note that the behavior of the API itself did no= t > change - the requirement to call init in every process was simply not > documented explicitly. >=20 > Signed-off-by: Erik Gabriel Carrillo > Signed-off-by: Anatoly Burakov Acked-by: Erik Gabriel Carrillo