From: "Wiles, Keith" <keith.wiles@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup
Date: Thu, 16 Aug 2018 16:35:18 +0000 [thread overview]
Message-ID: <BEB2672A-C2E6-467D-9C25-AD2C162597A9@intel.com> (raw)
In-Reply-To: <20180816153106.7608-2-stephen@networkplumber.org>
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> The hexdump code obviously came from somewhere else originally.
> It is not formatted according to DPDK coding style.
>
> Also, drop the comment which is not useful the docbock comment
> is already in the rte_hexdump.h
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> —
This code was put in years ago, maybe before it was push to public repo :-)
Thanks for the cleanup and output cleanup.
Regards,
Keith
next prev parent reply other threads:[~2018-08-16 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 15:31 [dpdk-dev] [PATCH 0/2] eal: hexcump trivial changes Stephen Hemminger
2018-08-16 15:31 ` [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup Stephen Hemminger
2018-08-16 16:34 ` Wiles, Keith
2018-08-16 16:59 ` Stephen Hemminger
2018-08-16 16:35 ` Wiles, Keith [this message]
2018-08-16 15:31 ` [dpdk-dev] [PATCH 2/2] hexdump: align output of string Stephen Hemminger
2018-08-16 15:50 ` Stephen Hemminger
2018-10-24 23:40 ` [dpdk-dev] [PATCH 0/2] eal: hexcump trivial changes Thomas Monjalon
2019-04-02 15:23 ` [dpdk-dev] [PATCH v2 0/2] eal: hexdump cleanups Stephen Hemminger
2019-04-02 15:23 ` Stephen Hemminger
2019-04-02 15:23 ` [dpdk-dev] [PATCH v2 1/2] hexdump: whitespace cleanup Stephen Hemminger
2019-04-02 15:23 ` Stephen Hemminger
2019-04-02 15:23 ` [dpdk-dev] [PATCH v2 2/2] hexdump: align output of string Stephen Hemminger
2019-04-02 15:23 ` Stephen Hemminger
2019-04-03 16:36 ` [dpdk-dev] [PATCH v2 0/2] eal: hexdump cleanups Thomas Monjalon
2019-04-03 16:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BEB2672A-C2E6-467D-9C25-AD2C162597A9@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).