From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, dev <dev@dpdk.org>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [RFC] rcu: build on Windows
Date: Tue, 20 Oct 2020 12:43:38 +0000 [thread overview]
Message-ID: <BF9FA856-0042-42DC-A2F9-CCBD8425DDF8@arm.com> (raw)
In-Reply-To: <CAJFAV8yp_CaxjSpUBfuejzRyv1GxJHx3CW1z7Kt1pc-s2PYTnA@mail.gmail.com>
> On Oct 20, 2020, at 3:13 AM, David Marchand <david.marchand@redhat.com> wrote:
>
> On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar <dharmik.thakkar@arm.com> wrote:
>>
>> Build the lib for Windows.
>>
>> Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9
>> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
>> ---
>> lib/meson.build | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/meson.build b/lib/meson.build
>> index dd55b5cb53e4..1bb019720c6a 100644
>> --- a/lib/meson.build
>> +++ b/lib/meson.build
>> @@ -41,6 +41,7 @@ if is_windows
>> 'telemetry',
>> 'eal',
>> 'ring',
>> + 'rcu',
>> 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci',
>> 'cmdline',
>> 'hash',
>> --
>> 2.17.1
>>
>
> If we skip the new failures in Intel CI due to kni build being broken,
> I see that Windows build is fine but I have no log of it.
> UNH lab skipped testing this patch, as it is a RFC (iiuc).
> We need more tests, but on the principle, what do you think about enabling rcu?
>
I think it should work OK.
>
> --
> David Marchand
>
prev parent reply other threads:[~2020-10-20 12:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 23:33 Dharmik Thakkar
2020-10-20 8:13 ` David Marchand
2020-10-20 8:34 ` Dmitry Kozlyuk
2020-10-20 12:51 ` Dharmik Thakkar
2020-10-20 15:40 ` Honnappa Nagarahalli
2020-10-20 15:52 ` Dmitry Kozlyuk
2020-10-20 16:37 ` Dharmik Thakkar
2020-10-20 17:15 ` Ranjit Menon
2020-10-20 12:43 ` Dharmik Thakkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF9FA856-0042-42DC-A2F9-CCBD8425DDF8@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=nd@arm.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).