From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00721A0548; Mon, 30 Aug 2021 22:27:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79F4C41103; Mon, 30 Aug 2021 22:27:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 141EA41102 for ; Mon, 30 Aug 2021 22:27:30 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10092"; a="218356325" X-IronPort-AV: E=Sophos;i="5.84,364,1620716400"; d="scan'208";a="218356325" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2021 13:27:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,364,1620716400"; d="scan'208";a="576899936" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 30 Aug 2021 13:27:29 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 30 Aug 2021 13:27:29 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 30 Aug 2021 13:27:29 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 30 Aug 2021 13:27:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WS6nas/4PVrdFUibopv4VBeA710RIPOZpPSA56bW8xvAqnI4xqe6At5+GSXU882h7zDFHia81OrsIHs+L2GuHhbm9WEx/7UV7y7Fbk6pJPR0u1k0vj0NKwMOnAFrsY3FWAOb8OXN68vVnb765k3p2X89t5gTVl4NELbk9owDsYGsdAeBB/6iDToa1xTLSQdxyNF1JdyrBv0YsBundKEpzKQmGbUlK4wkWxVg8yaQzRRqzD2kEeWtw1/SS10uZB4cU0lNYK42PuRfj+9e+5j7k5ktQT6MAF5tLbAFe8k+M8+Mxxq9vMTZT+ZXQ9wN/wIHOV8ox20k5Xyl49TQ5BEyng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HRrBzqVYMsUbx4Dg8vowQo+SzsMkVMJR6ZOZzmPjkGA=; b=OiOcLqpY9RD1Hz3FoWbJfsXUehL4YvYZkH+uLxw9+VYJyzxLEdDgf3F92bCXXcHKflefFAjj9MXEyVeaQFUvnN8NJvSGqOqEFk+AoezS2quq/g/8p4db/icfcsJxrhcxC3RiLJKjEstdso/DMIXs4ZuLxZrzCjKDeEmPdn3XJLzusFnvhaACUNlhDsF7hrljpsWp7cs8OXeGAnXzauCWNppsCXvHWCrIojDcBvEQZlq43OuYEeD7YnOG30WeBjawJNB/OG+7kUVm+53FS5L2mgIQJOmCAE6+lnDf8ZunmO/flgzrQu17UqSoSDdbN2laPpeR6qQ/6ildR8YMRWJJUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HRrBzqVYMsUbx4Dg8vowQo+SzsMkVMJR6ZOZzmPjkGA=; b=ofWni01KfasF62F36XErlVoW6MX2m5zaw1SDmJ/+GrBwlVYthHhOySDjGuWn7BRbC6JVr52PWkZ/+qcMlbhhGT3tkyTwXtd42F6klpY7vx9yw7Sl75Sw/Q05SSTD1J5pHOAsMngPely7hm3pjH7oadDkcXy0h91XMNymJ3kc3Zc= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by BL1PR11MB5527.namprd11.prod.outlook.com (2603:10b6:208:317::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Mon, 30 Aug 2021 20:27:28 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3ca9:5da5:8b6e:ad0e]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3ca9:5da5:8b6e:ad0e%5]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 20:27:27 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , Matan Azrad , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Ananyev, Konstantin" , NBU-Contact-Thomas Monjalon , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , Ankur Dwivedi , Michael Shamis , Nagadheeraj Rottela , "jianjay.zhou@huawei.com" Thread-Topic: [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs Thread-Index: AQHXjiEbpiQKuDW4dUmU1gDJKZwiRatt3+AAgAAXFwCAHqTZUA== Date: Mon, 30 Aug 2021 20:27:27 +0000 Message-ID: References: <20210805200236.1180289-1-gakhil@marvell.com> <20210810195020.1423013-1-gakhil@marvell.com> <20210810195020.1423013-4-gakhil@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63bd940f-004f-4461-1e4c-08d96bf495d5 x-ms-traffictypediagnostic: BL1PR11MB5527: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +oQeXpcFpShe0/wZSDc+N7B3gdxtBe87YxdmhLtl8QD0icD+0KTGYlyvCH0i5Hi0763WvTjdIY4hURyKtOJowq9FYFob7jhOIi2ey3MjlANk1CWLm2sDTIr74XBxDyBZ57yRozvzo5AGJbvZZmTL6AiQVP1f1XPGrWcbs0P+8ZyjKmBmi1ebKACS3ioe4oEnfLWVj7SYDai23bSNr5NX6HzB4O/2VjOM4wfbsWK896wk9UcbDFwd8CRT1EqWVNSDEtu8OGfmgJ2Js1iigGLyVvcU+hcj7NT/eFci8jdOZGNM56LLlppZfzsjA9Jt+HS03e/UFwP/hHYUmnf5d/vQ9S1r/rhhBM6kvF1m/WojIo8hD3l4r9pFdmGiPdPSoT74OnQFK+LaofKbRnlMn1zDIWSSMW6reuteCsrS6eEzTlIDUkwjLPGL8Fh4SCp8fwOK4Cn9fbLqic3O6sUJP/rAS7PYhk2REXJSzXkdxXXUMiPko0gHS+wdRiRNvf4jKGNATdXjs414h/7xiSWZafiarPjpxExUvXeAzfzGvnSibE2PNZSjDCFbe6rR62mJpYH/COjxFIXoYy+YKNrvgtho/ersjhsteBIhUrz4AsVJTAyroXhcSxdUTC2E4CoIndSkm2VDjMHPDEExqITP/d3N1i9JS+qC+LEahfFchy9YA44WXEAtV1EJXt60KHCLqxMbA2VvtTo50KwhXiIRZrFZwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(83380400001)(7416002)(8936002)(66556008)(76116006)(316002)(5660300002)(54906003)(508600001)(6506007)(64756008)(7696005)(86362001)(52536014)(66946007)(8676002)(110136005)(66446008)(186003)(33656002)(71200400001)(66476007)(9686003)(4326008)(38100700002)(2906002)(55016002)(122000001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?gWe5jRM2tHhT4BVv5F9WqQ1gHiOiPWY8yFQuDusRe2NcmxtZd+XNvx4b?= =?Windows-1252?Q?QSdjkZ2HWMDXSN26VpXndbZLU4g0wgBc+MR/jMkDoTLezeilOFccwV8u?= =?Windows-1252?Q?CuLHQTQIFkVnuSfjguyNZZb7lwNFPMsQH9UPvHDxdG9VdrzRk8opP9tS?= =?Windows-1252?Q?xb76NHOOIG3BOYf3MdkRCftrmjMR4skeifL7t/zvXiz6Zdps3j2zMwKz?= =?Windows-1252?Q?7lMkhmcW7BZrohJNK8xIiWbmMgx5SJLf5DsewCVcIbHTtV0NPiX3XCIR?= =?Windows-1252?Q?L1J8YuiSZQ4mcsBiOTZ/E7BBn1Om4VAcZndK0wWeT+vpTGPknchCrlcK?= =?Windows-1252?Q?JxRHuizUKbEhsKpmR9AdqFgUM+8NWQnNY4J/T/R8+LQY0rDQ/I0cXSN/?= =?Windows-1252?Q?ngClmGPzsK0xZJ5B95SOoE0hxneJh/Kkgf4ICwhPs0rTW8chVuQIEg/C?= =?Windows-1252?Q?zl9rXnQ9H2XdFJcb7G39dI/4Qu/IiOy0MK5pThLoPLyYvm1xmW+EEQ0o?= =?Windows-1252?Q?h9duXLdgaSxjQo85K8Y64gSTk4T69yx9lAZQvFsLql126Rpqp/A6C2cz?= =?Windows-1252?Q?wmifoeHwgAHiQX+53UD3ihmDZ85kdX5wSJFCSrypa+sFz08ZwW3p1iJE?= =?Windows-1252?Q?AD876rAtpAj8GYgw4cyIvUM77eK4NQXqCa1BxHK8zSCBexnBTVJj7/0E?= =?Windows-1252?Q?u3R3mvE+jMMKK3sHUi6YktLVG3IYKI+KxJb0Z4e078sdtF5TgcTQDaln?= =?Windows-1252?Q?u2SIAlWpwdU5LRBZ/ikk64+Wg3hC6hkIbalBExn+QaYIFLdUQ3u3xcsc?= =?Windows-1252?Q?7bkurRSjkI6r8pz0wkhy3pF6eO0d8Q6Imj//ciDfdkJm3UJSBMeqM75J?= =?Windows-1252?Q?EVBrJgBf3t3iZbRfQhfdl0tC4rKBcx/t90HvDDr0HK9SBtZwND5KI97q?= =?Windows-1252?Q?YtBTGWdW2egkVMGGTO6OI8zhfk5HmV2wW1k5SgAHsQ0dmEhQTOX5Mo3K?= =?Windows-1252?Q?fn7GL+qytZ8e72NMz5JP5tEQOOVRhIPfqLKBMGaE25foGjJ6ikmZzsmn?= =?Windows-1252?Q?ViTzP95LrJO3XoXiPi64a+subP63lpvDRBPnu/sHCfDwiMFsJF33KR9A?= =?Windows-1252?Q?nRJ5nSfTgiRCXNH8jdADDVwkqK7mDIMOyeMDbJUF3hmJWbncfkhyD1p4?= =?Windows-1252?Q?2/WONfBYJUPfB+AmDSFVUNdjnSHwfgBUL40my8M1nxOziAOL0FAArAwp?= =?Windows-1252?Q?+zIqdWohBwDMxadbyw1AjsE3n+tVNT3eBehERn0JeVOZc2qjfOHx4sK7?= =?Windows-1252?Q?voWjJuoRUoEk/l8DMIATjewYJO8S5vQHZqYu1fuLi9Z3sqXUq4gOESCy?= =?Windows-1252?Q?MfyZTTKrzgtpEIo/4yWqL3QS8HyDQvR//O6JSTJ59BBmM0HgwwWZWedE?= =?Windows-1252?Q?UzmrSq2VYMYpYTxRaVXCgkZrCl3wFg7fPWu3yhY3eFnIOs35G85Suj8H?= =?Windows-1252?Q?KTdvVXmi?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63bd940f-004f-4461-1e4c-08d96bf495d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2021 20:27:27.7731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EwE/wFdkh5ytss1+mpg2HhBOKo92gGBaOqs5xFcQQxm68qlTg3T8iQPa8JbUPu2Pp0TlpjWH8TjPAmE6ttw8DA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5527 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, August 11, 2021 9:20 AM > To: Matan Azrad ; dev@dpdk.org > Cc: Anoob Joseph ; Nicolau, Radu > ; Doherty, Declan ; > hemant.agrawal@nxp.com; Ananyev, Konstantin > ; NBU-Contact-Thomas Monjalon > ; Zhang, Roy Fan ; > asomalap@amd.com; ruifeng.wang@arm.com; > ajit.khaparde@broadcom.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Ankur Dwivedi ; Michael Shamis > ; Nagadheeraj Rottela > ; jianjay.zhou@huawei.com > Subject: RE: [PATCH v2 3/4] examples/fips_validation: remove illegal usag= e of > APIs >=20 > > > > From: Akhil Goyal > > > Some of the cryptodev APIs are not allowed to be used by application > > > directly. Hence removing the usage of 1. queue_pair_release: it is no= t > > > required, as configure > > > of queue pair release the previous queue pairs and the > > > dev is not directly exposed to application, hence cannot > > > use its ops from app. > > > 2. rte_cryptodev_stop: it can be used directly without > > > checking if the device is started or not. > > > 3. rte_cryptodev_pmd_destroy: application should use > > > rte_cryptodev_close instead. > > > > > > Signed-off-by: Akhil Goyal > > > > Look's like it should be backported to stable releases with a Fixes ref= erence. > > What do you think? > > > > Besides, > > Acked-by: Matan Azrad > > > Yes, Agreed. > I wanted to get opinion from the Maintainer of fips app first if the chan= ges > are > Correct or not. Hi Akhil, FIPS requirement is upon failure of running self-test the device memory shall be destroyed completely and not visible by the application at all - rte_cryptodev_close does not provide this functionality.=20 In this case we may need new API rte_cryptodev_destroy() to replace=20 rte_cryptodev_pmd_destroy(). Regards, Fan