* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
2021-02-04 8:05 [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option Ibtisam Tariq
@ 2021-02-04 13:07 ` Zhang, Roy Fan
2021-02-04 13:08 ` Zhang, Roy Fan
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Zhang, Roy Fan @ 2021-02-04 13:07 UTC (permalink / raw)
To: Ibtisam Tariq, maxime.coquelin, Xia, Chenbo; +Cc: dev
> -----Original Message-----
> From: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> Sent: Thursday, February 4, 2021 8:06 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ibtisam Tariq <ibtisam.tariq@emumba.com>; Zhang, Roy
> Fan <roy.fan.zhang@intel.com>
> Subject: [PATCH] examples/vhost_crypto: remove unused short option
>
> Short option "s" was passed to getopt_long function, while there was
> no condition on this option.
>
> Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
Acked-by: Fan Zhang roy.fan.zhang@intel.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
2021-02-04 8:05 [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option Ibtisam Tariq
2021-02-04 13:07 ` Zhang, Roy Fan
@ 2021-02-04 13:08 ` Zhang, Roy Fan
2021-03-19 9:18 ` Maxime Coquelin
2021-03-31 8:31 ` Xia, Chenbo
3 siblings, 0 replies; 5+ messages in thread
From: Zhang, Roy Fan @ 2021-02-04 13:08 UTC (permalink / raw)
To: Ibtisam Tariq, maxime.coquelin, Xia, Chenbo; +Cc: dev
> -----Original Message-----
> From: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> Sent: Thursday, February 4, 2021 8:06 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ibtisam Tariq <ibtisam.tariq@emumba.com>; Zhang, Roy
> Fan <roy.fan.zhang@intel.com>
> Subject: [PATCH] examples/vhost_crypto: remove unused short option
>
> Short option "s" was passed to getopt_long function, while there was
> no condition on this option.
>
> Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Sorry for the incomplete ack in my last email.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
2021-02-04 8:05 [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option Ibtisam Tariq
2021-02-04 13:07 ` Zhang, Roy Fan
2021-02-04 13:08 ` Zhang, Roy Fan
@ 2021-03-19 9:18 ` Maxime Coquelin
2021-03-31 8:31 ` Xia, Chenbo
3 siblings, 0 replies; 5+ messages in thread
From: Maxime Coquelin @ 2021-03-19 9:18 UTC (permalink / raw)
To: Ibtisam Tariq, chenbo.xia; +Cc: dev, roy.fan.zhang
On 2/4/21 9:05 AM, Ibtisam Tariq wrote:
> Short option "s" was passed to getopt_long function, while there was
> no condition on this option.
>
> Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
> examples/vhost_crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 29c8f7228..66bde38c0 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -219,7 +219,7 @@ vhost_crypto_parse_args(int argc, char **argv)
>
> argvopt = argv;
>
> - while ((opt = getopt_long(argc, argvopt, "s:",
> + while ((opt = getopt_long(argc, argvopt, "",
> lgopts, &option_index)) != EOF) {
>
> switch (opt) {
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
2021-02-04 8:05 [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option Ibtisam Tariq
` (2 preceding siblings ...)
2021-03-19 9:18 ` Maxime Coquelin
@ 2021-03-31 8:31 ` Xia, Chenbo
3 siblings, 0 replies; 5+ messages in thread
From: Xia, Chenbo @ 2021-03-31 8:31 UTC (permalink / raw)
To: Ibtisam Tariq, maxime.coquelin; +Cc: dev, Zhang, Roy Fan, stable
> -----Original Message-----
> From: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> Sent: Thursday, February 4, 2021 4:06 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ibtisam Tariq <ibtisam.tariq@emumba.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: [PATCH] examples/vhost_crypto: remove unused short option
>
> Short option "s" was passed to getopt_long function, while there was
> no condition on this option.
>
> Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
> examples/vhost_crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 29c8f7228..66bde38c0 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -219,7 +219,7 @@ vhost_crypto_parse_args(int argc, char **argv)
>
> argvopt = argv;
>
> - while ((opt = getopt_long(argc, argvopt, "s:",
> + while ((opt = getopt_long(argc, argvopt, "",
> lgopts, &option_index)) != EOF) {
>
> switch (opt) {
> --
> 2.17.1
Fix two things before apply:
1. Change Fix commit id to 12 digits.
2. Add cc to stable tag and cc to stable as it needs backport.
With above fix, patch applied to next-virtio/main. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread