From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BF11A04BC; Fri, 9 Oct 2020 10:32:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7A2B1C1D9; Fri, 9 Oct 2020 10:32:42 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0FE2D1C1D5 for ; Fri, 9 Oct 2020 10:32:40 +0200 (CEST) IronPort-SDR: LYguovHMnRUo0gq6z693/GB7dREXYABtglCQyXrH2becz1FNeDuT7rvbGv9JXlOk2xIF59Arg6 VZJBA8w4k45A== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="161997398" X-IronPort-AV: E=Sophos;i="5.77,354,1596524400"; d="scan'208";a="161997398" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 01:32:39 -0700 IronPort-SDR: LhRCT8VpH7FZgwW2SDwnHqSK5BjJkdPELeASTD0ftnlabq3AEwXRWAt28GNdnORBqgPkFTYI5w FDtt0BiNYJZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,354,1596524400"; d="scan'208";a="316968934" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 09 Oct 2020 01:32:38 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 01:32:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 01:32:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Oct 2020 01:32:37 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 9 Oct 2020 01:32:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=az+sBfKvNxqrx5xC/xcG9IVRM/S0SqAUoIL3Q/e9qbDZyzEKcWSKDvj3wT4TAbDrNh/bHnNz8M00gb2XoHq5jH2+2zVzMuDyq7rtt8AERvYzRod48FUKc5MDiXeehfrOU+YlRyY1KqjiDbzJJ5Upd5WmQmJPjTqaNgPjNrXv0/nioAY/YHlxvqY/yztEK/ZizrKXUpbZNHu3khX1nfRQXGjvWOqgmjCth/DTKQNIbZ1z9WoXuMYQbX3dugcxOX3qHob05cxipeGbg82WA3rSlQ0ceFydbUxvyStZoA+fk5iBtrXJ+E0gaTeyiQRBdEPKe7bN8Bmwsa6+BX/mWvSWsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QDXJvINxBIZlGIdrxWPfIg3h0dON3EZ352IJyonnj2A=; b=bT3HhbCy9bWm7BDkc18uBhpwT1FtjTaZVl+I7TwAu5Uq1XRFcUQgOw5swrSJPrN2UZ+byEKJjkuJVH27Mi9CK+7gzibfBQrdt8y+CvmuG46OH1LsknlDC//1FZN0Brxcp5m8shMClRw9eon79+2dtUknuSdfKSEsygakCcSgkvg2VmZrBJckdk0UWVYDihu8H3MwBOCwe7B47us+BSu6kNSRMwEBgInN9eLF3XANvbMSnRWNmoR1qCZFQ9xnSVp4+XM0z8S5sTjA1d4CzEWhu86WQkkJgHCKEEsfdBmbAMXLbt5X0KNjpBOdjKSgUzsBfTC/IVpvm5sL0ZUqxD03OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QDXJvINxBIZlGIdrxWPfIg3h0dON3EZ352IJyonnj2A=; b=vn+K6stcShPfVk8JsERepx2XcXHTBjKxAjD8JJYzJAT9ewMFIx3H5F+lHepsuZDVgCEA9qqHPrFxKgMBurzp7FX5a4t59p8o089EIfqixRrw4xT+k/S1blHJCEH517G/jYe7ZIJLp84tOoUnlvYNmRQtabka/HRAFnoiCfZezI0= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4415.namprd11.prod.outlook.com (2603:10b6:208:192::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.26; Fri, 9 Oct 2020 08:32:36 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::11fa:a7fe:329d:9239]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::11fa:a7fe:329d:9239%5]) with mapi id 15.20.3455.023; Fri, 9 Oct 2020 08:32:35 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "Dybkowski, AdamX" , "anoobj@marvell.com" , "Ananyev, Konstantin" , "Bronowski, PiotrX" Thread-Topic: [dpdk-dev v10 2/4] cryptodev: add raw crypto data-path APIs Thread-Index: AQHWkpCfakqJykQoQUaUoLsxzeLwr6mN2MkAgAALuSCAABCrgIABD6Hg Date: Fri, 9 Oct 2020 08:32:35 +0000 Message-ID: References: <20200908084253.81022-1-roy.fan.zhang@intel.com> <20200924163417.49983-1-roy.fan.zhang@intel.com> <20200924163417.49983-3-roy.fan.zhang@intel.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [95.44.220.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d247d30-7895-4a7d-63fd-08d86c2ddfdc x-ms-traffictypediagnostic: MN2PR11MB4415: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hVkiusgeNNb61uZd9W32Tz8BmJmiYkN+bYH0omC0oa4NTUeP0TyQ9zMHqXthzHLJLDN1kRpZOjl2gePf49MobEVcxLQ4IHSjmoNSXf8KKHF6z2SatOixaYW5+2hZtZvGgvqTcLoGco8qErzBxqpt7MUmZUWBR2JpK358D4cjZq5YA2bxr0lIbCxRfEZjIqqKH74ldRYlV5iaQsoNErIcIS17405cVOpQiKK9abPH981te+/1ry8n/rc6d3RpaIWkZOgFr0CJA8EggJPtjHxRZnQDNhQdaeKkD7JksimA9bBHkwbdMmcdocUP4oXX2puVJflL0WftoHEzKr6YI8/q2A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(83380400001)(33656002)(2906002)(71200400001)(5660300002)(52536014)(66476007)(66556008)(64756008)(66446008)(66946007)(76116006)(110136005)(8936002)(54906003)(55016002)(9686003)(26005)(8676002)(186003)(316002)(478600001)(86362001)(4326008)(7696005)(6506007)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: O6WSvJ4LddHxZK5MfCrKzEm5yLriKNdqTqSOlQdmriWYRfU9s6/BYRt3dmQsB1/LjXA6Yz++ufrMbS83cpzVVguO5S5Ruxt+cP+wVJ344gXXgZB8T4d5/dmwK1NHjYb1wf8SwBDQzEnzONbCtE6CagEMR/WBDWZbMfQKjk0sNbROSk4v3n8+8i/PH8zI9Bpa0bXi8fUaK6QnQnNYymzXqOAUow83l3Z5koRFM6K2yLFN8IY3Tu9JsxAmmw61z8axHnBx8YbwXO+WLq4Lfl3kFfz0R9Kx0p4aQWkP76s43aK5B9b/O/FT+3X2DXEJp8Xvn/kkxnTo8uKT4MsMucoV7TMYKhIiwDoT7CbEw0b8dei7//6fEjEP3kiUh77DKG+StXjZUSS5fjdmhiXoC//HC+Ph8LhgWXlNXja1TVLlTOR9f4SvAXQEVqz6xMepNkoCtMjpxFD41qlx1OnW2aFigyMRKCCf7k0yAot86nYZm4kXlugtHv1S2SaKBp1/0uXw8guXb6P7kdPyfNrOE/pNDrjNz+E9QFnwinE2tZoB09W945Lioso8H5OgLC3iZ5vQ9HNLR2PgUdPfJmTuxlXICcPP31o7WIH0erX+c6sksLHarbiwcEm9IDjFz0B5Os2VOXai7zsyUcFIJaEVGwfxgg== Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d247d30-7895-4a7d-63fd-08d86c2ddfdc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 08:32:35.4328 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gEzyPOF9QGVpwz6as22ZQuBXQaTsij+ZDXsLqhV3WcAIqk+T2Qr3Gt+aiwZJmzSh4Hs3pvfPsvvawKCTBeRerw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4415 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-dev v10 2/4] cryptodev: add raw crypto data-path APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > > rte_cryptodev_raw_configure_dp_context creates a shadow copy of the > queue > > pair data with in ctx, where rte_cryptodev_raw_attach_session sets the > function > > handler based on the session data. Using of the same PMD callback > function is > > to > > save one function pointer stored in the dev_ops. If you don't like it I= can > create > > 2 callback functions no problem. >=20 > I don't like the idea of having 2 APIs. >=20 > Why do you need to create a shadow copy of the queue data? Why it can't > be > Done in the attach API by the driver? In v9 it was doing that, why is it = changed? >=20 The reason for creating shadow copy is for enqueue_done and dequeue_done.=20 As explained if external application uses a data structure similar to rte_crypto_sym_vec and expect all ops or no ops are enqueued/dequeued,=20 it is impossible to do so with rte_cryptodev_enqueue/dequeue_burst. The local queue pair shadow copy helps temporary caching what is already pushed into the HW queue but the driver has yet to issue "start processing command= " to the device. Once the application finds out not all ops can be enqueued o= r dequeued the temp shadow copy can be reset by issuing rte_cryptodev_raw_configure_dp_context again.=20 In v9 rte_cryptodev_raw_configure_dp_context has another job - to write the function pointers to ctx. So if we are to use the same ctx for AES-CBC and = AES-GCM but we don't want to erase the shadow copy data again we need the "is_update" f= lag to let the driver know not to erase the queue pair shadow data but updating= the function pointers only. As you suggested in v9 "is_update" is not needed - to avoid using "is_update" I used 2 APIs instead, one for initializing queu= e pair shadow copy, one for writing function pointers by parsing the session. Regards, Fan