From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1214FA04AC;
	Mon, 31 Aug 2020 14:22:50 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A76661515;
	Mon, 31 Aug 2020 14:22:49 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 15337DE0
 for <dev@dpdk.org>; Mon, 31 Aug 2020 14:22:47 +0200 (CEST)
IronPort-SDR: u8pUGh7Aq2FqRFL0+WFrG/znZhwfuYeOFDxYRmCPmtMJd94UYA1arbKfaVpGUnMNFpSTcc7fnB
 rCGE9K7orSZw==
X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="137008873"
X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="137008873"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 31 Aug 2020 05:22:46 -0700
IronPort-SDR: YcY7wkppEZEFB16wkEctKcQSSKIcH0jhV4e72vt1jvSfG1yq2c50GVq4nZYJzIng4pkGDE1ev5
 DChH3wsDBhCQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="501316086"
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by fmsmga006.fm.intel.com with ESMTP; 31 Aug 2020 05:22:46 -0700
Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Mon, 31 Aug 2020 05:21:32 -0700
Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by
 orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5
 via Frontend Transport; Mon, 31 Aug 2020 05:21:32 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 31 Aug 2020 05:21:31 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ak0BDfez3gwzg66byupKPLIYI27dkGYnCHulGHAuxXBRsNcltdMnknmgg8Js0/mIMPrh8eOOp2CW0kBSJnrnvbMBHq2b9vVk3pw5oymwLDQMKuWJut47K8x0MyZP+HUgM1Mg6BAhk2TdmpG7hLnrnToBjPqyKUygxGL2Cxy3zS8N4dPV7qedNQF2XLtUeHyh2ICcSQ6xZN63rMiVNBMsVfdzdxgM3m+xJtlvZ+O4EPYrGxDC/zLt9zpNjv2jUFvS84EkfObok0y3R33epMKf8xSm3br89r44+8juSJvB3/zysfVe6uSU5j4RctBJTs3omyJjLnMvxF9ET/Ie/DC6DA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=f7s4EN1Ea/URoiF0LpmS4rUsRUpVH6SUmsYcKN8Z5hc=;
 b=Z3mOUMgpGL1+bRI8v5WMnD9ve5QjnOQQZGnP6ddZPZo5XkxJBmEaSafHvEyPozsk7dPaqtk+FNORSvV02Pj1+rR059Hh6W3sNHYbLUNsEqXCBtxkJovU5CNFr+9sNJ7IsZsHUPwIxt1kLGwoYrmZhbKCAgXlMKElRtR2TW5QBgDxtP1BZIjS4+c3FRykpV0KvwUrDqs+GBh7+ZZCQzcFQZKzbGpptxGDjnY6inMBZjnhhbKuLSCGNrNnlXlpNhI4H6ym2kiafxq3noZ/EcL5eSlv2BDw7GiiM/kvdEOB+8vm9QMx2KZ87BsAu1lmdZnVvedegU6pr7lG3m5LKetocw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=f7s4EN1Ea/URoiF0LpmS4rUsRUpVH6SUmsYcKN8Z5hc=;
 b=THzBY1MPYnrUIjf7ZgWH5mVzwgn5qCvXv880zqqfO1Lk6Olr9aV1mxupJiQGWxgkL19QsuLt0nQvx6agB2b4DUJayVJUBma1sNnmr0nCdAlCEqr/9LVYyJD1q2RX3pAD2E28VJ0EEoMu0JP3MLkVuyvYNX7iyWCdALMoyKaBeUU=
Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19)
 by MN2PR11MB4256.namprd11.prod.outlook.com (2603:10b6:208:17b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Mon, 31 Aug
 2020 12:21:29 +0000
Received: from BL0PR11MB3043.namprd11.prod.outlook.com
 ([fe80::11fa:a7fe:329d:9239]) by BL0PR11MB3043.namprd11.prod.outlook.com
 ([fe80::11fa:a7fe:329d:9239%5]) with mapi id 15.20.3326.025; Mon, 31 Aug 2020
 12:21:29 +0000
From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona"
 <fiona.trahe@intel.com>, "Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
 "Bronowski, PiotrX" <piotrx.bronowski@intel.com>
Thread-Topic: [dpdk-dev v7 1/4] cryptodev: add crypto data-path service APIs
Thread-Index: AQHWfTrsmsBR7PhRE06AEO+eQh5X46lRxCCAgABEzfA=
Date: Mon, 31 Aug 2020 12:21:29 +0000
Message-ID: <BL0PR11MB3043D6AF0C350ED9958C5EBFB8510@BL0PR11MB3043.namprd11.prod.outlook.com>
References: <20200818162833.20219-1-roy.fan.zhang@intel.com>
 <20200828125815.21614-1-roy.fan.zhang@intel.com>
 <20200828125815.21614-2-roy.fan.zhang@intel.com>
 <CY4PR11MB18304EFD5ECB8A6AB7A5856B9F510@CY4PR11MB1830.namprd11.prod.outlook.com>
In-Reply-To: <CY4PR11MB18304EFD5ECB8A6AB7A5856B9F510@CY4PR11MB1830.namprd11.prod.outlook.com>
Accept-Language: zh-Hans-HK, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmEzNTQzMDItM2E5Yi00ZTMxLThmYjQtNDdhYjk2NDU5ZmY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU2l0bEJ4NUppcnd3ZEpQRVRoQ0J0S0ViYlFkTnRxempLRXg0MEJFRU1lQklXQ3JRWHRKOGM5VXIzZk5XQWp5MSJ9
x-ctpclassification: CTP_NT
dlp-version: 11.5.1.3
dlp-reaction: no-action
dlp-product: dlpe-windows
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [95.44.220.85]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 98ab05f3-361b-4c46-59e7-08d84da863ee
x-ms-traffictypediagnostic: MN2PR11MB4256:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR11MB4256C37F4220A39359B66423B8510@MN2PR11MB4256.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7AxviHGnyImdkcOitqREHfSOHaKcSN5U+dprYC6fyALT/fVx8U/jYp9B13jutZ7DWteTxB5JSTWnwm3+HfuT3BfFwnp3Ectc2CVA0QGdRKl2ZXVmWjPsH51v9nhrM4KN+ndLK9fipNrVcH4qVoOUJ9du7nXQLgpO3/RTaheh2CIxJn0uSrfwxRQ0c29M5TNYNbTntgx6cP94neBlLpQjvBv9KMXgjKEMrRQLG/t6Tr/7noJwKARc/nA8m1NIb8wTHbsOlsCFSCxc2SW/xa+DjWygiGWTm72GtsSY0rLA25Cl1bqnAL8JOqgQ9uSbRW7YtJ/rTvcp2eVMkLBRauCa1Q==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(55016002)(66556008)(478600001)(83380400001)(54906003)(66946007)(76116006)(66476007)(9686003)(110136005)(4744005)(33656002)(7696005)(316002)(8676002)(86362001)(66446008)(64756008)(53546011)(6506007)(186003)(52536014)(8936002)(71200400001)(26005)(107886003)(5660300002)(4326008)(2906002);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata: 2lLJeBxQIhUloF2l7gkuZIoyMzaF8lyb3FLQZBlzQj4FxbRb2QO9FwXAVh45FPcrrb07498ItmgD//hFB4fGbuKqNTePUYuzUNm63bvd9qmXq4fS6Hp6B0QlPWyXIAh1rpWdhW0CpK43xxx1qbodTSv4xWCqIy1sR879bKa3WfScCit98ep5G0he8nonHfjWlq15UJk4M+niQYhtbvg2IZUZEbdIJOVzTZD9xKjlJbTIyCFAOkLaB06zkum5Z2lWrGThoZuMNFc2AQWDvJ83sWikfGRIevw1eiarC9POIWqmwN1x2VRiwIdUSuQVVzsaCCnje4KAIMGNdH6fRYwuq8zJz4QHgZVQTVI5eZVSHMfKVF9cuGvuxPnGUT0aEss3kIaDVV5W41kbt72w5HDRnC5x2/Dh5sGrJPAg1FxMiuo6iqvlHSQuisr7/WZ7GYSWDQ9e+gVqysSyw1Z+Y5uJzvEYjecqdHBgbb6NZxCWhUbv0joCiwd/hDsTMwn38LJy6Za2FghXIFdqDOtO91MmlUOc6OX/yQpuZyD+gCAZE1hx8Wiw3REw3Y81pL5qmahQ6TFjD0j3+BNeH4zUms+jQebHQr+JDZ86F8anoMW6nxEcmxA3D2e+OHXbMfqKy6DsXmI4eIybiRh5bC25bVl6pw==
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98ab05f3-361b-4c46-59e7-08d84da863ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2020 12:21:29.8075 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: geMacpNJvpDQkaDCafZI8Jb9KJ3auLiw1VysrdnnJW9B9p5MyjEjQxo8gTVLKIH5Twj4LdxB+Bf5nDZ+pL2gfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4256
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [dpdk-dev v7 1/4] cryptodev: add crypto data-path
	service APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Arek,

Thank you very much to review.

> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Monday, August 31, 2020 7:24 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Dybkowski,
> AdamX <adamx.dybkowski@intel.com>; Bronowski, PiotrX
> <piotrx.bronowski@intel.com>
> Subject: RE: [dpdk-dev v7 1/4] cryptodev: add crypto data-path service AP=
Is
>=20
>=20
> [Arek] - Two small things:
> 	- rte_crypto_data - there is many thing in asymmetric/symmetric
> crypto that can be called like that, and this is basically symmetric
> encrypted/authenticated data pointer, maybe some more specific name
> could be better.

[Fan] Any good name to propose?=20
=20
> 	- can iv, digest, aad be grouped into one? All share the same features,
> and there would less arguments to functions.
> --
> 2.20.1

Something like=20
struct rte_crypto_sym_<GOOD_NAME_HERE>
{
	void * iv, *digest, *aad;
	rte_iova_t iv_iova, digest_iova, aad_iova;
};
?

Definitely can do.

Regards,
Fan