From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4140A04B1; Mon, 23 Nov 2020 16:25:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9579C8C6; Mon, 23 Nov 2020 16:25:47 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 237C9C8C4; Mon, 23 Nov 2020 16:25:44 +0100 (CET) IronPort-SDR: Io7IDJzxWD+PdPgTZsLA2y+2+flLoVy+uu3CKKIwjBfI8bY+npekaVD9t7T9n6xTGcOuQFbmMS qcFtAZ8GYvuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="151625786" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="151625786" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 07:25:42 -0800 IronPort-SDR: p2aNycQ581ieYsAWlQP9q0K0NmJqftqkj3yJuyhVlTmexBzWwoMcv03/5L28nMP2zXm3W/SK1H WxPz3OkL+zWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="364681876" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 23 Nov 2020 07:25:42 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 07:25:41 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 07:25:41 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 23 Nov 2020 07:25:41 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 23 Nov 2020 07:25:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NG9VbBtHavAbN/S7XWmzJdrwFdD5lS7Xk/qH90HJiXj9kEg9xdnq3Q0qWteSjtFSv2a2WdwC+qDy3Gfx5H3FvAKSOUUa6aU4+ZrQaSAm7W2u3cetigRQF7yL+k2BPlSO/SIxY+1voJGl3T2DVvNMvNv/ogotovBM8gz1SKePz7PY69gmyZNY7P+saBcXlUlUevXybUBegB6Z2rdZ07S7wOjnwOtvIpwtkO8fQPZuGAG3hsQnqarI4dKEdlh5insI3VfRkga/QjCDdjImBTuzuf8TQGihmW7pOL4s4FlVj8zKEw2rprQLsxuJcXQ+RrhmD7W5a4XSnxXdUzWbsqKphg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brS8GKZ3qZLdWvzAZNHtOncXRSg8PRuazi6c+cHI0qQ=; b=QWpGm02gYkjRE7Q0k7NLxq0/BO964sl65G/J5LBwr9ephCkEr+jRRWSpSbEM6ZJio1XW9UMNMo08KXpYNbfQ8XG850VvxpXtsNvpO+lUs1HW2pgQBBEfYCFeV9LrGSspabbohzQ2bWbwSKMmFuLWRR1imrtBnrPWPjMbkWIHzjugQ+7RXRKR5vHqA71OsXmDOv1zMI34eXj229+6CINEXicIt2EjYcpvcwqovuz9qnS7qakcT4ZtsC0KGNZMFzngEwhdmnhxjFe/bBP+aSF4/CDTM1VINYgBhIe8ODD8Sha8rWz7jWjZuCDnBAMrGIfDHQ2N8h3qY1O9U7GtmyzELA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brS8GKZ3qZLdWvzAZNHtOncXRSg8PRuazi6c+cHI0qQ=; b=XH+GXhjm/VzYKRjwoKcT3ojh1c23DPrGpbYZ0HePM662UpD48BlNwhABgBJK77S4Uto3eGVDCBeuPlzmhGn3tqB+B2KpP2hIyNGfdy7IhuViWOxV+CNpXl6ZA+BN9pJEiEfMXwmixOPQuoLN3EyuExsNx2AVLeOVJmvKwG9bEkk= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4272.namprd11.prod.outlook.com (2603:10b6:208:196::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.25; Mon, 23 Nov 2020 15:25:39 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::cad:4bf2:7678:568d]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::cad:4bf2:7678:568d%3]) with mapi id 15.20.3589.029; Mon, 23 Nov 2020 15:25:39 +0000 From: "Zhang, Roy Fan" To: "Yigit, Ferruh" , "dev@dpdk.org" , "Doherty, Declan" , "Kerlin, Marcin" , "Mrozowicz, SlawomirX" , "Kobylinski, Michal" , Piotr Azarewicz CC: "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [v21.02 v3 09/10] app/crypto-perf: remove always true condition Thread-Index: AQHWvmv6ULCPxzj85U2EC/odCjatWKnV3Meg Date: Mon, 23 Nov 2020 15:25:38 +0000 Message-ID: References: <20200824094021.2323605-1-ferruh.yigit@intel.com> <20201119115900.4095566-1-ferruh.yigit@intel.com> <20201119115900.4095566-10-ferruh.yigit@intel.com> In-Reply-To: <20201119115900.4095566-10-ferruh.yigit@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [95.44.220.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64e8f361-c9b7-47d9-2358-08d88fc40870 x-ms-traffictypediagnostic: MN2PR11MB4272: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:595; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PRX5H/AK5U/WydYbckarvr2bxRblHdkQQLjCUn2qeQbQEAKi7Dfeb0wtEFi0Dke6VlO6rwoqlxQdlT231KV124wZLsW5awzCi0dwYT+CDJKHN1X1q+I7296AzoY4hZgnPGe6LTyKYsfJtz/hq0jegOKbobMn3J9biRM2vCE+Yx7cEZJce+kJd0/K91pMkUvcn1RPbT+qScxfmt1N8yajKpKgwbrXF/wrIfk8VxOU85pRZSo0sRI5WKG9I6X01idt9EnJeSltFr/1BxNTUUZW0VAHh2esgb7ad4nGRPMrwDf2J0hsMyGkT5iWwmzox+TWvU74G14n8a0Ry1+o6WBXzThPkdTzPPzWV7WDPxHQlhbkg14OV5araf3e5L/DNd+y x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(316002)(26005)(186003)(110136005)(54906003)(33656002)(9686003)(450100002)(4326008)(6636002)(8936002)(478600001)(6506007)(53546011)(7696005)(55016002)(921005)(71200400001)(2906002)(64756008)(5660300002)(52536014)(66446008)(66476007)(66946007)(83380400001)(86362001)(76116006)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?RaDIdDE2x5y1gSK/kuh9PPx7tXD0vpYY4eTHWRvJ13MZyphanT9ps/lm?= =?Windows-1252?Q?Z7h8woz81F9AAlzB+SnGm7/2L7CPppfDKy0XeXki6f6jirSA/KDHOgUT?= =?Windows-1252?Q?p2VjHgtxBE+ybAv1FzpINhop68E9IA/XZu25i10LAZS9FtfU5g2TWotM?= =?Windows-1252?Q?debimJ7zrWBKAxZjZYUyg6FldbmpTfLKs4nMLzCN619yWjW0PpvsDoUB?= =?Windows-1252?Q?hDzi7huXm+NZa7qVi0U2bHJ9k/wKBqgxVq51H7EdkP8p4XBGXdG7K2Z+?= =?Windows-1252?Q?ce83T5rRBdbgGp1rgi3uw0RzAncBLsiDpY/DG3J5s8+TdCz2tQ+FMLDK?= =?Windows-1252?Q?WzvIAl7zbJYGKTWMKghBZdY4CyNsnSMXLrWgJStckbL44eS0ouvbJtPK?= =?Windows-1252?Q?ISL/QBw0UK9+74MHGDBsVsY+fQwpIEhZEfwsi8H54iOgahKf90kBk8OA?= =?Windows-1252?Q?mHU94J79uyB7QhAVUfmXY0+zpQCPo9FnxKywUIZSR8bjuUxP983q/9+a?= =?Windows-1252?Q?QgNv7C+ypRo5AoH5Leetj3M8b2S21oBnMEJL88f7S8vHC/UrYdj3KJH9?= =?Windows-1252?Q?q0VFAGRnDMi3/PPMQjKouZBybYAFkOUVaC5uuh6HF5HcjsWpCdhySkmK?= =?Windows-1252?Q?8IhHojCpTs8rbn9DWJW2R8cR58Do+RCMjbHewfR1Nu0kSZmbaY+0BU9x?= =?Windows-1252?Q?pZHiGij5yA5GkAyUblN4o3tzwucYs2GRY0GrpOF1b3sAhBTPuRX7EmF4?= =?Windows-1252?Q?F3g4Jof4LClfgFU+QTKAQViVyr6cyBs4VAci0j+uf7MNJinZ4aMyY8cv?= =?Windows-1252?Q?x2RlnkW/u9prgESXrI0KKyABRhCo2n4qob8pDuQvnBEFsDQOQon5bQuC?= =?Windows-1252?Q?4jSCWxvvHWiwWBKiDfCIx5U8h5ahpEgdjN4hONKxi7bvePjn6tPmIuHW?= =?Windows-1252?Q?3u652s7iz742J956L+M0KUi33BBXY0uhi3hGaa97WKxEoyIYmbEUWkIU?= =?Windows-1252?Q?S55selof8HFU99TRL0zVX+4QHY8DnzJaxWfN4pY8EMa57BojSck=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64e8f361-c9b7-47d9-2358-08d88fc40870 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2020 15:25:38.8605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 891I2gRRGRzJAEX69Pk+ve2zGrwOXkq/zD6QudgNlj0XvjytjM7dAH9K/v1rBrVCxkvpMI4l85nfnF2C/YdnAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4272 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v21.02 v3 09/10] app/crypto-perf: remove always true condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, November 19, 2020 11:59 AM > To: dev@dpdk.org; Doherty, Declan ; Kerlin, > Marcin ; Mrozowicz, SlawomirX > ; Kobylinski, Michal > ; Piotr Azarewicz > > Cc: Yigit, Ferruh ; stable@dpdk.org > Subject: [dpdk-dev] [v21.02 v3 09/10] app/crypto-perf: remove always true > condition >=20 > This is already 'else' leg of the opposite comparison, simple 'else' > will be logically same. >=20 > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > application") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > app/test-crypto-perf/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c > index 5f035519c3..99f86e9019 100644 > --- a/app/test-crypto-perf/main.c > +++ b/app/test-crypto-perf/main.c > @@ -390,7 +390,7 @@ cperf_check_test_vector(struct cperf_options *opts, > if (opts->cipher_algo =3D=3D RTE_CRYPTO_CIPHER_NULL) { > if (test_vec->plaintext.data =3D=3D NULL) > return -1; > - } else if (opts->cipher_algo !=3D RTE_CRYPTO_CIPHER_NULL) { > + } else { > if (test_vec->plaintext.data =3D=3D NULL) > return -1; > if (test_vec->plaintext.length < opts- > >max_buffer_size) > @@ -440,7 +440,7 @@ cperf_check_test_vector(struct cperf_options *opts, > return -1; > if (test_vec->plaintext.length < opts- > >max_buffer_size) > return -1; > - } else if (opts->cipher_algo !=3D RTE_CRYPTO_CIPHER_NULL) { > + } else { > if (test_vec->plaintext.data =3D=3D NULL) > return -1; > if (test_vec->plaintext.length < opts- > >max_buffer_size) > -- > 2.26.2 Thanks Ferruh! Acked-by: Fan Zhang