From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3F25A04B5; Wed, 16 Sep 2020 20:39:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FFB81D171; Wed, 16 Sep 2020 20:39:22 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 257661D16D for ; Wed, 16 Sep 2020 20:39:20 +0200 (CEST) IronPort-SDR: fuy+ZM+MOcDuUJXT+PexQgfcQs5BhtQYdNaGcv9G6xcOFgpgZBYAqV6W1gOpG99iPbk4Bk9jSz 6EaE+an4iP4g== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="147295640" X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="147295640" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 11:39:20 -0700 IronPort-SDR: cx5Ikhl6+rgQiANIelljKo9k6Euzhzf9KYREqkS7TCAlwRTCu2JxvYK2fyWl58AKPe1uB52gMx Ybhp538wGnVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="508105823" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 16 Sep 2020 11:39:19 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 11:39:19 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 11:39:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Sep 2020 11:39:18 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Sep 2020 11:39:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FkiWevVdSJ/M9YLRLxJ2nNIjBZq1b1+xbKTuUUsnWdUsTr/CZkSdIdb2w6dBlx3pG3kIXZb50j2WAaLzDa8noYwek2/W92gxkSwCh9Cb5astcZgU7OzMYv6CBqnLyFbjipikpwcHjIfjzC7p7RHcM3q71zTuv+LM6ZwfN9hZWEHbHsBvU/JJgXtPJ010+c9GYHKK/HkKTV8aS8X7dBWHptq5ed9ZKFNe7op3UH1ivlQnuyxzREF6SjjZFOKSbLP5VS6tu9TShHtOBBCf3sjxtIOek5lQsH9p/b0MkvmUA1k4dezDD9WhVw8RkRoKCQ0BJiPcC6+kIapnG00inRS7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ImaOQjOg66+jtSOUO7CWNffEHOH8mnVVKlErbho6IbI=; b=TjQxWIgmgWvnaeJNFQhpcETgT3gJ1WQJ+U2ScXczBLXXaYH+7kfqHgzOG5e820uKRrXjKch+VFpIBg2VjYk7X16pJSWdCyJvakAWEp1cTarYms/6zLSXbma4o/iwlBLrQgEQzZkbmL5oEUy5IbbwTKX3tQ9l22uoO0G6Ajrghps8she2YxvG5qyOMLQBeWT2t/BApA5daiVAwCoKBMB32UhvZejWSaBje2oQ2uFFLSi+RFJcqFXo3WY8c/oUCMw/vUzXRH6XG3lioDzH9RyIOSljZ4ShMiAfb/+TgBgUf5bXEOQtLw0hgspwUwkrFMU+vyM7r+tE5eMCG7bwVX8mJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ImaOQjOg66+jtSOUO7CWNffEHOH8mnVVKlErbho6IbI=; b=Panspfh3X83Yspggnf/kAwc8agqafu0/+2U5cIdO3zV8lkUQ3ujqoQHNCx7Pk641ylJbXzl9DRM1X7YeK5nZo0CWWpGz8vmDEMle/Ng7/+RVGnB4SppQCzw9EZt77xXygpEunzvkOHjTCGEQzBvObGV1PfgQtL9PvDtofd0fboY= Received: from BL0PR11MB3090.namprd11.prod.outlook.com (2603:10b6:208:74::23) by BL0PR11MB2900.namprd11.prod.outlook.com (2603:10b6:208:31::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Wed, 16 Sep 2020 18:39:15 +0000 Received: from BL0PR11MB3090.namprd11.prod.outlook.com ([fe80::15ea:2c05:dd2e:7d33]) by BL0PR11MB3090.namprd11.prod.outlook.com ([fe80::15ea:2c05:dd2e:7d33%5]) with mapi id 15.20.3370.019; Wed, 16 Sep 2020 18:39:15 +0000 From: "McDaniel, Timothy" To: "Eads, Gage" , Jerin Jacob CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" Thread-Topic: [PATCH] eventdev: add PCI probe named convenience function Thread-Index: AQHWiF4gMmRJ1Be1LUiVu9Vr5xHbf6lokgLQgAMOYpA= Date: Wed, 16 Sep 2020 18:39:15 +0000 Message-ID: References: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7837ec4a-7107-4ce0-acd4-08d85a6fd079 x-ms-traffictypediagnostic: BL0PR11MB2900: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KYNIAGwsi3KNGFzpXhi/MrJehFUZGZMfmmagtibqVEHhacy7fQVFw8UOuN6sx3tgFUWjqabnwMelxgMb1fRjqACVNNykBIYBG87GPnDZXFUdxetL2fXOSz1T7LH56TxyQ1NYGI2aW+7gS8yt4zAP0V5e3idmCGOkQ58ZLtENuqxSADhCUOskoBeUipdN+ErwjpruTcsllR6ew4h2PwOHWo/UKTrGVl1AgVNnnO+UAjNO2qe3+LIK4phfEyEBT+TWSprRGSgFtRQsadeXxaflx+n8LsZgBJykTXDhbYKQ580A5tEG0AhNPrpLJXaE2nhq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3090.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(2906002)(53546011)(66946007)(66556008)(66476007)(64756008)(66446008)(6506007)(8936002)(5660300002)(8676002)(7696005)(71200400001)(33656002)(107886003)(52536014)(4326008)(55016002)(186003)(76116006)(478600001)(83380400001)(316002)(9686003)(26005)(110136005)(86362001)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8wAHE3sjBQ9LilALI0GW7EPIFBEZDO7ZeZyGX/GBf1afMynkUk5MeajcRg56jSyHhWtC6IPyF/CQLSBn1v/tpq5IdT7GOLzGhXuMcqbcAX12xbe+olGSDqjF5tPUvx6WjEeuTFg8umF0KY2t/HwMn4Mkvx74qyipMKPNOxfKz+gY4+dmiDF1ExANgdgyAl3x2o58L/n57bq11v+mb00LJrN5c8S8J6BNKZnhMZKPo3VuKtkYgtsT+M8fT3J+xZHnQb7Th2wbkdC5gR0PbbN1F+uwB0h+88R65XVZ4rxqoY2hYJ/GJRbgIU5IAZBYxzW48eeUfA57XU/CkbmSUUllzuKqEGL6+JDygYtb6B1DPNhIvdmRvUSiRjnAgVQuIUyi0TI3tf62rthqz8fYGXwjQB8BU1s5v2d0y0L6de8IY3lWfuG6a8phyICvpa6ejR56EmtVLtnhBCXZOtdA9NsSdaLZvcNCKro57Was1CnysNsACJlLmFNRhgl3EjLzz55DoAb0IVN3izyDZdONiDaPm/U0lbAgaQAHdulsijd8ac2Vm8DInTqtWemVNx9Out5bvZJhZgkzaCBL2DIjIV4hHTBaMm3mNJrUncRLDXehK0O/zDqfHACkBQHldSoaNNBE/Rq/74k9UXPpocDalUfeSg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3090.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7837ec4a-7107-4ce0-acd4-08d85a6fd079 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2020 18:39:15.6041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zFinAkkcnp6dWbyBubuysy3uRqjjLhhqiAkQ926fy1aMMk2h9Sg9+w+5PsVnUcQiRSTkza/ebM6duw6A3zGIxZTT+uOy/fkQwZGFWBGMGIY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2900 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Eads, Gage > Sent: Monday, September 14, 2020 3:23 PM > To: McDaniel, Timothy ; Jerin Jacob > > Cc: dev@dpdk.org; Carrillo, Erik G ; Van Haare= n, > Harry > Subject: RE: [PATCH] eventdev: add PCI probe named convenience function >=20 > >=20 > > /** > > * @internal > > + * Wrapper for use by pci drivers as a .probe function to attach to a = event > > + * interface. > > + */ > > +static inline int > > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > > + struct rte_pci_device *pci_dev, > > + size_t private_data_size, > > + eventdev_pmd_pci_callback_t devinit) > > +{ > > + char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; > > + > > + >=20 > Two blank lines -- DPDK coding style doesn't forbid this as far as I know > (LINE_SPACING is ignored in checkpatch), but just an FYI in case this was > unintentional. Fixed. Will be available in V2 patch-set. >=20 > > + rte_pci_device_name(&pci_dev->addr, eventdev_name, > > + sizeof(eventdev_name)); > > + > > + return rte_event_pmd_pci_probe_named(pci_drv, > > + pci_dev, > > + private_data_size, > > + devinit, > > + (const char *)eventdev_name); >=20 > Nit: the cast is unnecessary, the conversion will happen implicitly witho= ut it. >=20 Fixed. Will be available in V2 patch-set. > With that, > Reviewed-by: Gage Eads