From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81568A0540; Thu, 16 Jul 2020 05:02:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF52C1BE95; Thu, 16 Jul 2020 05:02:01 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2AA904C7B for ; Thu, 16 Jul 2020 05:01:59 +0200 (CEST) IronPort-SDR: 3i0V5Q1/8gTHIfVvLNCYPFuP76G6ImZoYFFPTXxp5DJAO2wKLv0X4BzXIykZHKOqcmg+14SnyG DRuKERr6Pozg== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="146822386" X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="146822386" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 20:01:59 -0700 IronPort-SDR: Ojyjq11Q4v/qbaZ5REHcV8OrMxG5RNbtDP7yMXtsSzrAUfdkkB/yUMWqrW7uAqtLHmeJdAcO+1 b/8pdzv8pAHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="269130201" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 15 Jul 2020 20:01:59 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 20:01:58 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 20:01:58 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 20:01:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFuNa6botLt3bJhSXr0XJX3IHfSFK/vB+6eGjKTYtnsgTaOBAMoVhcF/CSOaGvMwA37oBPu/ArxmFYhr+/oxudyp0OXVsWju/JHAVwow9OECSALRkMQdQpxYQ51DCOU8u+0b8cluFKlo/+1wEIz2hwYrQ2ND6/pvYXOLe8KQ1iQ8v0uDRbY171mpUkfh7Ugpdgi6due8ky1lLI8o7+XyhjOS8JV07LDND3SqOEQPeE/xbJHTBH9yL/9LXnqfigBY/J9x+inA86WhSmHPBqrgepY1Eo2G1nXhqvT2u95upJsatiisqcZ0hp0tbWCedRBtMJZyFOZxo6Kre62zFu7z6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OVa1w4nFweGkKrzyQ/+LqgOcnpLBpenrF2gc652v3Xc=; b=RXcQmvufPjYfK6bXOwSG6UbzePmfXwz2/E3yflSbgTlEeFnZU8X+Jragb/h8S3NWwFFV7oopWpLGtae46jdYwcLK1xA/i/JHbuwPgSUCW0vL7g2/D2GsqEALl4QyjGyOnwA1U5ogvKVD1h+bd+6G9MQqT/bcT0/THVUEL9uECvnoIRtZwTti5fP15yH0xRqmXYWOH8bk3DdqLpzcT+iSyTpyPDYv/BebuwjuMdkehb7QCBA/RCjwBGyou93iW4AdqLjrMpZjqPS8CIsAJlg4IF1AP7RSOwVEHm3tCSuiD8iYnwqNenDIOOyLswFRo9AfdlEZ62Dr53F10qhGqoR4oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OVa1w4nFweGkKrzyQ/+LqgOcnpLBpenrF2gc652v3Xc=; b=q0tZJVAbeRZ2Ihlo5Ulgd1GQ9BDQ5niqYp6Qu1ncpHLp96sJX1i2v30ZatByB+wsrTD3Sxmg5XQbKWUhh80nz99zv9Lf/U43dr6W1wIknJ9uxaTLQtWVfiAcRqJXehKIM+1RRUKjkw8aczJGaY6PSVyozzfVZLBprhVElAR3gqI= Received: from BL0PR11MB3380.namprd11.prod.outlook.com (2603:10b6:208:69::12) by BL0PR11MB3091.namprd11.prod.outlook.com (2603:10b6:208:7f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Thu, 16 Jul 2020 03:01:56 +0000 Received: from BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::71fd:6797:4389:da64]) by BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::71fd:6797:4389:da64%2]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 03:01:56 +0000 From: "Su, Simei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Guo, Junfeng" , "Guo, Jia" , "Xu, Ting" Thread-Topic: [PATCH v4] net/ice: fix invalid RSS type Thread-Index: AQHWWpLCGQEUkToLoEO2YaMDHWZbTakIrv0AgADV6ZA= Date: Thu, 16 Jul 2020 03:01:56 +0000 Message-ID: References: <1594476064-366701-1-git-send-email-simei.su@intel.com> <1594808751-138882-1-git-send-email-simei.su@intel.com> <039ED4275CED7440929022BC67E706115485D6EC@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115485D6EC@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.199] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d381744e-4c80-4841-eaef-08d8293499d2 x-ms-traffictypediagnostic: BL0PR11MB3091: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qZ/ApJwdxwa/on2SvZAjkkdDjmoa/QDeKxOcqgSfqa0zmIjr+zgaSnCdS0aXtcahslAOyqt+BfmQizK9Wwujm2m5Y1c3CZwfKV2NxTWnaD/1Yl6fEeT7OxRsOcZHO7D3mx70KF31YHpS/j7ppd6Tv/Udkmrxe3v2Z2nz9wzDuFPtYEAeTtU2VwMq74zb7omeHLMXq1DJo7U1QnLY9mTeLetJEKwRkw4KRTOKXCQ4lM7LjyxLCsy2t2hrZcxb0IvMgXQh3VmVhQ/FD6Zyk6uO2n31tXCV5wkFO+6kEcEPP6fGXW2DtcW6M4M9b5Vyd8ctN58naE7jxYKs7s4wrVXQGA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3380.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(83380400001)(26005)(86362001)(8676002)(6862004)(316002)(54906003)(4326008)(2906002)(186003)(478600001)(7696005)(71200400001)(107886003)(33656002)(66476007)(76116006)(66446008)(6506007)(55016002)(6636002)(5660300002)(52536014)(53546011)(66946007)(64756008)(8936002)(66556008)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: g9EvpI+fMZ7n2nIDWt+5ZZXEOe2RTNQYt2eEOXyYpho4LtILB2KbQKtxf0ERlJBdy9C+ogMLXv+1UqJNeXSTSKYlHAKjBPZLiuK94M1hd/MOZRzZsV61hSGCFNAiPfxYqKsVUZm7u/2yUy08S8yHyej/RCovgNuB1C6bVagmLCWe1nzG20e5ku4wSWJ3ndAYw9LqK4k00UWKAejM3zAss9wvnZa2CcbS0PrQL02CY638HwPpCVXecfwfUIF+mVVhChvbrWyPHHQv+VfwCf1/DrdFcBOq43lcAAFGP8qbqJgd2VIy4sQUUpCe2kVmZ+D1eiH494KY/FuI0Px+1mC4jskkBESJdo+xSkrHqXf+hqS5WvJA5cs8aFNUQr/Iyq2FmNL4gzYe3RtH6WfuJrusxf8hQYggeVdYFJRD8B16DED9JGWFpMFYOzhSJSuljdVc1J9akhaUE0vMUKzFRgacocAmpTQMSKYD7xekjLrP2I2m6CbW+uS4sTHpNsKoX/UT Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3380.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d381744e-4c80-4841-eaef-08d8293499d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 03:01:56.7650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VD0WJH2sa+xISLwD9TELflIIz48MrCXLKk1ozupJ2HMhlfwdOsiEwbpdtqedgxrUtaozbYe1EP2bgJo2tt2DCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3091 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/ice: fix invalid RSS type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Qi > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, July 15, 2020 10:13 PM > To: Su, Simei > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > ; Xu, Ting > Subject: RE: [PATCH v4] net/ice: fix invalid RSS type >=20 >=20 >=20 > > -----Original Message----- > > From: Su, Simei > > Sent: Wednesday, July 15, 2020 6:26 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > > ; Xu, Ting ; Su, Simei > > > > Subject: [PATCH v4] net/ice: fix invalid RSS type > > > > When a RSS rule with only SRC/DST_ONLY or IPV6 prefix RSS type, it > > should return failure. Besides, when a RSS rule with symmetric hash > > function, the RSS type shouldn't carry with SRC/DST_ONLY. > > This patch adds invalid RSS type check for the two cases. > > > > Fixes: dfdc589f6ee0 ("net/ice: refactor PF hash flow") > > > > Signed-off-by: Simei Su >=20 > > --- > > > > v4: > > * Modify check logic for symmetric case. > > > > v3: > > * Add invalid RSS type check for symmetric case. > > * Consider IPV6 prefix. > > * Refine commit log. > > > > v2: > > * Add specific macro value in check rather than hard code. > > --- > > drivers/net/ice/ice_hash.c | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c > > index e57feff..009ea1f 100644 > > --- a/drivers/net/ice/ice_hash.c > > +++ b/drivers/net/ice/ice_hash.c > > @@ -1049,13 +1049,41 @@ struct ice_hash_match_type > > ice_hash_type_list[] =3D { > > combine_type =3D ETH_RSS_L2_SRC_ONLY | > > ETH_RSS_L2_DST_ONLY | > > RTE_ETH_RSS_L3_PRE32 | > > + RTE_ETH_RSS_L3_PRE40 | > > RTE_ETH_RSS_L3_PRE48 | > > + RTE_ETH_RSS_L3_PRE56 | > > RTE_ETH_RSS_L3_PRE64 | > > + RTE_ETH_RSS_L3_PRE96 | > > ETH_RSS_L3_SRC_ONLY | > > ETH_RSS_L3_DST_ONLY | > > ETH_RSS_L4_SRC_ONLY | > > ETH_RSS_L4_DST_ONLY; >=20 > Do we support 48, 56 and 96? Will they already be rejected during previo= us > check? We only support 32, 48 and 64 currently. >=20 > Better to refactor the code to avoid duplicate, for example: >=20 > rss_attr_src_dst =3D ETH_RSS_L2_DST_ONLY | ETH_RSS_L2_SRC_ONLY.... >=20 > rss_attr_l3_pre =3D ETH_RSS_L3_PRE32 | PRE_40 | ... >=20 > rss_attr_all =3D rss_attr_v6_prefix | rss_attr_src_dst >=20 =20 Ok, I will refine it. Thanks. Br Simei >=20 > > > > + /* Check if only SRC/DST_ONLY or ipv6 prefix exists. */ > > + if ((rss_type & ~combine_type) =3D=3D 0) > > + return rte_flow_error_set(error, ENOTSUP, > > + RTE_FLOW_ERROR_TYPE_ACTION, action, > > + "invalid rss types"); > > + > > + /** > > + * Check if SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ > > + * hash function. > > + */ > > + if (rss->func =3D=3D > > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) { > > + if (rss_type & (ETH_RSS_L2_SRC_ONLY | > > + ETH_RSS_L2_DST_ONLY | > > + ETH_RSS_L3_SRC_ONLY | > > + ETH_RSS_L3_DST_ONLY | > > + ETH_RSS_L4_SRC_ONLY | > > + ETH_RSS_L4_DST_ONLY)) > > + return rte_flow_error_set(error, > > + ENOTSUP, > > + RTE_FLOW_ERROR_TYPE_ACTION, > > + action, > > + "invalid rss types"); > > + } > > + > > /* Check if rss types match pattern. */ > > if (rss_type & ~combine_type & ~m->eth_rss_hint) { > > return rte_flow_error_set(error, > > -- > > 1.8.3.1 >=20