From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8960DA04B6; Tue, 13 Oct 2020 01:08:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0679D1D9EC; Tue, 13 Oct 2020 01:08:51 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 216931D9D5 for ; Tue, 13 Oct 2020 01:08:49 +0200 (CEST) IronPort-SDR: u9pVU+tQ/TQhyUBWsFqiOUzPBAEOJNKOEIE7kxVD83yEdfxJDz93BxS6Wchj/KQk8R0MJzKlLE lHKON7pl5ygw== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="229996215" X-IronPort-AV: E=Sophos;i="5.77,368,1596524400"; d="scan'208";a="229996215" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 16:08:46 -0700 IronPort-SDR: +ZPXMvdZouAu+0plr7b4pmt1UxACOPDW/iMx7zUROxHxC2xvSk0bamWd7SVK+OjdOofsA7d45n drSx4XiRwV5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,368,1596524400"; d="scan'208";a="463267839" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 12 Oct 2020 16:08:46 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 12 Oct 2020 16:08:46 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 12 Oct 2020 16:08:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 12 Oct 2020 16:08:44 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 12 Oct 2020 16:08:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H36LcljkTc6Oyn1kl58Q5NmuI3Rk1+J3NT3psXqKvmwni8YTtaYM5hdXLvgXAGw5Slgt2K0iLmLnXpYgc7K3qwdUc1iDYjxwZH9IBGK5xKqkLz4H65WmxMgihWi3f1RxV/Yj74PZkqWaGkd6N08rjEc9AC/qESltKCDeKxNVZwALZqVHWg4/H1Sox0MadQXAuyTP8CLa611zexhsxqjQlJiDa/tu7dGBeGMftxwxtfHUbbWX0XavGUqi2QDhbvoiVkZFGNO/rNoOhtDhRhUJlDfJDCehCkdy7Pd11IDBOF41PhR9UWo84IUZUlazk4Jse0hn20alS16RZwxoBc7IVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wfXzXs/nyDpFIvpylbe/Stg++3vfgJOEzdYhs6u6m2M=; b=YAW0Izmk+RZtSJFFAfKQ/bmrtZ9gdEdbKW9JQOda97Ckt8/oOo/Bsp/0RZfxiJrj5HxAP8tkBGP5xmLaQ8gONmhqtNjw35QTegNWh8fPTgziqJH/3B5gy9LwjzR38/Z6U83ddwLZ02RZ1RDIctNqNSOhigs9J3qyWBKu4B0GY9cIKUenFVHMvEr96zZ5Y+58U1qeVbZ9MNUD9tI/3TKrNqGE6rnJi52ohEAiGeY6WE0FPUfZ+YTTkERAtpSa8dSPQ7K+Ax8dyx1aRITr7ileks+QtAo/VrCjaIYOFDBXs4kAFefkhoQwlk0iQbRAq9eeF5BspN7ZoOvH4T0Khtn8Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wfXzXs/nyDpFIvpylbe/Stg++3vfgJOEzdYhs6u6m2M=; b=SbnyzEQB9dhoNr+CkTJ0fCbfOHdtxkNRNe07d+TgLn3w1KvS72jhkkvBs9kaGV6vaBPekvLK5KjNpDpgD4youpqX6re10wy1cHkFikn4Nfw5PB9IFW6JpV6kW+wXjPnDuyV85WoEVY7UGzkGZnAtG/LsLudKFgawP7EVc2PH8HI= Received: from BL0PR11MB3491.namprd11.prod.outlook.com (20.177.206.222) by MN2PR11MB4664.namprd11.prod.outlook.com (20.180.247.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Mon, 12 Oct 2020 23:08:41 +0000 Received: from BL0PR11MB3491.namprd11.prod.outlook.com ([fe80::25c1:67a8:6be7:f013]) by BL0PR11MB3491.namprd11.prod.outlook.com ([fe80::25c1:67a8:6be7:f013%7]) with mapi id 15.20.3455.030; Mon, 12 Oct 2020 23:08:41 +0000 From: "Dharmappa, Savinay" To: Thomas Monjalon CC: "Dumitrescu, Cristian" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth Thread-Index: AQHWnjlBs1quDlhLm0y6BIhNFWjO56mS2QUAgACZfrCAASlnMA== Date: Mon, 12 Oct 2020 23:08:40 +0000 Message-ID: References: <20201007140915.19491-1-savinay.dharmappa@intel.com> <20201009123919.43004-1-savinay.dharmappa@intel.com> <1771845.gd1I6FXUA8@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [122.171.228.248] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e845a0b-1d0d-4c4d-c405-08d86f03c269 x-ms-traffictypediagnostic: MN2PR11MB4664: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rgn0jJ0UGXRxOgl7rXPilwBJHkiNY0BxJtK4geCirdBUPrCsW0GRaTaDg3TKCR2jFwbApnIPeYikQOtJHyzfmk2rI56y+E9+dgcz4PDi/otGW4yJuHGOXkf7oRth3lo7FDkWR1prvzoxHm/Vd9t4GqgUINWlQ6Ex7QuxEfog6692ib6nt8xVUtnxNjOGjqK9/Z9YZWtuBRq96/7eIEpCBB0Wt012WhPRdY354iWqirgN53wb7nPFiVFR+1YJCcXO9PeIIrigPaJRefr52occSA59vw8kdFRzI0Ks/SbmyTkThHR6bzHzVp52QEJ299W5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(71200400001)(6506007)(86362001)(76116006)(4326008)(9686003)(66446008)(64756008)(66556008)(66946007)(5660300002)(55016002)(2940100002)(8676002)(26005)(66476007)(8936002)(2906002)(52536014)(186003)(478600001)(83380400001)(316002)(66574015)(6916009)(33656002)(54906003)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 66Pf+K7Q5JITc/wd2jMI0voqKakyaTAD8niZ766XUPV3bG4L7ZydJ5Dg6qeQjB8wx3ZjC7pjshcU+iQjGIBJAkfJfmkeSdnW09prmXM6gUj4zaFV4pw8KFuQzrbg/C0ayziFLoY4NPl2Rko8v4f/8wJDZfzMia4SvAAgBnz+IQ/gG4M8JkCS+OBPjRcPlKSHIx/Y7pfSqnrAHgXj+lundwtNlY0EV9utf7OCHGwJwYo9JEJ+OW+ZoxlSFcmLvpLep0/y3EEP+JP8E1YPOElN2WljqOb2vuWCi9r9tX+JzSrge5AMrRjgcr0TTcRl4RHxFKVPWXlqC9ZAtR+4jt5F9V71LzLOocoq+TteLl1XDhT37dnsCsuzyY89A281dcmmBtQl6l6t8raAGB/ojsz6xyDc5gNF+Eyg8LpTn5WEscfm9JV7ER2l3tT8E95xaQYj8uE5SA1sCZpOJPN3AUfE7sPSLFgfzQyq3tqPth9WQYKuFw3EQ74UeRJRsw1GGIFInV6lWEfyNLzQONnQ73A3eJhYjGaDS9/qo6glfE5l7Z4dhGzsFrC+KH8Tt+ODO7eyobRRy0pVph2SOGbicbJlij3l4S3ebFKeJgmpyRjkR6A5LBqsGHKJU17TR1/QvxUPcRY4T5S//NO/bhYBt4ZSyg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e845a0b-1d0d-4c4d-c405-08d86f03c269 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 23:08:40.9182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 05gP8/OxHfHhreyTQXY6GkxGZspzv9L8e/ONH9CrRJ52NzwGKZbOgug6yDIbmMgYTk/asFTqjXL8QDeJ+uMEYurz92XiaUu+ssI4w8UkKCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4664 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2020 14:39, Savinay Dharmappa: > DPDK sched library allows runtime configuration of the pipe profiles=20 > to the pipes of the subport once scheduler hierarchy is constructed. > However, to change the subport level bandwidth, existing hierarchy=20 > needs to be dismantled and whole process of building hierarchy under=20 > subport nodes needs to be repeated which might result in router=20 > downtime. Furthermore, due to lack of dynamic configuration of the=20 > subport bandwidth profile configuration (shaper and Traffic class=20 > rates), the user application is unable to dynamically re-distribute=20 > the excess-bandwidth of one subport among other subports in the=20 > scheduler hierarchy. Therefore, it is also not possible to adjust the=20 > subport bandwidth profile in sync with dynamic changes in pipe=20 > profiles of subscribers who want to consume higher bandwidth opportunisti= cally. >=20 > This patch series implements dynamic configuration of the subport=20 > bandwidth profile to overcome the runtime situation when group of=20 > subscribers are not using the allotted bandwidth and dynamic bandwidth=20 > re-distribution is needed the without making any structural changes in th= e hierarchy. >=20 > The implementation work includes refactoring the existing api and data=20 > structures defined for port and subport level, new APIs for adding=20 > subport level bandwidth profiles that can be used in runtime. >=20 > --- > v8 -> v9 > - updated ABI section in release notes. > - Addressed review comments from patch 8 > of v8. I was asking a question in my reply to v8 but you didn't hit the "reply" bu= tton. >> sorry for that. All the question raised by you were relevant so I addres= sed them and sent out v9.=20 One more question: why don't you keep the ack given by Cristian in v7? >> I am carrying ack given Cristian in v9, but It is at the bottom of cover= letter. >> should I resend the patch placing ack just before version changes inf= o?