From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E53F5A04B7; Tue, 13 Oct 2020 16:01:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DDAA1DBB0; Tue, 13 Oct 2020 15:56:28 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2253F1D53A for ; Tue, 13 Oct 2020 15:56:26 +0200 (CEST) IronPort-SDR: zGkBDy0RSJY9iXotKBgoI4orvz1+8fyRBG1kSCkcWeVsJlxwLkDARBNGIqw+zUsGKItlJJWJ87 HUHm53VBOM8g== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="163273572" X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="163273572" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 06:56:25 -0700 IronPort-SDR: HHYhUus44iuXVwGNs/j7ubOZ7lHWqBqA5XA1DquDL1NczOcJZfeVKGUpDCQkF9fP3wA+xa9Dw6 r1qN58EfYgaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="420536289" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2020 06:56:25 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 13 Oct 2020 06:56:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 13 Oct 2020 06:56:24 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 13 Oct 2020 06:56:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GCPs0spTHBzbE/JJ1bkmPSM4rL3f5Z1Jb5siSVq5j4DtSH7XrUs0l1KObj4/T0/WkEzcPy+mmp66l+W4MsERrsyz16gh8Hhw+VsmP6jc+LRgimlSl9bMY1lFoM0ZWschmcRaS5Of139eqfK6Ch7UxYo2Ub1CLCJ/h6Bhb/X955LuWeLfq8YbFKB4dWO7I8/VRdPIOsc9J45WoajAHmEY1vo7Fw5YYJhKLLk2M1AOyHICrF4mUoLixXuBPVYSpIaYAqixHPBmoZ19cWoT4zRA0fr2Vq5Fpum21LwGUOS0gHUEpZU4jn6vDOq+FH4KVyM/RTFC8+Bj2DkO9wGyj3XKZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v79kYM5MezmKJnMQWHP0ufC27OIrjKDVPy3QPxfAie8=; b=nad4IhwWrAgUDUS5H0Q7vmpEGP76hPhkI1fc0nHNGuPbPFRudPoA4q7mwVyDmW7dDn2YiSRBOTHUEDTWB1mLaxHdgEErT0cAvtl9pQS3ed+Ki3tyuplZPnQrFAAXXSGAv7bGfLDFAtPcKliEQJ98PpumPXWwOVMy2g0WLHqneXCNUffhemwt5PAjsgg7vJIakFjB4bW6W1V4Y4MwtUiGTCn8MbdOIPOneM18Nw+LuVd5Ttre4SMKogF7/QMg84nStR5JUASzE/qQJS/WpmAJZ8fTnADUpuNFoixFK3f2OAPK5mrJFNNan3pZK4OJv4BvKU64r5zQrLCMv3zhIUa1hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v79kYM5MezmKJnMQWHP0ufC27OIrjKDVPy3QPxfAie8=; b=bmbnTDupbUAJPM3oOAHc5dC7WrrlLNQlvYRBU8Q3eBgoWNnlnTgSVWoVpI7v3iZea/yKpblGqVGiTJNCxkqy3qAGtJcdS6TM6AhaOQdcpTdOM1ChUyDapyRE5Ot1zxfChN7meEvQ8IXdJUDGO2pHeW7iv0uY3O54u7fqsw0VYsA= Received: from BL0PR11MB3491.namprd11.prod.outlook.com (2603:10b6:208:33::30) by BL0PR11MB3474.namprd11.prod.outlook.com (2603:10b6:208:67::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.24; Tue, 13 Oct 2020 13:56:21 +0000 Received: from BL0PR11MB3491.namprd11.prod.outlook.com ([fe80::25c1:67a8:6be7:f013]) by BL0PR11MB3491.namprd11.prod.outlook.com ([fe80::25c1:67a8:6be7:f013%7]) with mapi id 15.20.3477.020; Tue, 13 Oct 2020 13:56:21 +0000 From: "Dharmappa, Savinay" To: Thomas Monjalon CC: "Dumitrescu, Cristian" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth Thread-Index: AQHWnjlBs1quDlhLm0y6BIhNFWjO56mS2QUAgACZfrCAASlnMIAA+Ekw Date: Tue, 13 Oct 2020 13:56:21 +0000 Message-ID: References: <20201007140915.19491-1-savinay.dharmappa@intel.com> <20201009123919.43004-1-savinay.dharmappa@intel.com> <1771845.gd1I6FXUA8@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [122.171.127.33] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2aa988f-93cb-4fce-ae3f-08d86f7fc42e x-ms-traffictypediagnostic: BL0PR11MB3474: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wECrVn+wK/Sx0zuxwp92LF6opiYQEIBNOHNQ4C8UMpFGa3q/RrCWuL73tLjM6Y5VYhCdo5c2ntQmDGyU2EaAc30WlrIJ656iLzSYNZT3QaOf38E9G2j4LLntZ3wcZuXJpbPuz+AP19qXkNT33tSehqGmziZt/N3NshFur6m5gbujbkkjKq9yXm4S2l5apbfxRWFdfUhGlBtOi3TNxLwIe1DD/lfF6lTA7aJU2LCJIzyfNXbnYJtWf0xEQOEabjrE7nsajnaWuR7pjiyc9VkQtSs/Ehqyjoyyit26SEMw77cghWC/D5+wsQ3i8Hj56n2V x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(346002)(39860400002)(376002)(186003)(64756008)(316002)(54906003)(66476007)(26005)(55016002)(7696005)(6916009)(71200400001)(66946007)(76116006)(66556008)(5660300002)(8936002)(66446008)(52536014)(4326008)(83380400001)(53546011)(2906002)(66574015)(6506007)(478600001)(8676002)(86362001)(9686003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: wie2aGVsVPwa05a+OiQl8Rpi6+9K7U5jcDEHiwcwmKm5w/073GRwnOqGxZsKNFl0E1TA6qU5ePllu/gDllT/W91e41ig6PsacE6Cnoy3+gxrt0J9huJCjpxoGw00+gwCK5HFGn4os3ep7oaz+YOLVqFghfAUq0W1pBAqoDSgUY6vQB6vi/4MK5snVgHECJlI6wojeQgBfAtgKGG+D9uhCS1AdiamfS57CTK8A2X2bPHwzsX/RCzsuGpCILNCDkLjmUIfJNt5P115QacgV83WFpTCdSo4BTgqvhK0+4y5Ha0IV6haMpAMuvq36+PNS0lsXP9Euj2qE6QL3c0/vN4tRcJB6Mi5DCrePwGsV1RdYrUefpUAWzFmY6ClTGxfpoM/dM+8uY0ehCZTh5mvpXzNyusBkx0t7GoioNzKd90H34uSl0vQ5YetOiU/MNxYyrTJ3Hkkm3DbwH2XLUZFJHDn4a/6HiJcdUnRLpJCV9x2/9NKlw3oouT1dwir+ilyoUDr8kYekLd0ZSSfbxZKLjdtwW2XzsgMGDK0WdXn1Bh9U+FTbl6pTIbsMkJCPmD+SoWjw0sm117RV5ucq/pIT4418ThUnQxNkw4KPWlhGFegpM7EeXWMCP0YFDj/k3GYP5VvFG5vkrJKsBLrvsbHPfM4OA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2aa988f-93cb-4fce-ae3f-08d86f7fc42e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2020 13:56:21.5148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Y2H67521BFCAs2wCL7a1vq3IpqXiHbMFJIbLWN/paOwJ9w4RAEUFGCJVf3obDD8Pnh9pi5ymXzMYd/5I8it62YPZX2MzaY076+XV4ycZE0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3474 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Dharmappa, Savinay=20 Sent: Tuesday, October 13, 2020 4:39 AM To: 'Thomas Monjalon' Cc: Dumitrescu, Cristian ; Singh, Jasvinder = ; 'dev@dpdk.org' Subject: RE: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport ban= dwidth 09/10/2020 14:39, Savinay Dharmappa: > DPDK sched library allows runtime configuration of the pipe profiles=20 > to the pipes of the subport once scheduler hierarchy is constructed. > However, to change the subport level bandwidth, existing hierarchy=20 > needs to be dismantled and whole process of building hierarchy under=20 > subport nodes needs to be repeated which might result in router=20 > downtime. Furthermore, due to lack of dynamic configuration of the=20 > subport bandwidth profile configuration (shaper and Traffic class=20 > rates), the user application is unable to dynamically re-distribute=20 > the excess-bandwidth of one subport among other subports in the=20 > scheduler hierarchy. Therefore, it is also not possible to adjust the=20 > subport bandwidth profile in sync with dynamic changes in pipe=20 > profiles of subscribers who want to consume higher bandwidth opportunisti= cally. >=20 > This patch series implements dynamic configuration of the subport=20 > bandwidth profile to overcome the runtime situation when group of=20 > subscribers are not using the allotted bandwidth and dynamic bandwidth=20 > re-distribution is needed the without making any structural changes in th= e hierarchy. >=20 > The implementation work includes refactoring the existing api and data=20 > structures defined for port and subport level, new APIs for adding=20 > subport level bandwidth profiles that can be used in runtime. >=20 > --- > v8 -> v9 > - updated ABI section in release notes. > - Addressed review comments from patch 8 > of v8. I was asking a question in my reply to v8 but you didn't hit the "reply" bu= tton. >> sorry for that. All the question raised by you were relevant so I addres= sed them and sent out v9.=20 One more question: why don't you keep the ack given by Cristian in v7? >> I am carrying ack given Cristian in v9, but It is at the bottom of cover= letter. >> should I resend the patch placing ack just before version changes inf= o? Hi Thomas, Could you please let me know regarding resending the patch ?