From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F8FDA0546; Wed, 7 Apr 2021 03:00:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B36BB407FF; Wed, 7 Apr 2021 03:00:13 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2082.outbound.protection.outlook.com [40.107.92.82]) by mails.dpdk.org (Postfix) with ESMTP id D0DE24069F for ; Wed, 7 Apr 2021 03:00:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmfld0l04gu+qBMlepBO8vnBxcd1gY+vC9ewyv7P4TR6K6s47MXeZn+Xw/o4YgVp4F6kxx3AGr3GWz8lsDUxHtwUD3+Kn2N4CtpXMu/cZ3aGmhfP4Qqv4ej+ZetJd35s+MWQpBivoH6lbx8NasT3gKq2rkH91xxlqSjU0VbDeFYP0T2Wqjd2OUdK5kWbnnOQmpAGPgf5nG8OKdVSH0Oz9LbjcKGVZMmuZTYALmoezM9zVgIbn49p4NnhoJhBAAsrrUojtTS+drdYS84MG7aMZHBwYJz7qhJOfUWUg14HjzK9onz1yMQVCQjrplDNz4QpjRjJLFXGCAkCXbcP8KFStQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NlVsUv+yyfm7gg4msobc+sLsVeD01PwiMEBRlUQaQ24=; b=cQiIjKexM6A2PsiDb9ZNVMhvXq+iNcy5ZOiEmKiA70c5DkwMKumoLR1Ct9iEEF1L+MJgGBpho/6OpQMUk0pWtqAUje/1uMkefyRiD9pHY6Pw3dFpb2gAqPRncvvSSB/0x7r+tdsDGTjiiqY1iFJ+RNvyYcZ2SwkA9rUxrTWseZc1tN2O5jzjrrVXFcUCmD+pZWucnlPl9EBXENBpvn1uYFUbu00ybay6JLNnq8XXCzESpbLY8zONmSnqKyGltV2vDDxDQHCKqeGrUb53fYertFbtMxwo/5qEhK24NKPXXeHr3PwRz8chLVDUgmKjMLm7XNMIwu9XYekztJFU7allxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NlVsUv+yyfm7gg4msobc+sLsVeD01PwiMEBRlUQaQ24=; b=PJf1x/bL+UvZjwRB99TXpg0Mdc6tx8Z6WrEdYNtdffNIVxYrMbYrEvV0BaG86LYXlgGt+749ryAKQYCvqoz6i5Jrqw2Rjg4yZDTVnPWwFVZrDc93a9ZyZgjB37nC6fQdBh49JSiQgRnrR1BRmYQ5Yyl5+AN+If8QM2yH6F1VUsYRoPdEJQ+ZCkvG0JXufbwGQ0ckG1kSO4iq5deDlJeGPpodk4NzXT2j+gY2QnIIrzF3hHGmSCaDLwFKZPgcROIfSpPwMj7rev3oztLV4TLRMFX79KV3Izfhpj2I7BQwc0UXFbP9thdFh9pyEomz6Qct/7iZAUlhjsiAmWJ+qZJy2w== Received: from BL0PR12MB2577.namprd12.prod.outlook.com (2603:10b6:207:42::20) by BL0PR12MB2354.namprd12.prod.outlook.com (2603:10b6:207:44::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Wed, 7 Apr 2021 01:00:07 +0000 Received: from BL0PR12MB2577.namprd12.prod.outlook.com ([fe80::3c43:105f:fc60:7786]) by BL0PR12MB2577.namprd12.prod.outlook.com ([fe80::3c43:105f:fc60:7786%6]) with mapi id 15.20.3999.032; Wed, 7 Apr 2021 01:00:07 +0000 From: Suanming Mou To: NBU-Contact-Thomas Monjalon , John Hurley CC: Ori Kam , "dev@dpdk.org" , Slava Ovsiienko , Matan Azrad , Raslan Darawsheh Thread-Topic: [dpdk-dev] [PATCH v3 4/4] regex/mlx5: prevent wrong calculation of free sqs in umr mode Thread-Index: AQHXJQWXcQSAREkAc0SCRG+mmPbzQaqnuA4AgACOl5A= Date: Wed, 7 Apr 2021 01:00:07 +0000 Message-ID: References: <20210309235732.3952418-1-suanmingm@nvidia.com> <20210330013916.1319266-1-suanmingm@nvidia.com> <20210330013916.1319266-5-suanmingm@nvidia.com> <1630409.ut38131ehT@thomas> In-Reply-To: <1630409.ut38131ehT@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [220.184.249.48] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0279a7b-6164-4b0e-9428-08d8f9607c98 x-ms-traffictypediagnostic: BL0PR12MB2354: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SBIFFpJ+MwmN2tnBr9CS9/kZqtScj8U0LBhvs2W0ZiIAkHwTPL2s5JLmchYmiWwZhEWz9AWNZF+kK+u0WHqfMtJ9DWW0SnCzjhAj+B535L9dtnA/b2QgbQvIURnDA4R7Cqj3aZ0025gfgkso/s+rlMXWBNfothBh3r38viOITPOLtlMFSVWLhUzSK1N5r/kbJpva0KJB6ToQTqAxaK9fLf+AtnmhTTilHBkKDrUiV3Sn7Su1LOl7E1V47Unvan6KyhW/UXySw8luWXu26XDnJJV6W9lSV4zGZZ1rCfzQt/xL1NGilaAJ8afS6vmh3SiJsB0sjBS5qU2WjE2tcZj8M2xN8PRST81uRHJjuzCH4tJbYqZvgI3wdnRgsqSFvIxIV7oLMu9llo0E/xYtsLKT1UYGBxSFnm3zOF9s61L8WMJWOTdsiYKzFHI117x46mUset5KxaK7dg1C/6EDh5bkZxzJBWT8FB9gVYACEa/94MsWbV5Fh7vkBplioj0H7u0libAfQNz7KpEl2IPdqzgbSnameOdmnsK7Ed7Udq2xhB0/1ioqRfaueCEdrbNN2F8tpkGgWEzPtuvvkDLLwY7ArOvgoW7kAoC+MHkKdjKyFC1CbvmGriWojtD0wPJHJTcF3Ue996cYsShAafUpgsqxrjs8V17jAMyeYgG3aLX+H6A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB2577.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(83380400001)(66446008)(54906003)(66476007)(66946007)(52536014)(6636002)(9686003)(107886003)(5660300002)(4326008)(7696005)(86362001)(8936002)(33656002)(110136005)(64756008)(38100700001)(6506007)(71200400001)(8676002)(55016002)(76116006)(26005)(2906002)(478600001)(66556008)(186003)(53546011)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?oB3+wOJqN3iP9JqPJiBkfmUrqSol3oSeLMIX9d25QQQYeNhoDr582lnYa8i9?= =?us-ascii?Q?giH/n5FrnUJY0GhnpBZNJYx2jxgabwxt4prasutYtRye07kTFk4NJZIUrWFs?= =?us-ascii?Q?w1C7/nPXh/SRhV/sC5Ux9KS8rV5PYynH6+MAKv1RK+b/K+HkzAZdnbHygOC3?= =?us-ascii?Q?R0mtIxc6pCqHLRURSOYjyS1g+7NwHBJTBZjAfXZWo5SFtJAf7G4Y3iD7s9d4?= =?us-ascii?Q?ocoyDTgzVoPckaYo74qDvsqqSmlDczjFgHeLsvdZ/ZoTKkbvQZTZoEeLCLUT?= =?us-ascii?Q?cy4d8aGhvT3luTDy1+bXGLK3er6xYFiwHvUpjm4rsbXsWQeu8tzOrn8AnvEP?= =?us-ascii?Q?p79hWMg4Sk2nXhX/CB1hqKFSFSuksTnf7wtKPGxSQv/OWOvUDNpHcvIoSd0G?= =?us-ascii?Q?sgFPvG2WBclk1e9xRmk+PYT/6HlSQuHBAqHXNt7zbNQXDndTmWcvgWe9+QJ7?= =?us-ascii?Q?SJ+Ht6eQ+XVd+WTYE1LjbCNf/PShreUGHI4OhVFH2sAj35C3SGeVTvz60XRU?= =?us-ascii?Q?nLPLphNzpBSAP+B1iwsH3SF+dEwM5VSghPVWczZJk1k4/jJ+3KttLMgozqjj?= =?us-ascii?Q?Supp7lFrza/lRxlwGJRC1TaTQGm6vWq/nlh7yK7JXZT3ixAuX1jLeuDNlGXd?= =?us-ascii?Q?mXyDRQKDaaRHT4j5WpPDxB1jPaZqzQkOYjXTo/u/1/mDsRh/d6Jy83XPu9XQ?= =?us-ascii?Q?1BJrzJuXGhAnYZ+ACx1emzmf97cMmA6B1PlbvZdlQH7+DHgScB7hdWUUHEol?= =?us-ascii?Q?KOHteFKqTVpAmnuO8nHWbwvUY+ZJ/0CBciF2i3hZc4sSrLvQfjs/N7i39Bv0?= =?us-ascii?Q?fI8wNaL201Oi8Ums3Ihy0YKJgLjMa9DwOWpg+qBgEXT/Ylaio2iqBtDGe4Rn?= =?us-ascii?Q?ye3sUfpvifBBtYDAZ5YMhe2Br5K7Tj5nQtb6xZiDomPvrlBSkAiSMW926Fxy?= =?us-ascii?Q?NNLGUZDSVb8M/N/8d45yL3SeaprF8nOhqhSNs/5bqa4nacorgwdoCmz91nxk?= =?us-ascii?Q?i7U01f0dTTlHcIbd9ON2XTP3IJKV87yRLiHrXJziN8BJlj/CWBx9VP1fGX2/?= =?us-ascii?Q?zZMsJxucaxxbb+s2bPJTIa2/VBqMwCQuL3wQ6OKUmO+P+pQSt+jX0WenUYt6?= =?us-ascii?Q?r26zfJRGkaVdA2KQgX0DgKCskxxJDu8+iJuuKe3F8o9rQBVLCyNJowHRWLK2?= =?us-ascii?Q?fQF5i7cI9qLuY7M/pUQZvuTQFZ9mDHYxhgNi8iBthPNWusxXyi7noBjcJU7a?= =?us-ascii?Q?o9XsFJGC1FujRRhQ4+j4kEO5T8rn0XAyCP2aa7Pmk+iG8OjiW8S6+FC+vQOg?= =?us-ascii?Q?PfSyjOeba8XetgTWUFilTbfB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2577.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0279a7b-6164-4b0e-9428-08d8f9607c98 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 01:00:07.3357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nk9McZlxGAQ8iLzz12v5UTztN7e1c9Jizgd33aVUyO60TzMfpKpNWh48uK9EBaXeVJ+SLK1uhqVp+NiWWCX8PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2354 Subject: Re: [dpdk-dev] [PATCH v3 4/4] regex/mlx5: prevent wrong calculation of free sqs in umr mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 7, 2021 12:23 AM > To: John Hurley ; Suanming Mou > > Cc: Ori Kam ; dev@dpdk.org; Slava Ovsiienko > ; Matan Azrad ; Raslan > Darawsheh > Subject: Re: [dpdk-dev] [PATCH v3 4/4] regex/mlx5: prevent wrong calculat= ion > of free sqs in umr mode >=20 > 30/03/2021 03:39, Suanming Mou: > > From: John Hurley > > > > A recent change adds support for scattered mbuf and UMR support for reg= ex. > > Part of this commit makes the pi and ci counters of the regex_sq a > > quarter of the length in non umr mode, effectively moving them from 16 > > bits to 14. The new get_free method casts the difference in pi and ci > > to a 16 bit value when calculating the free send queues, accounting > > for any wrapping when pi has looped back to 0 but ci has not yet. > > However, the move to 14 bits while still casting to 16 can now lead to > > corrupted, large values returned. > > > > Modify the get_free function to take in the has_umr flag and, > > accordingly, account for wrapping on either 14 or 16 bit pi/ci differen= ce. > > > > Fixes: d55c9f637263 ("regex/mlx5: add data path scattered mbuf > > process") >=20 > It is fixing a patch in this series, right? > Why not squashing them? Yes, this is a fix for this series.=20 This fix was done by John when he tested the code, so I put it as an indivi= dual one. Should we update an new version to squash it? (And Thomas, the latest version of this series is v4, you comment in this o= ld v3 version now :) ) >=20 >=20